Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maintain links consistency #106

Merged
merged 4 commits into from
Nov 4, 2023
Merged

Maintain links consistency #106

merged 4 commits into from
Nov 4, 2023

Conversation

john0isaac
Copy link
Contributor

@leestott around QA automation

Apply rule for regex to pick up the paths:

  • relative URL cannot start with (/) it has to either start with (./) or (../)

Fix for the GitHub pages (refer to #92)

  • @kinfey the .MD file in lesson 03 didn't work on the deployed GitHub pages before so, I renamed the file and changed the reference to it. please review

Copy link
Contributor

@leestott leestott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@john0isaac I think your proposed changes of ../ in front of relative links may cause issues for the GitHub pages deployment can you test this.

Copy link
Contributor

@leestott leestott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @john0isaac

@leestott leestott merged commit 3972e69 into microsoft:main Nov 4, 2023
@john0isaac john0isaac deleted the maintain-links-consistency branch November 4, 2023 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants