Conditionally allocate CustomCommandManager to reduce overhead #829
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vazois
requested changes
Nov 25, 2024
| @@ -185,7 +185,7 @@ public RespServerSession( | |||
| bool enableScripts) | |||
| : base(networkSender) | |||
| { | |||
| this.customCommandManagerSession = new CustomCommandManagerSession(storeWrapper.customCommandManager); | |||
| this.customCommandManagerSession = storeWrapper.serverOptions.LoadModuleCS != null ? new CustomCommandManagerSession(storeWrapper.customCommandManager) : null; | |||
There was a problem hiding this comment.
Good catch! However, you have to update the unit tests also to enable LoadModuleCS because the ones using modules are breaking.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, even if CustomCommands are not required, a CustomCommandManager session is silently created with every RespSession and adds an overhead of ~1MB per connection. For ~10k connections, this overhead can be huge upto 10GB. Not trying to address the overhead amount here but disabling it for scenarios which don't even use CustomCommands.
From memory dump
