-
Notifications
You must be signed in to change notification settings - Fork 552
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Basic Lua scripting support #550
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…into badrishc/lua-script-v0
…into badrishc/lua-script-v0
End-to-End PerformanceIncreasing number of client sessions, 8-byte keys and values, using
How to run:
How to run: |
Meir017
reviewed
Aug 11, 2024
Meir017
reviewed
Aug 11, 2024
Meir017
reviewed
Aug 11, 2024
Meir017
reviewed
Aug 11, 2024
Co-authored-by: Meir Blachman <[email protected]>
…into badrishc/lua-script-v0
TedHartMS
requested changes
Aug 14, 2024
TedHartMS
approved these changes
Aug 14, 2024
TalZaccai
reviewed
Aug 15, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds very basic support for Lua scripts in Garnet (EVAL, EVALSHA, SCRIPT commands) using the NLua library. We hope for contributions from the community to extend as per their needs. Consider this a research prototype. Note that performance is not expected to be as good as C# custom procedures and transactions, due to the overheads of Lua scripts and the conversions from C# to Lua and back.
Tasks:
--lua
andEnableLua
) to enable Lua script on server (turned off by default)--lua-transaction-mode
andLuaTransactionMode
boolean optionFuture work:
LuaTransactionMode
on a per-script basisEVAL_RO
)Fix #509