Fix a11y issues in List examples #33181
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
📊 Bundle size report✅ No changes found |
bsunderhus
approved these changes
Oct 31, 2024
kolaps33
reviewed
Oct 31, 2024
| @@ -62,13 +62,15 @@ export const ListActiveElement = () => { | |||
| return ( | |||
| <div> | |||
| <List | |||
| as="div" | |||
There was a problem hiding this comment.
cannot we render it in the code as "div" ?
because what I understand now every developer who will use will need to do it by themself...
And they may to forget do that...
kolaps33
reviewed
Oct 31, 2024
|
|
||
| return ( | ||
| <ListItem | ||
| value={props.value} | ||
| as="div" | ||
| value={value} |
There was a problem hiding this comment.
the same as comment above, if we can render by default as div ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated the examples for List to fix most of the a11y issues found with the "Accessibility Insights for Web" tool.
2 remaining issues are:
aria-hidden-focus
on the tabster-specific elements. This is not actionable
nested-interactive
on the selectable simple list items. This is okay, as the listbox behavior is emulated through mouse/keyboard handlers and checkbox is there only for visualization, and/or screen reader support.