Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(web-components): add missing exports and cleanup options #32405

Merged
merged 3 commits into from
Aug 28, 2024
Merged

chore(web-components): add missing exports and cleanup options #32405

merged 3 commits into from
Aug 28, 2024

Conversation

davatron5000
Copy link
Contributor

@davatron5000 davatron5000 commented Aug 28, 2024 •
edited
Loading

Previous Behavior

  • Missing LinkStyles export
  • Missing MessageBar exports
  • default options unnecessary

New Behavior

  • Adds LinkStyles export
  • Adds all MessageBar exports
  • removes unneccesary margin and padding styles from LinkStyles
  • removes default option from ComponentOptions
  • fixes Baseline table in docs (broken in SB7 upgrade)
  • removes unnecessary false assignments on optional?: boolean = false attributes

@davatron5000 davatron5000 requested a review from a team as a code owner August 28, 2024 17:20
@fabricteam
Copy link
Collaborator

fabricteam commented Aug 28, 2024 •
edited
Loading

📊 Bundle size report

✅ No changes found

@fabricteam
Copy link
Collaborator

fabricteam commented Aug 28, 2024 •
edited
Loading

🕵 fluentui-web-components-v3 No visual regressions between this PR and main

@davatron5000 davatron5000 force-pushed the chore/add-missing-exports-and-cleanup-options branch from 324ac15 to 1fad564 Compare August 28, 2024 17:34
@davatron5000 davatron5000 merged commit e15398a into microsoft:master Aug 28, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chrisdholt chrisdholt chrisdholt approved these changes

Assignees
No one assigned
Labels
web-components
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@davatron5000 @fabricteam @chrisdholt