Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: always trigger build on dependencies for test-integration target #32277

Merged
merged 1 commit into from
Aug 12, 2024

Conversation

Hotell
Copy link
Contributor

@Hotell Hotell commented Aug 12, 2024

Previous Behavior

issue that surfaced in #32269 is still present in cra project.

New Behavior

we now always trigger build on dependencies ( even if build target is not present at "self" -> which was the cause of not triggering anything before )

Related Issue(s)

@github-actions github-actions bot added this to the August Project Cycle Q3 2024 milestone Aug 12, 2024
@Hotell Hotell changed the title chore: make sure test-integration target always triggers build on dep… chore: make sure test-integration target always triggers build on dependencies Aug 12, 2024
@fabricteam
Copy link
Collaborator

🕵 FluentUIV0 No visual regressions between this PR and main

@fabricteam
Copy link
Collaborator

Perf Analysis (@fluentui/react-components)

Scenario Render type Master Ticks PR Ticks Iterations Status
FluentProviderWithTheme virtual-rerender 39 41 10 Possible regression
All results

Scenario Render type Master Ticks PR Ticks Iterations Status
Avatar mount 633 627 5000
Button mount 312 315 5000
Field mount 1158 1142 5000
FluentProvider mount 731 720 5000
FluentProviderWithTheme mount 82 86 10
FluentProviderWithTheme virtual-rerender 39 41 10 Possible regression
FluentProviderWithTheme virtual-rerender-with-unmount 82 84 10
MakeStyles mount 879 860 50000
Persona mount 1762 1709 5000
SpinButton mount 1433 1369 5000
SwatchPicker mount 1660 1664 5000

@fabricteam
Copy link
Collaborator

📊 Bundle size report

✅ No changes found

@fabricteam
Copy link
Collaborator

Perf Analysis (@fluentui/react-northstar)

Perf tests with no regressions
Scenario Current PR Ticks Baseline Ticks Ratio
AlertMinimalPerf.default 181 153 1.18:1
AccordionMinimalPerf.default 92 80 1.15:1
TextMinimalPerf.default 214 192 1.11:1
PortalMinimalPerf.default 95 86 1.1:1
ImageMinimalPerf.default 226 208 1.09:1
IconMinimalPerf.default 417 384 1.09:1
TableMinimalPerf.default 254 233 1.09:1
FlexMinimalPerf.default 166 153 1.08:1
ChatDuplicateMessagesPerf.default 158 147 1.07:1
DropdownManyItemsPerf.default 406 378 1.07:1
LayoutMinimalPerf.default 204 191 1.07:1
TextAreaMinimalPerf.default 304 285 1.07:1
AvatarMinimalPerf.default 111 105 1.06:1
BoxMinimalPerf.default 205 194 1.06:1
DividerMinimalPerf.default 210 199 1.06:1
RefMinimalPerf.default 115 108 1.06:1
TreeWith60ListItems.default 91 86 1.06:1
AttachmentSlotsPerf.default 674 641 1.05:1
ChatMinimalPerf.default 458 438 1.05:1
ChatWithPopoverPerf.default 201 192 1.05:1
ListWith60ListItems.default 380 361 1.05:1
MenuMinimalPerf.default 533 507 1.05:1
DialogMinimalPerf.default 450 432 1.04:1
FormMinimalPerf.default 225 216 1.04:1
ButtonMinimalPerf.default 95 92 1.03:1
CarouselMinimalPerf.default 266 258 1.03:1
InputMinimalPerf.default 559 545 1.03:1
ListMinimalPerf.default 310 302 1.03:1
LoaderMinimalPerf.default 184 179 1.03:1
ProviderMinimalPerf.default 206 200 1.03:1
SkeletonMinimalPerf.default 196 191 1.03:1
TableManyItemsPerf.default 1123 1090 1.03:1
CheckboxMinimalPerf.default 1152 1125 1.02:1
EmbedMinimalPerf.default 1890 1853 1.02:1
HeaderSlotsPerf.default 467 456 1.02:1
ItemLayoutMinimalPerf.default 704 693 1.02:1
ListNestedPerf.default 330 323 1.02:1
RosterPerf.default 1600 1568 1.02:1
ReactionMinimalPerf.default 214 210 1.02:1
TreeMinimalPerf.default 505 496 1.02:1
DropdownMinimalPerf.default 1430 1418 1.01:1
LabelMinimalPerf.default 217 214 1.01:1
MenuButtonMinimalPerf.default 967 962 1.01:1
SplitButtonMinimalPerf.default 2290 2268 1.01:1
StatusMinimalPerf.default 393 390 1.01:1
DatepickerMinimalPerf.default 3615 3621 1:1
ListCommonPerf.default 395 395 1:1
PopupMinimalPerf.default 354 355 1:1
CustomToolbarPrototype.default 1452 1456 1:1
AnimationMinimalPerf.default 298 301 0.99:1
ButtonSlotsPerf.default 311 313 0.99:1
CardMinimalPerf.default 295 298 0.99:1
ProviderMergeThemesPerf.default 659 665 0.99:1
RadioGroupMinimalPerf.default 257 260 0.99:1
ToolbarMinimalPerf.default 541 548 0.99:1
ButtonOverridesMissPerf.default 648 664 0.98:1
TooltipMinimalPerf.default 1305 1326 0.98:1
VideoMinimalPerf.default 443 451 0.98:1
HeaderMinimalPerf.default 205 211 0.97:1
SliderMinimalPerf.default 741 764 0.97:1
GridMinimalPerf.default 182 191 0.95:1
SegmentMinimalPerf.default 190 206 0.92:1
AttachmentMinimalPerf.default 71 82 0.87:1

@fabricteam
Copy link
Collaborator

Perf Analysis (@fluentui/react)

No significant results to display.

All results

Scenario Render type Master Ticks PR Ticks Iterations Status
BaseButton mount 638 630 5000
Breadcrumb mount 1710 1665 1000
Checkbox mount 1706 1689 5000
CheckboxBase mount 1491 1492 5000
ChoiceGroup mount 2964 3051 5000
ComboBox mount 710 673 1000
CommandBar mount 6622 6521 1000
ContextualMenu mount 12540 12583 1000
DefaultButton mount 809 800 5000
DetailsRow mount 2244 2201 5000
DetailsRowFast mount 2216 2249 5000
DetailsRowNoStyles mount 2077 2119 5000
Dialog mount 2688 2730 1000
DocumentCardTitle mount 221 232 1000
Dropdown mount 2006 2008 5000
FocusTrapZone mount 1177 1122 5000
FocusZone mount 1097 1094 5000
GroupedList mount 42161 42019 2
GroupedList virtual-rerender 20483 20297 2
GroupedList virtual-rerender-with-unmount 51821 51786 2
GroupedListV2 mount 232 215 2
GroupedListV2 virtual-rerender 216 219 2
GroupedListV2 virtual-rerender-with-unmount 237 238 2
IconButton mount 1150 1151 5000
Label mount 357 343 5000
Layer mount 2725 2739 5000
Link mount 391 394 5000
MenuButton mount 984 980 5000
MessageBar mount 21501 21525 5000
Nav mount 2037 2067 1000
OverflowSet mount 795 783 5000
Panel mount 1808 1892 1000
Persona mount 748 768 1000
Pivot mount 911 906 1000
PrimaryButton mount 931 947 5000
Rating mount 4675 4757 5000
SearchBox mount 926 933 5000
Shimmer mount 1935 1928 5000
Slider mount 1355 1320 5000
SpinButton mount 3031 3052 5000
Spinner mount 384 395 5000
SplitButton mount 1888 1872 5000
Stack mount 439 431 5000
StackWithIntrinsicChildren mount 888 864 5000
StackWithTextChildren mount 2753 2817 5000
SwatchColorPicker mount 6348 6411 5000
TagPicker mount 1514 1478 5000
Text mount 400 397 5000
TextField mount 948 922 5000
ThemeProvider mount 874 866 5000
ThemeProvider virtual-rerender 597 592 5000
ThemeProvider virtual-rerender-with-unmount 1308 1302 5000
Toggle mount 630 632 5000
buttonNative mount 194 192 5000

@Hotell Hotell changed the title chore: make sure test-integration target always triggers build on dependencies chore: always trigger build on dependencies for test-integration target Aug 12, 2024
@Hotell Hotell marked this pull request as ready for review August 12, 2024 09:06
@Hotell Hotell requested a review from a team as a code owner August 12, 2024 09:06
@Hotell Hotell merged commit b5e427c into microsoft:master Aug 12, 2024
21 checks passed
@Hotell Hotell deleted the nx/fix-task-deps-v3 branch August 12, 2024 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants