fix(web-components): scope submenu fallback positioning to non-anchor browsers only #32000
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrisdholt
approved these changes
Jul 15, 2024
📊 Bundle size report✅ No changes found |
fabricteam
reviewed
Jul 15, 2024
change/@fluentui-web-components-198bc628-0ffa-41a6-a30f-b159efd70210.json
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous Behavior
In an attempt to fix submenu fallback positioning for non-anchor-supported browsers (Safari/Firefox), I broke positioning in Edge/Chrome.
See submenu in last example in Edge/Chrome: https://web-components.fluentui.dev/?path=/docs/components-menu--menu
New Behavior
This scopes the position fallback position rule needed for older browsers into an
@supports notrule to fix the regression in Edge/Chrome while still providing support to non-Anchor browsers.Related Issue(s)