Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(web-components): cleanup drawer storybook #31991

Merged

Conversation

davatron5000
Copy link
Contributor

@davatron5000 davatron5000 commented Jul 12, 2024

Previous Behavior

Found a visual regression for radio inputs on the Drawer component.

View issue: https://web-components.fluentui.dev/?path=/docs/components-drawer--drawer

New Behavior

  • Updates the story to use the new RadioGroup syntax.
  • Refactors all Drawer stories into a single story with more control options.

Questions

  1. Rolling up the stories into a single story loses a bit of context, how much context do we need?
  2. If we need more context, where should that live?

Note

This exposes a defect where you can't use labels to select a radioitem inside a drawer. Unclear if this is a problem with Drawer or with RadioGroup. I filed a separate issue for that: #31992

@davatron5000 davatron5000 requested a review from a team as a code owner July 12, 2024 22:20
@fabricteam
Copy link
Collaborator

fabricteam commented Jul 12, 2024

📊 Bundle size report

✅ No changes found

@davatron5000 davatron5000 merged commit 1f260f6 into microsoft:master Jul 16, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants