refactor(web-components): reduce code duplication in setTheme() #31679
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marchbox
changed the title
marchbox
changed the title
marchbox
changed the title
📊 Bundle size report✅ No changes found |
fabricteam
reviewed
Jun 12, 2024
change/@fluentui-web-components-0759a8fc-1fd0-40d2-889b-7fbc46b3f129.json
Show resolved
Hide resolved
davatron5000
approved these changes
Jun 12, 2024
miroslavstastny
pushed a commit
to miroslavstastny/fluentui
that referenced
this pull request
Jun 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous Behavior
The same operation (assigning value to
document.body.style) is stated multiple times.New Behavior
Use the existing
setThemeFor()function to reduce duplicated code.