fix(web-components): fix disabled button styles #31585
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrisdholt
reviewed
Jun 5, 2024
📊 Bundle size report✅ No changes found |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
fabricteam
reviewed
Jun 5, 2024
change/@fluentui-web-components-3a27963c-2795-4898-8b1e-adeb72be5c72.json
Show resolved
Hide resolved
chrisdholt
approved these changes
Jun 5, 2024
davatron5000
force-pushed
the
davatron5000/fix-disabled-buttons
branch
from
05baa54 to
2884fe7
Compare
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
janechu
approved these changes
Jun 5, 2024
|
/azp run |
|
Azure Pipelines successfully started running 4 pipeline(s). |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
miroslavstastny
pushed a commit
to miroslavstastny/fluentui
that referenced
this pull request
Jun 14, 2024
Co-authored-by: Chris Holt <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous Behavior
[disabled][appearance="subtle"]fluent-buttons where they are expected to not have a background or outline when disabled, but actually were showing a background and outline.setContent.focusabale" typo in button styles:focus-visiblenot working in High Contrast ModeNew Behavior
[disabled]styles cascade correctly.focusabaletypo)char from:focus-visiblestyles to fix high-contrast mode focus states.setThemeto prevent them being wiped out bypage.setContentCSS.registerPropertywith a fallback to current method for current versions of Firefox and older browsers.The
CSS.registerPropertychange is probably significant enough to heavily scrutinize this PR. It's pretty naive at the moment, just applying aninitialValue. In the future I think we'd want to set actual CSSOM types (integer, pixel values, etc).Look forward to feedback.
Related Issue(s)
Screenshots