fix(web-components): remove determinate from spinner implementation #31404
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spmonahan
approved these changes
May 16, 2024
chrisdholt
force-pushed
the
users/chhol/remove-determinate-from-spinner
branch
from
1a9d708 to
feee0cb
Compare
📊 Bundle size report✅ No changes found |
chrisdholt
force-pushed
the
users/chhol/remove-determinate-from-spinner
branch
from
feee0cb to
97a082f
Compare
fabricteam
reviewed
May 16, 2024
change/@fluentui-web-components-82d13efa-8e97-478a-b1d9-d6b7c6f32868.json
Show resolved
Hide resolved
chrisdholt
force-pushed
the
users/chhol/remove-determinate-from-spinner
branch
from
4e13b29 to
ddd9ceb
Compare
chrisdholt
force-pushed
the
users/chhol/remove-determinate-from-spinner
branch
2 times, most recently
from
8e36b3d to
e243e89
Compare
…value for indeterminate
chrisdholt
force-pushed
the
users/chhol/remove-determinate-from-spinner
branch
from
e243e89 to
923fe8e
Compare
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
janechu
approved these changes
May 17, 2024
miroslavstastny
pushed a commit
to miroslavstastny/fluentui
that referenced
this pull request
Jun 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous Behavior
Spinner optionally could be set as a determinate progress indicator.
New Behavior
There is no construct for a determinate spinner, the behavior has been removed.
Related Issue(s)