divides accordion and accordion item readme #26938
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
📊 Bundle size report🤖 This report was generated against 237267b5ad816d090011c93f2922476c1abfe87f |
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: 237267b5ad816d090011c93f2922476c1abfe87f (build) |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 9473f5d:
|
| **Property Mapping** | ||
| | Fluent UI React 9 | Fluent Web Components 3 | Description of difference | | ||
| |---------------------------|---------------------------|------------------------------------------------------------------------------------------| | ||
| | `defaultOpenItems: number`| `expand: boolean` | _FuiR9_ `defaultOpenItems` is a number property set on the `Accordion` corresponding to the intended `AccordionItem` to be expanded.<hr /> `expand` is a boolean property set directly on the `AccordionItem` intended to be expanded. |
There was a problem hiding this comment.
I would expect defaultOpenItems to be documented both here in accordion-item and in accordion as well.
| | Fluent UI React 9 | Fluent Web Components 3 | Description of difference | | ||
| |---------------------------|---------------------------|------------------------------------------------------------------------------------------| | ||
| | `defaultOpenItems: number`| `expand: boolean` | _FuiR9_ `defaultOpenItems` is a number property set on the `Accordion` corresponding to the intended `AccordionItem` to be expanded.<hr /> `expand` is a boolean property set directly on the `AccordionItem` intended to be expanded. | ||
| | `multiple: boolean` | `expandmode: "single"` | `"multiple"`| | |
There was a problem hiding this comment.
This should be moved to accordion.
Suggested change
| | `multiple: boolean` | `expandmode: "single"` | `"multiple"`| | | |
| | `multiple: boolean` | `expand-mode: "single"` | `"multiple"`| | |
| | `size` | `size` | | ||
| | `as: 'h1'` | `'h2'` | `'h3'` | `'h4'` | `'h5'` | `'h6'` | `headinglevel: 1` | `2` | `3` | `4` | `5` | `6` | `as` property sets a wrapper around the `AccordionItem` header with the corresponding header tag ( `h1`, `h2`, etc. ) <hr /> `headinglevel` sets the `aria-level` attribute to the corresponding heading level. | ||
| | `disabled` | `disabled` | | ||
| | `expandIconPosition` | `expandIconPosition` | |
There was a problem hiding this comment.
Suggested change
| | `expandIconPosition` | `expandIconPosition` | | |
| | `expandIconPosition` | `expand-icon-position` | |
chrisdholt
approved these changes
Feb 23, 2023
…ntui into web-components-v3
miroslavstastny
approved these changes
Feb 24, 2023
…ntui into web-components-v3
…//github.com/microsoft/fluentui into user/brianbrady/webComponentAccordionDocsFix
chrisdholt
pushed a commit
that referenced
this pull request
Apr 29, 2024
* divides accordion and accordion item readme * updates accordion docs * updates accordion docs * formats docs table * yarn change
radium-v
pushed a commit
to radium-v/fluentui
that referenced
this pull request
Apr 29, 2024
* divides accordion and accordion item readme * updates accordion docs * updates accordion docs * formats docs table * yarn change
radium-v
pushed a commit
to radium-v/fluentui
that referenced
this pull request
Apr 29, 2024
* divides accordion and accordion item readme * updates accordion docs * updates accordion docs * formats docs table * yarn change
radium-v
pushed a commit
to radium-v/fluentui
that referenced
this pull request
Apr 30, 2024
* divides accordion and accordion item readme * updates accordion docs * updates accordion docs * formats docs table * yarn change
radium-v
pushed a commit
that referenced
this pull request
Apr 30, 2024
* divides accordion and accordion item readme * updates accordion docs * updates accordion docs * formats docs table * yarn change
radium-v
pushed a commit
that referenced
this pull request
May 2, 2024
* divides accordion and accordion item readme * updates accordion docs * updates accordion docs * formats docs table * yarn change
radium-v
pushed a commit
that referenced
this pull request
May 2, 2024
* divides accordion and accordion item readme * updates accordion docs * updates accordion docs * formats docs table * yarn change
radium-v
pushed a commit
that referenced
this pull request
May 2, 2024
* divides accordion and accordion item readme * updates accordion docs * updates accordion docs * formats docs table * yarn change
radium-v
pushed a commit
that referenced
this pull request
May 3, 2024
* divides accordion and accordion item readme * updates accordion docs * updates accordion docs * formats docs table * yarn change
radium-v
pushed a commit
that referenced
this pull request
May 6, 2024
* divides accordion and accordion item readme * updates accordion docs * updates accordion docs * formats docs table * yarn change
radium-v
pushed a commit
that referenced
this pull request
May 6, 2024
* divides accordion and accordion item readme * updates accordion docs * updates accordion docs * formats docs table * yarn change
radium-v
pushed a commit
that referenced
this pull request
May 8, 2024
* divides accordion and accordion item readme * updates accordion docs * updates accordion docs * formats docs table * yarn change
radium-v
pushed a commit
that referenced
this pull request
May 10, 2024
* divides accordion and accordion item readme * updates accordion docs * updates accordion docs * formats docs table * yarn change
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Divides Accordion and Accordion Item docs into two separate README