Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(react-dialog): adds VR tests for Dialog components #24978

Merged
merged 1 commit into from
Sep 30, 2022

Conversation

bsunderhus
Copy link
Contributor

Adds VR tests for Dialog components

@fabricteam
Copy link
Collaborator

fabricteam commented Sep 27, 2022

📊 Bundle size report

🤖 This report was generated against 36287e1ecdb6a5e4d9396ef05965890053de2c7b

@codesandbox-ci
Copy link

codesandbox-ci bot commented Sep 27, 2022

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 2418b2a:

Sandbox Source
@fluentui/react 8 starter Configuration
@fluentui/react-components 9 starter Configuration

@size-auditor
Copy link

size-auditor bot commented Sep 27, 2022

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: 36287e1ecdb6a5e4d9396ef05965890053de2c7b (build)

@bsunderhus bsunderhus marked this pull request as ready for review September 27, 2022 18:59
@bsunderhus bsunderhus requested a review from a team as a code owner September 27, 2022 18:59
@bsunderhus bsunderhus force-pushed the react-dialog/adds-vr-tests branch 5 times, most recently from c74c7a2 to ae00225 Compare September 29, 2022 13:11
@bsunderhus bsunderhus force-pushed the react-dialog/adds-vr-tests branch from ae00225 to 2418b2a Compare September 30, 2022 09:20
@bsunderhus bsunderhus closed this Sep 30, 2022
@bsunderhus bsunderhus reopened this Sep 30, 2022
@bsunderhus bsunderhus merged commit 5eb849d into microsoft:master Sep 30, 2022
@bsunderhus bsunderhus deleted the react-dialog/adds-vr-tests branch September 30, 2022 13:07
GeoffCoxMSFT pushed a commit to GeoffCoxMSFT/fluentui that referenced this pull request Oct 3, 2022
NotWoods pushed a commit to NotWoods/fluentui that referenced this pull request Nov 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants