Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(react-dialog): scaffold DialogContent component #24844

Conversation

bsunderhus
Copy link
Contributor

@bsunderhus bsunderhus commented Sep 17, 2022

  1. Scaffolds DialogContent component with yarn create-component
  2. bugfix: exports DialogSurfaceElement to ensure new API extractor validation.

@fabricteam
Copy link
Collaborator

fabricteam commented Sep 17, 2022

📊 Bundle size report

Package & Exports Baseline (minified/GZIP) PR Change
react-dialog
Dialog (including children components)
81.048 kB
24.208 kB
81.199 kB
24.196 kB
151 B
-12 B
Unchanged fixtures
Package & Exports Size (minified/GZIP)
react-components
react-components: Accordion, Button, FluentProvider, Image, Menu, Popover
188.672 kB
52.359 kB
react-components
react-components: FluentProvider & webLightTheme
33.394 kB
11.007 kB
react-portal-compat
PortalCompatProvider
5.851 kB
1.964 kB
🤖 This report was generated against 17278782ca2c1d4051389cf8741224cde6672e88

@size-auditor
Copy link

size-auditor bot commented Sep 17, 2022

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: 17278782ca2c1d4051389cf8741224cde6672e88 (build)

@fabricteam
Copy link
Collaborator

fabricteam commented Sep 17, 2022

Perf Analysis (@fluentui/react-components)

No significant results to display.

All results

Scenario Render type Master Ticks PR Ticks Iterations Status
Avatar mount 1290 1312 5000
Button mount 957 954 5000
FluentProvider mount 1584 1569 5000
FluentProviderWithTheme mount 632 629 10
FluentProviderWithTheme virtual-rerender 597 595 10
FluentProviderWithTheme virtual-rerender-with-unmount 636 622 10
MakeStyles mount 1893 1888 50000
SpinButton mount 2491 2524 5000

@bsunderhus bsunderhus force-pushed the chore(react-dialog)--scaffold-DialogContent-compound-component branch from b6f61f1 to ae95adf Compare September 19, 2022 08:30
@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit ae95adf:

Sandbox Source
@fluentui/react 8 starter Configuration
@fluentui/react-components 9 starter Configuration

@bsunderhus bsunderhus marked this pull request as ready for review September 19, 2022 11:17
@bsunderhus bsunderhus requested a review from a team as a code owner September 19, 2022 11:17
@bsunderhus bsunderhus merged commit cf5f5e1 into microsoft:master Sep 19, 2022
@bsunderhus bsunderhus deleted the chore(react-dialog)--scaffold-DialogContent-compound-component branch September 19, 2022 13:01
Comment on lines +7 to +8
"declarationDir": "../../../dist/out-tsc/types",
"outDir": "../../../dist/out-tsc",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it expected?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's a part of the updated migration generator which is when during create-component command

marcosmoura added a commit to marcosmoura/fluentui that referenced this pull request Sep 19, 2022
* master: (28 commits)
  fix: use trigger prop for aria-haspopup (microsoft#24794)
  chore(react-dialog): scaffold DialogContent component (microsoft#24844)
  chore: Northstar screener should read from screenerStates.json (microsoft#24848)
  applying package updates
  (web components) Standardize focus treatment (microsoft#24771)
  Divider - allow default prop override (microsoft#24840)
  GroupedList: fix virtualization (unstable preview) (microsoft#24460)
  fix: Add explicit children prop to TeachingBubble to support React 18 (microsoft#24823)
  feat: Adds `visible` prop to `TableCellActions` (microsoft#24831)
  [Northstar][Dropdown] Fix styling mutation when merging themes (microsoft#24787)
  fix: export `tableCellActionsClassNames` from unstable (microsoft#24830)
  bugfix(react-dialog): Adds color style to DialogSurface (microsoft#24832)
  applying package updates
  Prevent group toggling from selecting the whole group (microsoft#24822)
  feat(react-textarea): Add shadow variant of filled appearance (microsoft#24512)
  applying package updates
  Adding lib-commonjs top-level entries to exports map (microsoft#24792)
  Created shim packages (microsoft#24780)
  feat(react-menu): replace keydown handlers by useARIAButtonShorthand on MenuItem (microsoft#24738)
  fix: update version mismatches triggered by v9 release (microsoft#24812)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants