Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #20043 - Checkbox checkmark should have opacity 0 in indeterminate state #21005

Merged
merged 3 commits into from
Dec 14, 2021
Merged

Fix #20043 - Checkbox checkmark should have opacity 0 in indeterminate state #21005

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b28de77
Made checkmark opacity 0 for indeterminate
GeoffCoxMSFT Dec 13, 2021
a6a2513
Change files
GeoffCoxMSFT Dec 13, 2021
6e6f6ed
Updated snapshot
GeoffCoxMSFT Dec 14, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions change/@fluentui-react-ad24fc8e-0cbf-4ec4-a54b-e64f35b51637.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
{
"type": "patch",
"comment": "Made checkmark opacity 0 for indeterminate",
"packageName": "@fluentui/react",
"email": "[email protected]",
"dependentChangeType": "patch"
}
2 changes: 1 addition & 1 deletion packages/react-examples/src/react/__snapshots__/Checkbox.Indeterminate.Example.tsx.shot
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -351,7 +351,7 @@ exports[`Component Examples renders Checkbox.Indeterminate.Example.tsx correctly
font-family: "FabricMDL2Icons";
font-style: normal;
font-weight: normal;
opacity: 1;
opacity: 0;
speak: none;
}
@media screen and (-ms-high-contrast: active), (forced-colors: active){& {
Expand Down
2 changes: 1 addition & 1 deletion packages/react/src/components/Checkbox/Checkbox.styles.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -251,7 +251,7 @@ export const getStyles = (props: ICheckboxStyleProps): ICheckboxStyles => {
checkmark: [
classNames.checkmark,
{
opacity: checked ? '1' : '0',
opacity: checked && !indeterminate ? '1' : '0',
color: checkmarkFontColor,
[HighContrastSelector]: {
color: disabled ? 'GrayText' : 'Window',
Expand Down