Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: vertical tabs from jumping #20641

Merged
merged 2 commits into from
Dec 1, 2021
Merged

fix: vertical tabs from jumping #20641

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b8258a7
fix: tabpanel shifting in vertical layout
eljefe223 Nov 17, 2021
22be6a9
Change files
eljefe223 Nov 17, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions change/@fluentui-web-components-8052c655-9663-4c94-bc57-b4090f16ab2d.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
{
"type": "patch",
"comment": "fix: tabpanel shifting in vertical layout",
"packageName": "@fluentui/web-components",
"email": "[email protected]",
"dependentChangeType": "patch"
}
58 changes: 56 additions & 2 deletions packages/web-components/src/tabs/tabs.stories.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,9 +23,63 @@ const TabsTemplate = ({ activeId, activeIndicator, orientation }) => `
<fluent-tab id="TabOne">Tab one</fluent-tab>
<fluent-tab id="TabTwo">Tab two</fluent-tab>
<fluent-tab id="TabThree">Tab three</fluent-tab>
<fluent-tab-panel> Tab one content. This is for testing. </fluent-tab-panel>
<fluent-tab-panel>
Tab one content. This is for testing. Tab three content. This is for testing.
<br />
Tab one content. This is for testing.
<br />
Tab one content. This is for testing.
<br />
Tab one content. This is for testing.
<br />
Tab one content. This is for testing.
<br />
Tab one content. This is for testing.
<br />
Tab one content. This is for testing.
<br />
Tab one content. This is for testing.
<br />
Tab one content. This is for testing.
<br />
Tab one content. This is for testing.
<br />
Tab one content. This is for testing.
<br />
Tab one content. This is for testing.
<br />
Tab one content. This is for testing.
<br />
</fluent-tab-panel>
<fluent-tab-panel> Tab two content. This is for testing. </fluent-tab-panel>
<fluent-tab-panel> Tab three content. This is for testing. </fluent-tab-panel>
<fluent-tab-panel>
Tab three content. This is for testing. Tab three content. This is for testing.
<br />
Tab three content. This is for testing.
eljefe223 marked this conversation as resolved.
Show resolved Hide resolved
<br />
Tab three content. This is for testing.
<br />
Tab three content. This is for testing.
<br />
Tab three content. This is for testing.
<br />
Tab three content. This is for testing.
<br />
Tab three content. This is for testing.
<br />
Tab three content. This is for testing.
<br />
Tab three content. This is for testing.
<br />
Tab three content. This is for testing.
<br />
Tab three content. This is for testing.
<br />
Tab three content. This is for testing.
<br />
Tab three content. This is for testing.
<br />
</fluent-tab-panel>
</fluent-tabs>`;

export const Tabs = TabsTemplate.bind({});
Expand Down
1 change: 1 addition & 0 deletions packages/web-components/src/tabs/tabs.styles.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,6 +81,7 @@ export const tabsStyles: (
position: relative;
width: max-content;
justify-self: end;
align-self: flex-start;
width: 100%;
}

Expand Down