(web-components): update foundation package and ensure react docs updated #20316
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrisdholt
requested review from
EisenbergEffect,
nicholasrice and
a team
as code owners
EisenbergEffect
approved these changes
Oct 22, 2021
bheston
approved these changes
Oct 22, 2021
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: a03d96f7aa8f5d480e7166353cc8ac69625d7166 (build) |
📊 Bundle size reportUnchanged fixtures
|
Perf Analysis (
|
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| Avatar | mount | 968 | 937 | 5000 | |
| BaseButton | mount | 948 | 909 | 5000 | |
| Breadcrumb | mount | 2668 | 2667 | 1000 | |
| ButtonNext | mount | 508 | 510 | 5000 | |
| Checkbox | mount | 1571 | 1579 | 5000 | |
| CheckboxBase | mount | 1304 | 1325 | 5000 | |
| ChoiceGroup | mount | 4854 | 4796 | 5000 | |
| ComboBox | mount | 983 | 988 | 1000 | |
| CommandBar | mount | 10451 | 10431 | 1000 | |
| ContextualMenu | mount | 6548 | 6519 | 1000 | |
| DefaultButton | mount | 1178 | 1180 | 5000 | |
| DetailsRow | mount | 3788 | 3828 | 5000 | |
| DetailsRowFast | mount | 3814 | 3921 | 5000 | |
| DetailsRowNoStyles | mount | 3661 | 3673 | 5000 | |
| Dialog | mount | 2536 | 2522 | 1000 | |
| DocumentCardTitle | mount | 172 | 178 | 1000 | |
| Dropdown | mount | 3280 | 3345 | 5000 | |
| FluentProviderNext | mount | 3469 | 3493 | 5000 | |
| FluentProviderWithTheme | mount | 222 | 207 | 10 | |
| FluentProviderWithTheme | virtual-rerender | 110 | 99 | 10 | |
| FluentProviderWithTheme | virtual-rerender-with-unmount | 231 | 249 | 10 | |
| FocusTrapZone | mount | 1851 | 1840 | 5000 | |
| FocusZone | mount | 1866 | 1838 | 5000 | |
| IconButton | mount | 1808 | 1751 | 5000 | |
| Label | mount | 374 | 385 | 5000 | |
| Layer | mount | 3044 | 3020 | 5000 | |
| Link | mount | 493 | 503 | 5000 | |
| MakeStyles | mount | 1885 | 1844 | 50000 | |
| MenuButton | mount | 1514 | 1496 | 5000 | |
| MessageBar | mount | 2059 | 2053 | 5000 | |
| Nav | mount | 3378 | 3370 | 1000 | |
| OverflowSet | mount | 1158 | 1148 | 5000 | |
| Panel | mount | 2386 | 2402 | 1000 | |
| Persona | mount | 894 | 857 | 1000 | |
| Pivot | mount | 1506 | 1475 | 1000 | |
| PrimaryButton | mount | 1326 | 1335 | 5000 | |
| Rating | mount | 7720 | 7930 | 5000 | |
| SearchBox | mount | 1429 | 1390 | 5000 | |
| Shimmer | mount | 2593 | 2570 | 5000 | |
| Slider | mount | 2004 | 1981 | 5000 | |
| SpinButton | mount | 5049 | 5185 | 5000 | |
| Spinner | mount | 445 | 435 | 5000 | |
| SplitButton | mount | 3190 | 3250 | 5000 | |
| Stack | mount | 541 | 523 | 5000 | |
| StackWithIntrinsicChildren | mount | 1728 | 1709 | 5000 | |
| StackWithTextChildren | mount | 4711 | 4728 | 5000 | |
| SwatchColorPicker | mount | 10557 | 10524 | 5000 | |
| Tabs | mount | 1486 | 1430 | 1000 | |
| TagPicker | mount | 2771 | 2647 | 5000 | |
| TeachingBubble | mount | 13340 | 13133 | 5000 | |
| Text | mount | 439 | 450 | 5000 | |
| TextField | mount | 1395 | 1415 | 5000 | |
| ThemeProvider | mount | 1204 | 1248 | 5000 | |
| ThemeProvider | virtual-rerender | 647 | 628 | 5000 | |
| ThemeProvider | virtual-rerender-with-unmount | 1895 | 1964 | 5000 | |
| Toggle | mount | 853 | 816 | 5000 | |
| buttonNative | mount | 136 | 142 | 5000 |
Perf Analysis (@fluentui/react-northstar)
Perf tests with no regressions
| Scenario | Current PR Ticks | Baseline Ticks | Ratio |
|---|---|---|---|
| ButtonMinimalPerf.default | 182 | 164 | 1.11:1 |
| AvatarMinimalPerf.default | 212 | 194 | 1.09:1 |
| SegmentMinimalPerf.default | 371 | 341 | 1.09:1 |
| VideoMinimalPerf.default | 653 | 612 | 1.07:1 |
| ChatDuplicateMessagesPerf.default | 311 | 297 | 1.05:1 |
| ChatMinimalPerf.default | 671 | 644 | 1.04:1 |
| AttachmentMinimalPerf.default | 162 | 158 | 1.03:1 |
| DividerMinimalPerf.default | 366 | 354 | 1.03:1 |
| FlexMinimalPerf.default | 291 | 282 | 1.03:1 |
| SkeletonMinimalPerf.default | 363 | 352 | 1.03:1 |
| ToolbarMinimalPerf.default | 942 | 918 | 1.03:1 |
| AnimationMinimalPerf.default | 413 | 403 | 1.02:1 |
| EmbedMinimalPerf.default | 4348 | 4245 | 1.02:1 |
| HeaderSlotsPerf.default | 758 | 744 | 1.02:1 |
| ItemLayoutMinimalPerf.default | 1244 | 1223 | 1.02:1 |
| SplitButtonMinimalPerf.default | 4357 | 4289 | 1.02:1 |
| TreeMinimalPerf.default | 815 | 800 | 1.02:1 |
| TreeWith60ListItems.default | 184 | 180 | 1.02:1 |
| AccordionMinimalPerf.default | 158 | 157 | 1.01:1 |
| ButtonSlotsPerf.default | 548 | 545 | 1.01:1 |
| CardMinimalPerf.default | 562 | 557 | 1.01:1 |
| CarouselMinimalPerf.default | 466 | 463 | 1.01:1 |
| CheckboxMinimalPerf.default | 2797 | 2768 | 1.01:1 |
| DropdownManyItemsPerf.default | 708 | 702 | 1.01:1 |
| FormMinimalPerf.default | 395 | 391 | 1.01:1 |
| HeaderMinimalPerf.default | 366 | 364 | 1.01:1 |
| ImageMinimalPerf.default | 372 | 367 | 1.01:1 |
| InputMinimalPerf.default | 1324 | 1305 | 1.01:1 |
| LayoutMinimalPerf.default | 365 | 362 | 1.01:1 |
| ListMinimalPerf.default | 515 | 510 | 1.01:1 |
| RosterPerf.default | 1213 | 1196 | 1.01:1 |
| PortalMinimalPerf.default | 177 | 175 | 1.01:1 |
| StatusMinimalPerf.default | 692 | 683 | 1.01:1 |
| TableManyItemsPerf.default | 1904 | 1879 | 1.01:1 |
| TableMinimalPerf.default | 400 | 398 | 1.01:1 |
| CustomToolbarPrototype.default | 4179 | 4139 | 1.01:1 |
| AttachmentSlotsPerf.default | 1111 | 1112 | 1:1 |
| ButtonOverridesMissPerf.default | 1831 | 1835 | 1:1 |
| ListNestedPerf.default | 566 | 564 | 1:1 |
| MenuMinimalPerf.default | 855 | 859 | 1:1 |
| PopupMinimalPerf.default | 597 | 596 | 1:1 |
| ProviderMinimalPerf.default | 1123 | 1124 | 1:1 |
| RadioGroupMinimalPerf.default | 449 | 451 | 1:1 |
| ReactionMinimalPerf.default | 373 | 374 | 1:1 |
| RefMinimalPerf.default | 245 | 245 | 1:1 |
| SliderMinimalPerf.default | 1723 | 1728 | 1:1 |
| BoxMinimalPerf.default | 356 | 359 | 0.99:1 |
| ChatWithPopoverPerf.default | 383 | 388 | 0.99:1 |
| DatepickerMinimalPerf.default | 5474 | 5537 | 0.99:1 |
| DropdownMinimalPerf.default | 3170 | 3205 | 0.99:1 |
| ListCommonPerf.default | 634 | 643 | 0.99:1 |
| ListWith60ListItems.default | 640 | 649 | 0.99:1 |
| LoaderMinimalPerf.default | 708 | 718 | 0.99:1 |
| MenuButtonMinimalPerf.default | 1669 | 1686 | 0.99:1 |
| ProviderMergeThemesPerf.default | 1741 | 1754 | 0.99:1 |
| TextAreaMinimalPerf.default | 486 | 491 | 0.99:1 |
| DialogMinimalPerf.default | 764 | 781 | 0.98:1 |
| LabelMinimalPerf.default | 384 | 391 | 0.98:1 |
| IconMinimalPerf.default | 632 | 646 | 0.98:1 |
| TooltipMinimalPerf.default | 1032 | 1054 | 0.98:1 |
| TextMinimalPerf.default | 332 | 341 | 0.97:1 |
| AlertMinimalPerf.default | 269 | 279 | 0.96:1 |
| GridMinimalPerf.default | 321 | 340 | 0.94:1 |
|
Need to unblock a publish to release a stable version - as the package files only affected and changed our package, I'm going to merge this. |
chrisdholt
deleted the
users/chhol/update-foundation-package-and-ensure-react-docs-updated
branch
mlp73
pushed a commit
to mlp73/fluentui
that referenced
this pull request
Jan 17, 2022
…ated (microsoft#20316) * update foundation package and react documentation * Change files
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request checklist
$ yarn changeDescription of changes
Includes a number of fixes from FAST foundation as well as updates to the react documentation
Focus areas to test
(optional)