New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(react-slider) - Adding the RangedSlider component #19843

Merged

czearing merged 89 commits into microsoft:master from czearing:react-ranged-slider

Sep 26, 2021

Collaborator

czearing commented Sep 17, 2021 •

edited

Loading

Pull request checklist

Addresses an existing issue: Slider Convergence #18886
Include a change request file using $ yarn change

Description of changes

Adding the RangedSlider component to the converged react-slider package.

Images

CodeSandbox Demo

https://codesandbox.io/s/multi-thumb-slider-ieyy7?file=/src/App.js

czearing added 30 commits

September 7, 2021 10:36


          Adding utils

e488768


          Separating mark logic

e67013f


          Cleaning up clamp and step logic

f690b1b


          Merge branch 'master' of https://github.com/microsoft/fluentui into f…

6e0c430

…eat/react-slider-utils


          Building the API

5e23645


          Merge branch 'master' of https://github.com/microsoft/fluentui into f…

72f0118

…eat/react-slider-utils


          Change files

bf99ac9


          PR feedback

378bfc2


          Cleaning up API and switching change to prerelease

f3d0d2f


          Adding files

77d6eec


          Minor change to trigger dif

88883d0


          Reverting minor change

7d6c1b0


          Adding styles

eab7838


          Updating styles


          Adding range utils

e50078c


          Adding thumb styles

88eb57c


          Adding keyboard support

a645e94


          Adding marks support

556d245


          Adding bundle size tool and adding pointer support

0b80533


          Adding track styles

b3c517c


          Cleaning up code

17d5993


          Separating the internal value and rendered value

6c16933


          Fixing a bug

6eee595


          Adding vertical support

ae5d341


          Adding snapshot tests

cc56f10


          Adding vr tests

a74d1bb


          Adding lowerValue and upperValue clamping

fc39804


          Adding keyboard support

beea6e2


          Quick fix to styles

9a0ffa8


          Adding internal locked value during movement

60e52b1


          PR feedback part 6

281e870

khmakoto approved these changes

View reviewed changes

Member

khmakoto left a comment

Approved with 2 comments. Thanks!

packages/react-slider/src/components/RangedSlider/RangedSlider.test.tsx Outdated Show resolved Hide resolved

packages/react-slider/src/components/Slider/Slider.test.tsx Outdated Show resolved Hide resolved

czearing added 5 commits

September 24, 2021 17:46


          PR feedback

ca72da2


          Updating focus border className selector

2c7b30b


          Updating ClassName

d09f46e


          Updating classname

524b1fa


          Updating selectors

c0909ee

dzearing closed this

dzearing reopened this

czearing added 5 commits

September 24, 2021 19:41


          Adding a note about the classNames

cdf21df


          Updating RangedSlider vr tests

4e98606


          Minor change in Suggestions VR test to enable hover

95c994f


          Removing a sporadic test

c68c3b8


          Removing RangedSliderConverged stories and reverting Sugestions stori…

0939f4a

…es change.

czearing merged commit 16bc6ec into microsoft:master

Collaborator

msft-fluent-ui-bot commented Sep 27, 2021

🎉@fluentui/[email protected] has been released which incorporates this pull request.:tada:

Handy links:

Collaborator

msft-fluent-ui-bot commented Sep 27, 2021

🎉@fluentui/[email protected] has been released which incorporates this pull request.:tada:

Handy links:

Collaborator

msft-fluent-ui-bot commented Sep 27, 2021

🎉@fluentui/[email protected] has been released which incorporates this pull request.:tada:

Handy links:

Collaborator

msft-fluent-ui-bot commented Sep 27, 2021

🎉@fluentui/[email protected] has been released which incorporates this pull request.:tada:

Handy links:

Collaborator

msft-fluent-ui-bot commented Sep 27, 2021

🎉@fluentui/[email protected] has been released which incorporates this pull request.:tada:

Handy links:

Collaborator

msft-fluent-ui-bot commented Sep 27, 2021

🎉@fluentui/[email protected] has been released which incorporates this pull request.:tada:

Handy links:

Collaborator

msft-fluent-ui-bot commented Sep 27, 2021

🎉@fluentui/[email protected] has been released which incorporates this pull request.:tada:

Handy links:

Collaborator

msft-fluent-ui-bot commented Sep 27, 2021

🎉@fluentui/[email protected] has been released which incorporates this pull request.:tada:

Handy links:

Collaborator

msft-fluent-ui-bot commented Sep 27, 2021

🎉@fluentui/[email protected] has been released which incorporates this pull request.:tada:

Handy links:

Collaborator

msft-fluent-ui-bot commented Sep 27, 2021

🎉@fluentui/[email protected] has been released which incorporates this pull request.:tada:

Handy links:

Collaborator

msft-fluent-ui-bot commented Sep 27, 2021

🎉@fluentui/[email protected] has been released which incorporates this pull request.:tada:

Handy links:

Collaborator

msft-fluent-ui-bot commented Sep 27, 2021

🎉@fluentui/[email protected] has been released which incorporates this pull request.:tada:

Handy links:

Collaborator

msft-fluent-ui-bot commented Sep 27, 2021

🎉@fluentui/[email protected] has been released which incorporates this pull request.:tada:

Handy links:

Collaborator

msft-fluent-ui-bot commented Sep 27, 2021

🎉@fluentui/[email protected] has been released which incorporates this pull request.:tada:

Handy links:

mlp73 pushed a commit to mlp73/fluentui that referenced this pull request


          (react-slider) - Adding the RangedSlider component (microsoft#19843)

3626ab2

* Adding utils

* Separating mark logic

* Cleaning up clamp and step logic

* Building the API

* Change files

* PR feedback

* Cleaning up API and switching change to prerelease

* Adding files

* Minor change to trigger dif

* Reverting minor change

* Adding styles

* Updating styles

* Adding range utils

* Adding thumb styles

* Adding keyboard support

* Adding marks support

* Adding bundle size tool and adding pointer support

* Adding track styles

* Cleaning up code

* Separating the internal value and rendered value

* Fixing a bug

* Adding vertical support

* Adding snapshot tests

* Adding vr tests

* Adding lowerValue and upperValue clamping

* Adding keyboard support

* Quick fix to styles

* Adding internal locked value during movement

* Cleaning up types

* Updating the API

* Adding internalState and cleaning up exports

* Adding tests

* Updating renderStructure

* Adding pointerDown tests

* Adding keyboard test

* Adding handles keydown events tests

* Adding a lot more tests

* Adding more tests

* Updating comment

* Initial changes

* Switching to tuple P1

* Cleaning up state

* Cleaning up state logic

* Updating tests and api

* Adding validation for Thumb value

* Adding more tests

* Moving utils and cleaning up vr tests

* Updating index.ts

* Updating the api

* Change files

* Updating vr tests

* Cleaning up tests

* Updating tests

* Updating test

* Adding custom mark and label support to the RangedSlider

* Updating snapshots from utils change.

* Removing deprecated tag.

* PR feedback part 1

* PR feedback part 2

* Alphabetizing state files

* Renaming inputLower and inputUpper to lowerInput and upperInput

* PR feedback part 3

* PR feedback part 4

* PR feedback part 5

* Updating tests

* Moving role test under Accessibility Tests

* Updating tests

* PR feedback part 6

* PR feedback

* Updating focus border className selector

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Component: Slider