Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(eslint-plugin): Move all usages to devdeps #19832

Merged
merged 2 commits into from
Sep 16, 2021
Merged

chore(eslint-plugin): Move all usages to devdeps #19832

merged 2 commits into from
Sep 16, 2021

Conversation

ling1726
Copy link
Member

@ling1726 ling1726 commented Sep 16, 2021 •
edited
Loading

Pull request checklist

Description of changes

Moves the eslint-plugin package to devDeps for all packages to avoid
having to maintain an extra version group for v9 in #19799

Focus areas to test

(optional)

@ling1726
chore(eslint-plugin): Move all usages to devdeps
6fbd0b1 
Moves the eslint-plugin package to devDeps for all packages to avoid
having to maintain an extra version group for v9 in microsoft#19799
@ling1726 ling1726 requested a review from a team as a code owner September 16, 2021 19:40
@fabricteam
Copy link
Collaborator

fabricteam commented Sep 16, 2021 •
edited
Loading

📊 Bundle size report

Unchanged fixtures
Package & Exports Size (minified/GZIP)
react-accordion
Accordion (including children components)		 55.248 kB
17.403 kB
react-avatar
Avatar		 56.558 kB
15.66 kB
react-badge
Badge		 24.343 kB
7.165 kB
react-badge
CounterBadge		 27.156 kB
7.851 kB
react-badge
PresenseBadge		 237 B
177 B
react-button
Button		 22.932 kB
6.984 kB
react-button
CompoundButton		 28.215 kB
7.834 kB
react-button
MenuButton		 24.733 kB
7.546 kB
react-button
ToggleButton		 32.527 kB
7.601 kB
react-components
react-components: Accordion, Button, FluentProvider, Image, Menu, Popover		 163.935 kB
46.761 kB
react-components
react-components: FluentProvider & webLightTheme		 35.75 kB
11.392 kB
react-divider
Divider		 15.889 kB
5.747 kB
react-image
Image		 9.882 kB
3.975 kB
react-input
Input		 31.636 kB
11.312 kB
react-label
Label		 9.397 kB
3.839 kB
react-link
Link		 13.718 kB
5.66 kB
react-make-styles
makeStaticStyles (runtime)		 7.59 kB
3.321 kB
react-make-styles
makeStyles + mergeClasses (runtime)		 22.135 kB
8.356 kB
react-make-styles
makeStyles + mergeClasses (build time)		 2.557 kB
1.202 kB
react-menu
Menu (including children components)		 102.963 kB
31.313 kB
react-menu
Menu (including selectable components)		 105.239 kB
31.665 kB
react-popover
Popover		 100.411 kB
30.075 kB
react-portal
Portal		 6.725 kB
2.237 kB
react-positioning
usePopper		 23.145 kB
7.942 kB
react-provider
FluentProvider		 15.748 kB
5.773 kB
react-slider
Slider		 30.697 kB
9.75 kB
react-switch
Switch		 18.067 kB
6.181 kB
react-text
Text - Default		 11.798 kB
4.452 kB
react-text
Text - Wrappers		 15.414 kB
4.734 kB
react-theme
Teams: all themes		 32.941 kB
6.674 kB
react-theme
Teams: Light theme		 20.247 kB
5.662 kB
react-tooltip
Tooltip		 46.029 kB
15.655 kB
react-utilities
SSRProvider		 213 B
170 B
🤖 This report was generated against acce502f2396742f77099ad2bfa16247dc06f587

ecraig12345
ecraig12345 approved these changes Sep 16, 2021
View reviewed changes
Copy link
Member

@ecraig12345 ecraig12345 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should work, though since those packages are all dev-only you could also just change dependencies to devDependencies all-up. Either way is fine with me.

@size-auditor
Copy link

size-auditor bot commented Sep 16, 2021 •
edited
Loading

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: acce502f2396742f77099ad2bfa16247dc06f587 (build)

@codesandbox-ci
Copy link

codesandbox-ci bot commented Sep 16, 2021 •
edited
Loading

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit edb4445:

Sandbox Source
Fluent UI React Starter Configuration

@ling1726
Copy link
Member Author

ling1726 commented Sep 16, 2021 •
edited
Loading

This should work, though since those packages are all dev-only you could also just change dependencies to devDependencies all-up. Either way is fine with me.

@ecraig12345 it doesn work 😭😭 since eslint will error on the dependencies that are actually used... such as @fluentui/react

@ling1726 ling1726 force-pushed the fix/reorganize-dev-dependencies branch from 8d3d5be to edb4445 Compare September 16, 2021 20:21
@fabricteam
Copy link
Collaborator

Perf Analysis (@fluentui/react)

No significant results to display.

All results

Scenario Render type Master Ticks PR Ticks Iterations Status
Avatar mount 886 863 5000
BaseButton mount 892 848 5000
Breadcrumb mount 2578 2580 1000
ButtonNext mount 441 445 5000
Checkbox mount 1486 1489 5000
CheckboxBase mount 1251 1244 5000
ChoiceGroup mount 4661 4661 5000
ComboBox mount 990 953 1000
CommandBar mount 10136 10100 1000
ContextualMenu mount 6415 6473 1000
DefaultButton mount 1095 1100 5000
DetailsRow mount 3732 3729 5000
DetailsRowFast mount 3655 3681 5000
DetailsRowNoStyles mount 3500 3405 5000
Dialog mount 2397 2475 1000
DocumentCardTitle mount 145 142 1000
Dropdown mount 3206 3187 5000
FluentProviderNext mount 7408 7314 5000
FluentProviderWithTheme mount 345 344 10
FluentProviderWithTheme virtual-rerender 89 97 10
FluentProviderWithTheme virtual-rerender-with-unmount 481 465 10
FocusTrapZone mount 1802 1756 5000
FocusZone mount 1789 1814 5000
IconButton mount 1731 1733 5000
Label mount 336 313 5000
Layer mount 2939 2892 5000
Link mount 471 459 5000
MakeStyles mount 1847 1795 50000
MenuButton mount 1427 1452 5000
MessageBar mount 1953 2072 5000
Nav mount 3217 3226 1000
OverflowSet mount 1081 1083 5000
Panel mount 2322 2356 1000
Persona mount 832 838 1000
Pivot mount 1384 1410 1000
PrimaryButton mount 1243 1265 5000
Rating mount 7546 7498 5000
SearchBox mount 1285 1294 5000
Shimmer mount 2492 2550 5000
Slider mount 1915 1907 5000
SpinButton mount 4868 4922 5000
Spinner mount 426 426 5000
SplitButton mount 3101 3084 5000
Stack mount 477 500 5000
StackWithIntrinsicChildren mount 1530 1522 5000
StackWithTextChildren mount 4450 4454 5000
SwatchColorPicker mount 10013 10098 5000
Tabs mount 1352 1393 1000
TagPicker mount 2472 2624 5000
TeachingBubble mount 13169 13298 5000
Text mount 414 419 5000
TextField mount 1340 1324 5000
ThemeProvider mount 1137 1174 5000
ThemeProvider virtual-rerender 611 585 5000
ThemeProvider virtual-rerender-with-unmount 1843 1843 5000
Toggle mount 797 776 5000
buttonNative mount 112 117 5000

Perf Analysis (@fluentui/react-northstar)

Perf tests with no regressions
Scenario Current PR Ticks Baseline Ticks Ratio
ButtonMinimalPerf.default 173 156 1.11:1
ChatWithPopoverPerf.default 379 348 1.09:1
RefMinimalPerf.default 236 221 1.07:1
ButtonSlotsPerf.default 557 526 1.06:1
CardMinimalPerf.default 545 514 1.06:1
SkeletonMinimalPerf.default 359 338 1.06:1
TextMinimalPerf.default 345 327 1.06:1
HeaderSlotsPerf.default 755 720 1.05:1
IconMinimalPerf.default 624 592 1.05:1
ButtonOverridesMissPerf.default 1714 1656 1.04:1
AnimationMinimalPerf.default 415 402 1.03:1
HeaderMinimalPerf.default 354 344 1.03:1
InputMinimalPerf.default 1268 1237 1.03:1
ListWith60ListItems.default 647 628 1.03:1
PortalMinimalPerf.default 185 179 1.03:1
TextAreaMinimalPerf.default 490 474 1.03:1
DividerMinimalPerf.default 353 347 1.02:1
ProviderMergeThemesPerf.default 1719 1678 1.02:1
CustomToolbarPrototype.default 3868 3775 1.02:1
AttachmentMinimalPerf.default 147 145 1.01:1
CarouselMinimalPerf.default 449 444 1.01:1
DropdownManyItemsPerf.default 679 670 1.01:1
DropdownMinimalPerf.default 3079 3044 1.01:1
FlexMinimalPerf.default 278 276 1.01:1
GridMinimalPerf.default 331 327 1.01:1
ImageMinimalPerf.default 373 370 1.01:1
LabelMinimalPerf.default 376 371 1.01:1
LayoutMinimalPerf.default 362 359 1.01:1
ListCommonPerf.default 615 608 1.01:1
MenuButtonMinimalPerf.default 1628 1616 1.01:1
ReactionMinimalPerf.default 365 360 1.01:1
StatusMinimalPerf.default 650 645 1.01:1
ToolbarMinimalPerf.default 946 938 1.01:1
BoxMinimalPerf.default 330 330 1:1
ChatMinimalPerf.default 621 624 1:1
CheckboxMinimalPerf.default 2675 2684 1:1
FormMinimalPerf.default 386 386 1:1
ListMinimalPerf.default 488 490 1:1
MenuMinimalPerf.default 819 819 1:1
ProviderMinimalPerf.default 998 995 1:1
SplitButtonMinimalPerf.default 4065 4073 1:1
TableManyItemsPerf.default 1852 1844 1:1
VideoMinimalPerf.default 618 620 1:1
EmbedMinimalPerf.default 4048 4081 0.99:1
ListNestedPerf.default 523 529 0.99:1
SegmentMinimalPerf.default 338 340 0.99:1
TooltipMinimalPerf.default 993 1000 0.99:1
TreeMinimalPerf.default 755 763 0.99:1
DialogMinimalPerf.default 733 750 0.98:1
LoaderMinimalPerf.default 686 700 0.98:1
PopupMinimalPerf.default 583 594 0.98:1
SliderMinimalPerf.default 1552 1578 0.98:1
TableMinimalPerf.default 398 405 0.98:1
AttachmentSlotsPerf.default 1050 1088 0.97:1
AvatarMinimalPerf.default 180 186 0.97:1
RosterPerf.default 1119 1154 0.97:1
TreeWith60ListItems.default 159 164 0.97:1
AccordionMinimalPerf.default 144 150 0.96:1
DatepickerMinimalPerf.default 5101 5311 0.96:1
ItemLayoutMinimalPerf.default 1154 1214 0.95:1
AlertMinimalPerf.default 262 279 0.94:1
RadioGroupMinimalPerf.default 416 443 0.94:1
ChatDuplicateMessagesPerf.default 271 292 0.93:1

@ling1726 ling1726 merged commit 4225f71 into microsoft:master Sep 16, 2021
mlp73 pushed a commit to mlp73/fluentui that referenced this pull request Jan 17, 2022
@ling1726
chore(eslint-plugin): Move all usages to devdeps (microsoft#19832)
112850e 
* chore(eslint-plugin): Move all usages to devdeps

Moves the eslint-plugin package to devDeps for all packages to avoid
having to maintain an extra version group for v9 in microsoft#19799

* use carets
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ecraig12345 ecraig12345 ecraig12345 approved these changes

Assignees

@GeoffCoxMSFT GeoffCoxMSFT

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ling1726 @fabricteam @ecraig12345 @GeoffCoxMSFT