Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(react-slider) - Adding accessibility tests #19790

Merged

Conversation

czearing
Copy link
Collaborator

Pull request checklist

Description of changes

Adding accessibility tests to the converged Slider component.

@fabricteam
Copy link
Collaborator

📊 Bundle size report

Unchanged fixtures
Package & Exports Size (minified/GZIP)
react-slider
Slider
30.621 kB
9.711 kB
🤖 This report was generated against 10495c31fb5c5cf48b4665601a75a0cfabb6a03c

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 979dff0:

Sandbox Source
Fluent UI React Starter Configuration

@size-auditor
Copy link

size-auditor bot commented Sep 14, 2021

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: 10495c31fb5c5cf48b4665601a75a0cfabb6a03c (build)

@fabricteam
Copy link
Collaborator

Perf Analysis (@fluentui/react)

Scenario Render type Master Ticks PR Ticks Iterations Status
buttonNative mount 107 119 5000 Possible regression
All results

Scenario Render type Master Ticks PR Ticks Iterations Status
Avatar mount 864 878 5000
BaseButton mount 894 867 5000
Breadcrumb mount 2637 2606 1000
ButtonNext mount 425 425 5000
Checkbox mount 1469 1553 5000
CheckboxBase mount 1242 1248 5000
ChoiceGroup mount 4685 4574 5000
ComboBox mount 982 966 1000
CommandBar mount 10149 10152 1000
ContextualMenu mount 6578 6542 1000
DefaultButton mount 1112 1164 5000
DetailsRow mount 3627 3734 5000
DetailsRowFast mount 3673 3660 5000
DetailsRowNoStyles mount 3536 3506 5000
Dialog mount 2416 2411 1000
DocumentCardTitle mount 142 136 1000
Dropdown mount 3184 3190 5000
FluentProviderNext mount 7419 7429 5000
FluentProviderWithTheme mount 348 334 10
FluentProviderWithTheme virtual-rerender 77 94 10
FluentProviderWithTheme virtual-rerender-with-unmount 474 469 10
FocusTrapZone mount 1772 1835 5000
FocusZone mount 1775 1751 5000
IconButton mount 1747 1725 5000
Label mount 333 334 5000
Layer mount 3012 2993 5000
Link mount 482 463 5000
MakeStyles mount 1847 1851 50000
MenuButton mount 1455 1469 5000
MessageBar mount 1995 2055 5000
Nav mount 3219 3186 1000
OverflowSet mount 1117 1083 5000
Panel mount 2331 2347 1000
Persona mount 822 831 1000
Pivot mount 1384 1383 1000
PrimaryButton mount 1261 1254 5000
Rating mount 7625 7640 5000
SearchBox mount 1297 1331 5000
Shimmer mount 2535 2472 5000
Slider mount 1939 1907 5000
SpinButton mount 4900 4944 5000
Spinner mount 403 411 5000
SplitButton mount 3088 3081 5000
Stack mount 489 490 5000
StackWithIntrinsicChildren mount 1518 1557 5000
StackWithTextChildren mount 4510 4523 5000
SwatchColorPicker mount 10109 10142 5000
Tabs mount 1399 1413 1000
TagPicker mount 2559 2536 5000
TeachingBubble mount 13049 13102 5000
Text mount 403 413 5000
TextField mount 1361 1356 5000
ThemeProvider mount 1180 1179 5000
ThemeProvider virtual-rerender 618 609 5000
ThemeProvider virtual-rerender-with-unmount 1880 1866 5000
Toggle mount 794 807 5000
buttonNative mount 107 119 5000 Possible regression

Perf Analysis (@fluentui/react-northstar)

Perf tests with no regressions
Scenario Current PR Ticks Baseline Ticks Ratio
TreeWith60ListItems.default 185 169 1.09:1
AccordionMinimalPerf.default 156 145 1.08:1
RefMinimalPerf.default 256 240 1.07:1
DividerMinimalPerf.default 369 349 1.06:1
TextMinimalPerf.default 346 327 1.06:1
DialogMinimalPerf.default 778 741 1.05:1
CarouselMinimalPerf.default 465 448 1.04:1
ChatDuplicateMessagesPerf.default 302 290 1.04:1
HeaderSlotsPerf.default 760 732 1.04:1
MenuMinimalPerf.default 852 822 1.04:1
SkeletonMinimalPerf.default 358 345 1.04:1
TooltipMinimalPerf.default 1024 986 1.04:1
AnimationMinimalPerf.default 413 401 1.03:1
FlexMinimalPerf.default 278 269 1.03:1
FormMinimalPerf.default 403 392 1.03:1
GridMinimalPerf.default 331 321 1.03:1
ListNestedPerf.default 546 532 1.03:1
PortalMinimalPerf.default 182 176 1.03:1
SegmentMinimalPerf.default 343 334 1.03:1
BoxMinimalPerf.default 347 339 1.02:1
ButtonSlotsPerf.default 555 544 1.02:1
ImageMinimalPerf.default 370 362 1.02:1
LabelMinimalPerf.default 380 372 1.02:1
LayoutMinimalPerf.default 361 354 1.02:1
PopupMinimalPerf.default 591 577 1.02:1
TableManyItemsPerf.default 1872 1844 1.02:1
AttachmentSlotsPerf.default 1065 1053 1.01:1
ButtonMinimalPerf.default 175 174 1.01:1
CheckboxMinimalPerf.default 2714 2697 1.01:1
DropdownManyItemsPerf.default 675 671 1.01:1
EmbedMinimalPerf.default 4108 4079 1.01:1
ListCommonPerf.default 613 607 1.01:1
MenuButtonMinimalPerf.default 1615 1604 1.01:1
RadioGroupMinimalPerf.default 442 437 1.01:1
IconMinimalPerf.default 595 592 1.01:1
TextAreaMinimalPerf.default 490 487 1.01:1
AvatarMinimalPerf.default 190 190 1:1
ChatMinimalPerf.default 644 644 1:1
HeaderMinimalPerf.default 357 358 1:1
ItemLayoutMinimalPerf.default 1212 1217 1:1
ListWith60ListItems.default 644 643 1:1
ReactionMinimalPerf.default 369 370 1:1
SliderMinimalPerf.default 1556 1549 1:1
SplitButtonMinimalPerf.default 4062 4067 1:1
CustomToolbarPrototype.default 3859 3857 1:1
DatepickerMinimalPerf.default 5332 5364 0.99:1
DropdownMinimalPerf.default 3075 3112 0.99:1
InputMinimalPerf.default 1249 1266 0.99:1
ProviderMergeThemesPerf.default 1679 1701 0.99:1
StatusMinimalPerf.default 658 666 0.99:1
TableMinimalPerf.default 393 395 0.99:1
ToolbarMinimalPerf.default 909 921 0.99:1
TreeMinimalPerf.default 788 793 0.99:1
AlertMinimalPerf.default 263 268 0.98:1
ButtonOverridesMissPerf.default 1681 1713 0.98:1
ChatWithPopoverPerf.default 356 364 0.98:1
AttachmentMinimalPerf.default 145 150 0.97:1
ListMinimalPerf.default 487 503 0.97:1
LoaderMinimalPerf.default 668 687 0.97:1
ProviderMinimalPerf.default 995 1035 0.96:1
CardMinimalPerf.default 527 552 0.95:1
RosterPerf.default 1110 1169 0.95:1
VideoMinimalPerf.default 573 624 0.92:1

@czearing czearing merged commit 1b37275 into microsoft:master Sep 23, 2021
mlp73 pushed a commit to mlp73/fluentui that referenced this pull request Jan 17, 2022
* Adding accessibility tests to the Slider.

* Moving ariaValueText test

* Change files
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants