Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(react-slider) - Adding examples to the README.md #19696

Merged
merged 1 commit into from
Sep 8, 2021

Conversation

czearing
Copy link
Collaborator

@czearing czearing commented Sep 8, 2021

Pull request checklist

Description of changes

Adding an examples section to the converged Slider component's README.md file to cover basic usage.

@fabricteam
Copy link
Collaborator

📊 Bundle size report

Unchanged fixtures
Package & Exports Size (minified/GZIP)
react-slider
Slider
30.481 kB
9.681 kB
🤖 This report was generated against 42b2ba8f917151802749a7994bb0b4c3f93ed864

@codesandbox-ci
Copy link

codesandbox-ci bot commented Sep 8, 2021

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 87bd4c0:

Sandbox Source
Fluent UI React Starter Configuration

@size-auditor
Copy link

size-auditor bot commented Sep 8, 2021

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: 42b2ba8f917151802749a7994bb0b4c3f93ed864 (build)

@fabricteam
Copy link
Collaborator

Perf Analysis (@fluentui/react)

No significant results to display.

All results

Scenario Render type Master Ticks PR Ticks Iterations Status
Avatar mount 933 940 5000
BaseButton mount 977 1025 5000
Breadcrumb mount 2869 2840 1000
ButtonNext mount 475 484 5000
Checkbox mount 1653 1689 5000
CheckboxBase mount 1432 1411 5000
ChoiceGroup mount 5243 5093 5000
ComboBox mount 1044 1090 1000
CommandBar mount 10810 10864 1000
ContextualMenu mount 6910 6926 1000
DefaultButton mount 1239 1224 5000
DetailsRow mount 4037 3959 5000
DetailsRowFast mount 3895 4041 5000
DetailsRowNoStyles mount 3863 4034 5000
Dialog mount 2630 2508 1000
DocumentCardTitle mount 159 145 1000
Dropdown mount 3526 3510 5000
FluentProviderNext mount 7340 7070 5000
FluentProviderWithTheme mount 382 320 10
FluentProviderWithTheme virtual-rerender 104 105 10
FluentProviderWithTheme virtual-rerender-with-unmount 497 489 10
FocusTrapZone mount 1840 1864 5000
FocusZone mount 1891 1871 5000
IconButton mount 2002 1956 5000
Label mount 348 356 5000
Layer mount 3372 3299 5000
Link mount 498 531 5000
MakeStyles mount 1845 1832 50000
MenuButton mount 1606 1607 5000
MessageBar mount 2047 2156 5000
Nav mount 3465 3407 1000
OverflowSet mount 1137 1135 5000
Panel mount 2438 2430 1000
Persona mount 911 905 1000
Pivot mount 1499 1499 1000
PrimaryButton mount 1438 1401 5000
Rating mount 8495 8410 5000
SearchBox mount 1475 1456 5000
Shimmer mount 2863 2821 5000
Slider mount 2128 2057 5000
SpinButton mount 5349 5406 5000
Spinner mount 441 440 5000
SplitButton mount 3537 3449 5000
Stack mount 584 540 5000
StackWithIntrinsicChildren mount 1703 1742 5000
StackWithTextChildren mount 5085 4969 5000
SwatchColorPicker mount 10832 11225 5000
Tabs mount 1516 1478 1000
TagPicker mount 2727 2776 5000
TeachingBubble mount 13966 13587 5000
Text mount 441 445 5000
TextField mount 1453 1481 5000
ThemeProvider mount 1205 1195 5000
ThemeProvider virtual-rerender 657 631 5000
ThemeProvider virtual-rerender-with-unmount 1986 2010 5000
Toggle mount 858 841 5000
buttonNative mount 118 117 5000

Perf Analysis (@fluentui/react-northstar)

Perf tests with no regressions
Scenario Current PR Ticks Baseline Ticks Ratio
ImageMinimalPerf.default 484 424 1.14:1
ChatDuplicateMessagesPerf.default 336 306 1.1:1
ListNestedPerf.default 632 572 1.1:1
PortalMinimalPerf.default 186 171 1.09:1
TableMinimalPerf.default 492 455 1.08:1
ButtonSlotsPerf.default 609 567 1.07:1
ItemLayoutMinimalPerf.default 1442 1344 1.07:1
RefMinimalPerf.default 250 233 1.07:1
AvatarMinimalPerf.default 225 214 1.05:1
CarouselMinimalPerf.default 514 489 1.05:1
LabelMinimalPerf.default 448 425 1.05:1
PopupMinimalPerf.default 630 598 1.05:1
ReactionMinimalPerf.default 445 422 1.05:1
ButtonMinimalPerf.default 196 189 1.04:1
ChatMinimalPerf.default 731 701 1.04:1
DividerMinimalPerf.default 412 396 1.04:1
RadioGroupMinimalPerf.default 497 480 1.04:1
SliderMinimalPerf.default 1758 1695 1.04:1
IconMinimalPerf.default 699 670 1.04:1
AnimationMinimalPerf.default 452 437 1.03:1
AttachmentSlotsPerf.default 1159 1128 1.03:1
BoxMinimalPerf.default 386 373 1.03:1
LayoutMinimalPerf.default 421 410 1.03:1
ListMinimalPerf.default 583 566 1.03:1
CustomToolbarPrototype.default 4144 4020 1.03:1
DatepickerMinimalPerf.default 6235 6131 1.02:1
DialogMinimalPerf.default 848 831 1.02:1
DropdownMinimalPerf.default 3262 3204 1.02:1
GridMinimalPerf.default 367 361 1.02:1
MenuMinimalPerf.default 950 929 1.02:1
MenuButtonMinimalPerf.default 1793 1765 1.02:1
RosterPerf.default 1330 1310 1.02:1
SkeletonMinimalPerf.default 394 386 1.02:1
ToolbarMinimalPerf.default 1047 1028 1.02:1
AccordionMinimalPerf.default 168 166 1.01:1
CardMinimalPerf.default 615 609 1.01:1
DropdownManyItemsPerf.default 770 760 1.01:1
FlexMinimalPerf.default 301 298 1.01:1
ListWith60ListItems.default 718 713 1.01:1
ProviderMinimalPerf.default 1090 1079 1.01:1
TooltipMinimalPerf.default 1120 1109 1.01:1
AttachmentMinimalPerf.default 175 175 1:1
ChatWithPopoverPerf.default 381 382 1:1
HeaderMinimalPerf.default 391 391 1:1
LoaderMinimalPerf.default 728 731 1:1
ProviderMergeThemesPerf.default 1701 1701 1:1
SegmentMinimalPerf.default 376 376 1:1
ButtonOverridesMissPerf.default 1798 1814 0.99:1
EmbedMinimalPerf.default 4334 4392 0.99:1
FormMinimalPerf.default 457 461 0.99:1
HeaderSlotsPerf.default 828 835 0.99:1
SplitButtonMinimalPerf.default 4605 4647 0.99:1
StatusMinimalPerf.default 750 761 0.99:1
TableManyItemsPerf.default 2096 2124 0.99:1
TextAreaMinimalPerf.default 559 566 0.99:1
TreeMinimalPerf.default 877 883 0.99:1
AlertMinimalPerf.default 304 310 0.98:1
ListCommonPerf.default 671 683 0.98:1
TextMinimalPerf.default 421 429 0.98:1
VideoMinimalPerf.default 676 691 0.98:1
CheckboxMinimalPerf.default 2924 3025 0.97:1
InputMinimalPerf.default 1382 1434 0.96:1
TreeWith60ListItems.default 188 210 0.9:1

@czearing czearing merged commit 06061c5 into microsoft:master Sep 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Slider Convergence
4 participants