-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ensure card has good default foreground text #19439
ensure card has good default foreground text #19439
Conversation
📊 Bundle size report🤖 This report was generated against efcc1419197ddee42260c0503a571d693098fa54 |
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 94b2073:
|
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: efcc1419197ddee42260c0503a571d693098fa54 (build) |
Perf Analysis (
|
Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
---|---|---|---|---|---|
Avatar | mount | 1008 | 1013 | 5000 | |
BaseButton | mount | 985 | 996 | 5000 | |
Breadcrumb | mount | 2739 | 2716 | 1000 | |
ButtonNext | mount | 484 | 488 | 5000 | |
Checkbox | mount | 1737 | 1766 | 5000 | |
CheckboxBase | mount | 1523 | 1441 | 5000 | |
ChoiceGroup | mount | 5209 | 5465 | 5000 | |
ComboBox | mount | 1050 | 1062 | 1000 | |
CommandBar | mount | 10807 | 10585 | 1000 | |
ContextualMenu | mount | 6475 | 6585 | 1000 | |
DefaultButton | mount | 1217 | 1223 | 5000 | |
DetailsRow | mount | 3865 | 3976 | 5000 | |
DetailsRowFast | mount | 4058 | 3987 | 5000 | |
DetailsRowNoStyles | mount | 3851 | 3804 | 5000 | |
Dialog | mount | 2275 | 2247 | 1000 | |
DocumentCardTitle | mount | 154 | 154 | 1000 | |
Dropdown | mount | 3625 | 3611 | 5000 | |
FluentProviderNext | mount | 7228 | 7553 | 5000 | |
FocusTrapZone | mount | 2054 | 1958 | 5000 | |
FocusZone | mount | 2158 | 2050 | 5000 | |
IconButton | mount | 2184 | 2187 | 5000 | |
Label | mount | 400 | 395 | 5000 | |
Layer | mount | 2049 | 2177 | 5000 | |
Link | mount | 537 | 534 | 5000 | |
MakeStyles | mount | 2055 | 2079 | 50000 | |
MenuButton | mount | 1737 | 1753 | 5000 | |
MessageBar | mount | 2192 | 2240 | 5000 | |
Nav | mount | 3628 | 3640 | 1000 | |
OverflowSet | mount | 1200 | 1228 | 5000 | |
Panel | mount | 2276 | 2235 | 1000 | |
Persona | mount | 935 | 961 | 1000 | |
Pivot | mount | 1642 | 1548 | 1000 | |
PrimaryButton | mount | 1397 | 1456 | 5000 | |
Rating | mount | 8930 | 8966 | 5000 | |
SearchBox | mount | 1656 | 1411 | 5000 | |
Shimmer | mount | 2881 | 2879 | 5000 | |
Slider | mount | 2266 | 2181 | 5000 | |
SpinButton | mount | 5536 | 5660 | 5000 | |
Spinner | mount | 441 | 471 | 5000 | |
SplitButton | mount | 3457 | 3632 | 5000 | |
Stack | mount | 535 | 547 | 5000 | |
StackWithIntrinsicChildren | mount | 1770 | 1742 | 5000 | |
StackWithTextChildren | mount | 5152 | 5158 | 5000 | |
SwatchColorPicker | mount | 11220 | 11487 | 5000 | |
Tabs | mount | 1497 | 1691 | 1000 | |
TagPicker | mount | 2893 | 2811 | 5000 | |
TeachingBubble | mount | 12709 | 12750 | 5000 | |
Text | mount | 488 | 509 | 5000 | |
TextField | mount | 1498 | 1544 | 5000 | |
ThemeProvider | mount | 1296 | 1287 | 5000 | |
ThemeProvider | virtual-rerender | 628 | 649 | 5000 | |
Toggle | mount | 908 | 876 | 5000 | |
buttonNative | mount | 116 | 117 | 5000 |
Perf Analysis (@fluentui/react-northstar
)
Perf tests with no regressions
Scenario | Current PR Ticks | Baseline Ticks | Ratio |
---|---|---|---|
ButtonMinimalPerf.default | 198 | 176 | 1.13:1 |
AttachmentMinimalPerf.default | 182 | 164 | 1.11:1 |
DropdownManyItemsPerf.default | 839 | 760 | 1.1:1 |
GridMinimalPerf.default | 396 | 361 | 1.1:1 |
AvatarMinimalPerf.default | 224 | 206 | 1.09:1 |
ChatDuplicateMessagesPerf.default | 328 | 304 | 1.08:1 |
PortalMinimalPerf.default | 194 | 179 | 1.08:1 |
RefMinimalPerf.default | 257 | 240 | 1.07:1 |
TextMinimalPerf.default | 412 | 390 | 1.06:1 |
ListWith60ListItems.default | 757 | 723 | 1.05:1 |
ReactionMinimalPerf.default | 426 | 404 | 1.05:1 |
ChatWithPopoverPerf.default | 394 | 380 | 1.04:1 |
HeaderMinimalPerf.default | 409 | 394 | 1.04:1 |
HeaderSlotsPerf.default | 902 | 866 | 1.04:1 |
SegmentMinimalPerf.default | 388 | 374 | 1.04:1 |
SkeletonMinimalPerf.default | 400 | 384 | 1.04:1 |
CheckboxMinimalPerf.default | 2912 | 2839 | 1.03:1 |
ListMinimalPerf.default | 583 | 567 | 1.03:1 |
LoaderMinimalPerf.default | 748 | 728 | 1.03:1 |
DropdownMinimalPerf.default | 3403 | 3329 | 1.02:1 |
ProviderMergeThemesPerf.default | 1744 | 1710 | 1.02:1 |
TableMinimalPerf.default | 472 | 464 | 1.02:1 |
ToolbarMinimalPerf.default | 1106 | 1082 | 1.02:1 |
AccordionMinimalPerf.default | 163 | 162 | 1.01:1 |
AlertMinimalPerf.default | 300 | 297 | 1.01:1 |
AttachmentSlotsPerf.default | 1181 | 1174 | 1.01:1 |
BoxMinimalPerf.default | 397 | 394 | 1.01:1 |
CardMinimalPerf.default | 623 | 616 | 1.01:1 |
ChatMinimalPerf.default | 728 | 719 | 1.01:1 |
InputMinimalPerf.default | 1406 | 1395 | 1.01:1 |
RadioGroupMinimalPerf.default | 495 | 490 | 1.01:1 |
IconMinimalPerf.default | 721 | 716 | 1.01:1 |
FlexMinimalPerf.default | 327 | 326 | 1:1 |
ImageMinimalPerf.default | 459 | 460 | 1:1 |
ListCommonPerf.default | 732 | 731 | 1:1 |
ListNestedPerf.default | 642 | 639 | 1:1 |
DialogMinimalPerf.default | 844 | 856 | 0.99:1 |
DividerMinimalPerf.default | 428 | 432 | 0.99:1 |
EmbedMinimalPerf.default | 4596 | 4651 | 0.99:1 |
ItemLayoutMinimalPerf.default | 1355 | 1369 | 0.99:1 |
MenuMinimalPerf.default | 942 | 950 | 0.99:1 |
MenuButtonMinimalPerf.default | 1808 | 1819 | 0.99:1 |
SplitButtonMinimalPerf.default | 4170 | 4203 | 0.99:1 |
TextAreaMinimalPerf.default | 585 | 593 | 0.99:1 |
TooltipMinimalPerf.default | 1144 | 1153 | 0.99:1 |
TreeMinimalPerf.default | 870 | 876 | 0.99:1 |
VideoMinimalPerf.default | 701 | 709 | 0.99:1 |
CarouselMinimalPerf.default | 496 | 508 | 0.98:1 |
LayoutMinimalPerf.default | 409 | 416 | 0.98:1 |
ProviderMinimalPerf.default | 1076 | 1096 | 0.98:1 |
StatusMinimalPerf.default | 792 | 807 | 0.98:1 |
TableManyItemsPerf.default | 2193 | 2236 | 0.98:1 |
CustomToolbarPrototype.default | 4238 | 4313 | 0.98:1 |
ButtonOverridesMissPerf.default | 1847 | 1901 | 0.97:1 |
ButtonSlotsPerf.default | 654 | 671 | 0.97:1 |
FormMinimalPerf.default | 452 | 464 | 0.97:1 |
PopupMinimalPerf.default | 619 | 635 | 0.97:1 |
SliderMinimalPerf.default | 1653 | 1706 | 0.97:1 |
DatepickerMinimalPerf.default | 5527 | 5730 | 0.96:1 |
LabelMinimalPerf.default | 427 | 447 | 0.96:1 |
RosterPerf.default | 1260 | 1332 | 0.95:1 |
AnimationMinimalPerf.default | 418 | 443 | 0.94:1 |
TreeWith60ListItems.default | 195 | 209 | 0.93:1 |
🎉 Handy links: |
Pull request checklist
$ yarn change
Description of changes
Ensures that we set the foreground color of text by default for card so it responds to the fill and its changes.
Focus areas to test
(optional)