-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(react-slider) - Removing null children #19437
(react-slider) - Removing null children #19437
Conversation
📊 Bundle size report🤖 This report was generated against 6e53bbfe97c9f065d2e2063fefec9b01689891c7 |
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: 6e53bbfe97c9f065d2e2063fefec9b01689891c7 (build) |
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 8539a77:
|
Perf Analysis (
|
Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
---|---|---|---|---|---|
Avatar | mount | 967 | 928 | 5000 | |
BaseButton | mount | 976 | 928 | 5000 | |
Breadcrumb | mount | 2603 | 2571 | 1000 | |
ButtonNext | mount | 455 | 449 | 5000 | |
Checkbox | mount | 1626 | 1632 | 5000 | |
CheckboxBase | mount | 1430 | 1428 | 5000 | |
ChoiceGroup | mount | 5035 | 5165 | 5000 | |
ComboBox | mount | 1029 | 1014 | 1000 | |
CommandBar | mount | 10501 | 10502 | 1000 | |
ContextualMenu | mount | 6409 | 6440 | 1000 | |
DefaultButton | mount | 1236 | 1233 | 5000 | |
DetailsRow | mount | 3929 | 3955 | 5000 | |
DetailsRowFast | mount | 3921 | 3929 | 5000 | |
DetailsRowNoStyles | mount | 3746 | 3802 | 5000 | |
Dialog | mount | 2225 | 2218 | 1000 | |
DocumentCardTitle | mount | 147 | 157 | 1000 | |
Dropdown | mount | 3348 | 3369 | 5000 | |
FluentProviderNext | mount | 7021 | 7058 | 5000 | |
FocusTrapZone | mount | 1825 | 1778 | 5000 | |
FocusZone | mount | 1759 | 1733 | 5000 | |
IconButton | mount | 1810 | 1808 | 5000 | |
Label | mount | 340 | 329 | 5000 | |
Layer | mount | 1769 | 1818 | 5000 | |
Link | mount | 461 | 466 | 5000 | |
MakeStyles | mount | 1767 | 1809 | 50000 | |
MenuButton | mount | 1531 | 1493 | 5000 | |
MessageBar | mount | 2156 | 2075 | 5000 | |
Nav | mount | 3458 | 3433 | 1000 | |
OverflowSet | mount | 1111 | 1195 | 5000 | |
Panel | mount | 2117 | 2132 | 1000 | |
Persona | mount | 896 | 873 | 1000 | |
Pivot | mount | 1416 | 1494 | 1000 | |
PrimaryButton | mount | 1393 | 1430 | 5000 | |
Rating | mount | 8074 | 8591 | 5000 | |
SearchBox | mount | 1395 | 1382 | 5000 | |
Shimmer | mount | 2638 | 2751 | 5000 | |
Slider | mount | 2042 | 1984 | 5000 | |
SpinButton | mount | 5077 | 5476 | 5000 | |
Spinner | mount | 418 | 420 | 5000 | |
SplitButton | mount | 3406 | 3302 | 5000 | |
Stack | mount | 554 | 530 | 5000 | |
StackWithIntrinsicChildren | mount | 1603 | 1641 | 5000 | |
StackWithTextChildren | mount | 4825 | 4786 | 5000 | |
SwatchColorPicker | mount | 10768 | 10388 | 5000 | |
Tabs | mount | 1386 | 1440 | 1000 | |
TagPicker | mount | 2636 | 2694 | 5000 | |
TeachingBubble | mount | 12019 | 12108 | 5000 | |
Text | mount | 454 | 451 | 5000 | |
TextField | mount | 1488 | 1493 | 5000 | |
ThemeProvider | mount | 1241 | 1213 | 5000 | |
ThemeProvider | virtual-rerender | 599 | 620 | 5000 | |
Toggle | mount | 876 | 898 | 5000 | |
buttonNative | mount | 123 | 117 | 5000 |
Perf Analysis (@fluentui/react-northstar
)
Perf tests with no regressions
Scenario | Current PR Ticks | Baseline Ticks | Ratio |
---|---|---|---|
ButtonMinimalPerf.default | 205 | 178 | 1.15:1 |
ChatWithPopoverPerf.default | 420 | 381 | 1.1:1 |
LayoutMinimalPerf.default | 412 | 373 | 1.1:1 |
ChatDuplicateMessagesPerf.default | 341 | 313 | 1.09:1 |
GridMinimalPerf.default | 393 | 363 | 1.08:1 |
CarouselMinimalPerf.default | 516 | 484 | 1.07:1 |
ImageMinimalPerf.default | 425 | 398 | 1.07:1 |
TextMinimalPerf.default | 377 | 352 | 1.07:1 |
FormMinimalPerf.default | 462 | 441 | 1.05:1 |
ListMinimalPerf.default | 555 | 527 | 1.05:1 |
AnimationMinimalPerf.default | 433 | 416 | 1.04:1 |
ChatMinimalPerf.default | 730 | 703 | 1.04:1 |
DropdownManyItemsPerf.default | 789 | 758 | 1.04:1 |
ListWith60ListItems.default | 708 | 679 | 1.04:1 |
TextAreaMinimalPerf.default | 550 | 529 | 1.04:1 |
AlertMinimalPerf.default | 283 | 275 | 1.03:1 |
BoxMinimalPerf.default | 383 | 373 | 1.03:1 |
CheckboxMinimalPerf.default | 2926 | 2841 | 1.03:1 |
SegmentMinimalPerf.default | 363 | 354 | 1.03:1 |
SkeletonMinimalPerf.default | 376 | 365 | 1.03:1 |
AttachmentMinimalPerf.default | 176 | 172 | 1.02:1 |
ButtonSlotsPerf.default | 578 | 565 | 1.02:1 |
DialogMinimalPerf.default | 806 | 793 | 1.02:1 |
InputMinimalPerf.default | 1347 | 1317 | 1.02:1 |
ListCommonPerf.default | 682 | 667 | 1.02:1 |
LoaderMinimalPerf.default | 733 | 718 | 1.02:1 |
PortalMinimalPerf.default | 177 | 174 | 1.02:1 |
ReactionMinimalPerf.default | 418 | 408 | 1.02:1 |
CustomToolbarPrototype.default | 3925 | 3860 | 1.02:1 |
TooltipMinimalPerf.default | 1066 | 1041 | 1.02:1 |
AttachmentSlotsPerf.default | 1163 | 1155 | 1.01:1 |
DividerMinimalPerf.default | 399 | 397 | 1.01:1 |
DropdownMinimalPerf.default | 3201 | 3183 | 1.01:1 |
EmbedMinimalPerf.default | 4362 | 4326 | 1.01:1 |
ItemLayoutMinimalPerf.default | 1360 | 1346 | 1.01:1 |
SliderMinimalPerf.default | 1607 | 1597 | 1.01:1 |
TableManyItemsPerf.default | 2046 | 2019 | 1.01:1 |
TableMinimalPerf.default | 429 | 423 | 1.01:1 |
ButtonOverridesMissPerf.default | 1820 | 1823 | 1:1 |
CardMinimalPerf.default | 610 | 610 | 1:1 |
DatepickerMinimalPerf.default | 5672 | 5665 | 1:1 |
HeaderMinimalPerf.default | 399 | 400 | 1:1 |
HeaderSlotsPerf.default | 821 | 820 | 1:1 |
ListNestedPerf.default | 596 | 594 | 1:1 |
MenuButtonMinimalPerf.default | 1764 | 1766 | 1:1 |
RefMinimalPerf.default | 225 | 226 | 1:1 |
SplitButtonMinimalPerf.default | 3969 | 3966 | 1:1 |
StatusMinimalPerf.default | 700 | 703 | 1:1 |
TreeMinimalPerf.default | 819 | 821 | 1:1 |
FlexMinimalPerf.default | 300 | 302 | 0.99:1 |
ToolbarMinimalPerf.default | 988 | 1001 | 0.99:1 |
TreeWith60ListItems.default | 189 | 190 | 0.99:1 |
AccordionMinimalPerf.default | 163 | 166 | 0.98:1 |
LabelMinimalPerf.default | 414 | 421 | 0.98:1 |
MenuMinimalPerf.default | 894 | 913 | 0.98:1 |
ProviderMinimalPerf.default | 1049 | 1065 | 0.98:1 |
RadioGroupMinimalPerf.default | 483 | 494 | 0.98:1 |
AvatarMinimalPerf.default | 215 | 221 | 0.97:1 |
ProviderMergeThemesPerf.default | 1607 | 1660 | 0.97:1 |
VideoMinimalPerf.default | 655 | 678 | 0.97:1 |
IconMinimalPerf.default | 629 | 653 | 0.96:1 |
RosterPerf.default | 1264 | 1337 | 0.95:1 |
PopupMinimalPerf.default | 602 | 632 | 0.95:1 |
Pull request checklist
$ yarn change
Description of changes
With the Slot null rendering implementation, the Slider component no longer requires a null render for children.