Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(react-slider) - Adding disabled prop #19327

Merged
merged 5 commits into from
Aug 11, 2021

Conversation

czearing
Copy link
Collaborator

@czearing czearing commented Aug 9, 2021

Pull request checklist

Description of changes

Implementing the disabled prop to the Slider component:

image

@fabricteam
Copy link
Collaborator

fabricteam commented Aug 9, 2021

📊 Bundle size report

🤖 This report was generated against d65c09077575d1a42ae9beb9ddd8a7b94452e13b

@size-auditor
Copy link

size-auditor bot commented Aug 9, 2021

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: 383aef2a75dea06eb0c8c1d6a1ef97e3e7a5732d (build)

@codesandbox-ci
Copy link

codesandbox-ci bot commented Aug 9, 2021

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 6718992:

Sandbox Source
Fluent UI React Starter Configuration

@fabricteam
Copy link
Collaborator

fabricteam commented Aug 9, 2021

Perf Analysis (@fluentui/react)

No significant results to display.

All results

Scenario Render type Master Ticks PR Ticks Iterations Status
Avatar mount 893 900 5000
BaseButton mount 890 909 5000
Breadcrumb mount 2603 2624 1000
ButtonNext mount 427 438 5000
Checkbox mount 1509 1518 5000
CheckboxBase mount 1290 1276 5000
ChoiceGroup mount 4667 4756 5000
ComboBox mount 950 978 1000
CommandBar mount 10221 10236 1000
ContextualMenu mount 6175 6146 1000
DefaultButton mount 1138 1112 5000
DetailsRow mount 3763 3707 5000
DetailsRowFast mount 3740 3716 5000
DetailsRowNoStyles mount 3505 3463 5000
Dialog mount 2104 2154 1000
DocumentCardTitle mount 146 150 1000
Dropdown mount 3262 3217 5000
FluentProviderNext mount 7551 7626 5000
FocusTrapZone mount 1801 1770 5000
FocusZone mount 1794 1814 5000
IconButton mount 1783 1724 5000
Label mount 323 337 5000
Layer mount 1742 1778 5000
Link mount 464 471 5000
MakeStyles mount 1881 1832 50000
MenuButton mount 1445 1448 5000
MessageBar mount 2030 1996 5000
Nav mount 3273 3232 1000
OverflowSet mount 1046 1035 5000
Panel mount 2105 2050 1000
Persona mount 819 819 1000
Pivot mount 1388 1391 1000
PrimaryButton mount 1275 1289 5000
Rating mount 7665 7703 5000
SearchBox mount 1305 1307 5000
Shimmer mount 2546 2544 5000
Slider mount 1971 1927 5000
SpinButton mount 4951 5026 5000
Spinner mount 424 416 5000
SplitButton mount 3185 3129 5000
Stack mount 488 493 5000
StackWithIntrinsicChildren mount 1556 1535 5000
StackWithTextChildren mount 4505 4493 5000
SwatchColorPicker mount 10259 10185 5000
Tabs mount 1403 1438 1000
TagPicker mount 2629 2564 5000
TeachingBubble mount 11909 11870 5000
Text mount 417 411 5000
TextField mount 1368 1366 5000
ThemeProvider mount 1210 1184 5000
ThemeProvider virtual-rerender 603 607 5000
Toggle mount 812 810 5000
buttonNative mount 119 108 5000

Perf Analysis (@fluentui/react-northstar)

Perf tests with no regressions
Scenario Current PR Ticks Baseline Ticks Ratio
TreeWith60ListItems.default 191 172 1.11:1
AccordionMinimalPerf.default 158 146 1.08:1
ButtonMinimalPerf.default 171 160 1.07:1
ChatWithPopoverPerf.default 363 339 1.07:1
ListWith60ListItems.default 629 598 1.05:1
SegmentMinimalPerf.default 356 340 1.05:1
AttachmentMinimalPerf.default 156 150 1.04:1
LabelMinimalPerf.default 381 368 1.04:1
LayoutMinimalPerf.default 369 356 1.04:1
ListMinimalPerf.default 526 506 1.04:1
TooltipMinimalPerf.default 1031 991 1.04:1
AlertMinimalPerf.default 266 259 1.03:1
ChatDuplicateMessagesPerf.default 281 273 1.03:1
ListCommonPerf.default 621 605 1.03:1
BoxMinimalPerf.default 347 340 1.02:1
ButtonSlotsPerf.default 541 531 1.02:1
HeaderMinimalPerf.default 353 347 1.02:1
PortalMinimalPerf.default 179 175 1.02:1
ProviderMergeThemesPerf.default 1704 1665 1.02:1
StatusMinimalPerf.default 666 652 1.02:1
IconMinimalPerf.default 613 602 1.02:1
ToolbarMinimalPerf.default 935 918 1.02:1
TreeMinimalPerf.default 789 773 1.02:1
VideoMinimalPerf.default 633 622 1.02:1
ButtonOverridesMissPerf.default 1703 1692 1.01:1
CarouselMinimalPerf.default 467 462 1.01:1
ChatMinimalPerf.default 654 650 1.01:1
CheckboxMinimalPerf.default 2729 2706 1.01:1
DialogMinimalPerf.default 757 753 1.01:1
HeaderSlotsPerf.default 746 738 1.01:1
ItemLayoutMinimalPerf.default 1213 1206 1.01:1
MenuMinimalPerf.default 832 825 1.01:1
PopupMinimalPerf.default 611 604 1.01:1
SkeletonMinimalPerf.default 346 343 1.01:1
SplitButtonMinimalPerf.default 3734 3715 1.01:1
TextAreaMinimalPerf.default 483 480 1.01:1
AnimationMinimalPerf.default 398 399 1:1
CardMinimalPerf.default 541 539 1:1
DividerMinimalPerf.default 353 353 1:1
DropdownMinimalPerf.default 3084 3099 1:1
EmbedMinimalPerf.default 4090 4078 1:1
FlexMinimalPerf.default 280 280 1:1
GridMinimalPerf.default 327 326 1:1
InputMinimalPerf.default 1255 1257 1:1
ReactionMinimalPerf.default 370 370 1:1
TableManyItemsPerf.default 1845 1850 1:1
TableMinimalPerf.default 413 411 1:1
ImageMinimalPerf.default 360 362 0.99:1
MenuButtonMinimalPerf.default 1642 1657 0.99:1
ProviderMinimalPerf.default 991 1005 0.99:1
SliderMinimalPerf.default 1556 1570 0.99:1
TextMinimalPerf.default 340 344 0.99:1
CustomToolbarPrototype.default 3835 3856 0.99:1
DropdownManyItemsPerf.default 689 706 0.98:1
ListNestedPerf.default 531 543 0.98:1
LoaderMinimalPerf.default 685 701 0.98:1
AttachmentSlotsPerf.default 1041 1068 0.97:1
DatepickerMinimalPerf.default 5289 5451 0.97:1
FormMinimalPerf.default 385 395 0.97:1
RadioGroupMinimalPerf.default 428 443 0.97:1
RefMinimalPerf.default 233 242 0.96:1
AvatarMinimalPerf.default 181 190 0.95:1
RosterPerf.default 1112 1169 0.95:1

…eat/slider-disabled

# Conflicts:
#	packages/react-slider/src/components/Slider/Slider.test.tsx
#	packages/react-slider/src/components/Slider/Slider.types.ts
#	packages/react-slider/src/components/Slider/useSliderStyles.ts
…eat/slider-disabled

# Conflicts:
#	packages/react-slider/src/Slider.stories.tsx
@czearing czearing merged commit 0fdc490 into microsoft:master Aug 11, 2021
@behowell behowell mentioned this pull request Aug 16, 2021
40 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants