Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(react-slider) - Adding vertical prop #19326

Merged
merged 3 commits into from
Aug 11, 2021

Conversation

czearing
Copy link
Collaborator

@czearing czearing commented Aug 9, 2021

Pull request checklist

Description of changes

Implementing the vertical prop to the Slider component:
image

@fabricteam
Copy link
Collaborator

fabricteam commented Aug 9, 2021

📊 Bundle size report

🤖 This report was generated against 820878e46f810925f6bea0dad943869b8082dfb9

@codesandbox-ci
Copy link

codesandbox-ci bot commented Aug 9, 2021

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit bf08cc7:

Sandbox Source
Fluent UI React Starter Configuration

@size-auditor
Copy link

size-auditor bot commented Aug 9, 2021

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: 820878e46f810925f6bea0dad943869b8082dfb9 (build)

@fabricteam
Copy link
Collaborator

fabricteam commented Aug 9, 2021

Perf Analysis (@fluentui/react)

No significant results to display.

All results

Scenario Render type Master Ticks PR Ticks Iterations Status
Avatar mount 904 894 5000
BaseButton mount 883 877 5000
Breadcrumb mount 2578 2614 1000
ButtonNext mount 413 426 5000
Checkbox mount 1540 1526 5000
CheckboxBase mount 1269 1279 5000
ChoiceGroup mount 4778 4683 5000
ComboBox mount 966 965 1000
CommandBar mount 10074 10049 1000
ContextualMenu mount 6226 6119 1000
DefaultButton mount 1112 1125 5000
DetailsRow mount 3678 3708 5000
DetailsRowFast mount 3697 3681 5000
DetailsRowNoStyles mount 3497 3482 5000
Dialog mount 2121 2169 1000
DocumentCardTitle mount 137 147 1000
Dropdown mount 3259 3248 5000
FluentProviderNext mount 7432 7507 5000
FocusTrapZone mount 1785 1797 5000
FocusZone mount 1844 1830 5000
IconButton mount 1744 1750 5000
Label mount 335 335 5000
Layer mount 1828 1779 5000
Link mount 486 485 5000
MakeStyles mount 1869 1880 50000
MenuButton mount 1490 1452 5000
MessageBar mount 1993 2015 5000
Nav mount 3237 3204 1000
OverflowSet mount 1029 1047 5000
Panel mount 2074 2065 1000
Persona mount 848 828 1000
Pivot mount 1404 1424 1000
PrimaryButton mount 1285 1286 5000
Rating mount 7565 7631 5000
SearchBox mount 1305 1303 5000
Shimmer mount 2568 2513 5000
Slider mount 1974 1963 5000
SpinButton mount 4875 4941 5000
Spinner mount 417 442 5000
SplitButton mount 3162 3166 5000
Stack mount 497 492 5000
StackWithIntrinsicChildren mount 1566 1530 5000
StackWithTextChildren mount 4515 4539 5000
SwatchColorPicker mount 10107 10217 5000
Tabs mount 1400 1375 1000
TagPicker mount 2500 2552 5000
TeachingBubble mount 11936 11951 5000
Text mount 407 421 5000
TextField mount 1367 1367 5000
ThemeProvider mount 1181 1179 5000
ThemeProvider virtual-rerender 619 595 5000
Toggle mount 805 791 5000
buttonNative mount 111 115 5000

Perf Analysis (@fluentui/react-northstar)

Perf tests with no regressions
Scenario Current PR Ticks Baseline Ticks Ratio
AvatarMinimalPerf.default 203 188 1.08:1
LayoutMinimalPerf.default 367 351 1.05:1
ListNestedPerf.default 564 537 1.05:1
PortalMinimalPerf.default 179 171 1.05:1
TreeMinimalPerf.default 819 782 1.05:1
ButtonSlotsPerf.default 542 520 1.04:1
DividerMinimalPerf.default 359 344 1.04:1
DropdownManyItemsPerf.default 685 659 1.04:1
HeaderSlotsPerf.default 755 729 1.04:1
IconMinimalPerf.default 619 596 1.04:1
ButtonMinimalPerf.default 168 163 1.03:1
CardMinimalPerf.default 539 525 1.03:1
FlexMinimalPerf.default 281 272 1.03:1
HeaderMinimalPerf.default 356 345 1.03:1
ListMinimalPerf.default 505 489 1.03:1
LoaderMinimalPerf.default 697 676 1.03:1
TextMinimalPerf.default 341 331 1.03:1
ChatDuplicateMessagesPerf.default 296 289 1.02:1
ChatWithPopoverPerf.default 353 346 1.02:1
GridMinimalPerf.default 337 332 1.02:1
InputMinimalPerf.default 1267 1248 1.02:1
ListWith60ListItems.default 632 622 1.02:1
ReactionMinimalPerf.default 381 372 1.02:1
TableManyItemsPerf.default 1906 1871 1.02:1
TableMinimalPerf.default 396 387 1.02:1
TextAreaMinimalPerf.default 500 489 1.02:1
ToolbarMinimalPerf.default 925 911 1.02:1
AnimationMinimalPerf.default 401 397 1.01:1
ButtonOverridesMissPerf.default 1679 1662 1.01:1
ChatMinimalPerf.default 631 627 1.01:1
EmbedMinimalPerf.default 4136 4107 1.01:1
LabelMinimalPerf.default 376 374 1.01:1
ListCommonPerf.default 608 602 1.01:1
MenuMinimalPerf.default 845 834 1.01:1
RosterPerf.default 1176 1161 1.01:1
SkeletonMinimalPerf.default 345 341 1.01:1
CustomToolbarPrototype.default 3881 3852 1.01:1
TreeWith60ListItems.default 164 162 1.01:1
AttachmentMinimalPerf.default 157 157 1:1
AttachmentSlotsPerf.default 1056 1058 1:1
BoxMinimalPerf.default 346 346 1:1
DialogMinimalPerf.default 756 753 1:1
DropdownMinimalPerf.default 3129 3122 1:1
RefMinimalPerf.default 231 231 1:1
SliderMinimalPerf.default 1567 1571 1:1
SplitButtonMinimalPerf.default 3719 3702 1:1
CheckboxMinimalPerf.default 2665 2693 0.99:1
ImageMinimalPerf.default 353 357 0.99:1
ItemLayoutMinimalPerf.default 1196 1209 0.99:1
MenuButtonMinimalPerf.default 1616 1627 0.99:1
ProviderMergeThemesPerf.default 1669 1685 0.99:1
ProviderMinimalPerf.default 1006 1012 0.99:1
RadioGroupMinimalPerf.default 429 434 0.99:1
StatusMinimalPerf.default 667 674 0.99:1
TooltipMinimalPerf.default 991 1001 0.99:1
VideoMinimalPerf.default 614 620 0.99:1
FormMinimalPerf.default 389 398 0.98:1
PopupMinimalPerf.default 578 588 0.98:1
SegmentMinimalPerf.default 339 347 0.98:1
AccordionMinimalPerf.default 150 154 0.97:1
CarouselMinimalPerf.default 459 474 0.97:1
DatepickerMinimalPerf.default 5233 5427 0.96:1
AlertMinimalPerf.default 260 273 0.95:1

packages/react-slider/src/Slider.stories.tsx Outdated Show resolved Hide resolved
@czearing czearing merged commit a7a8e6f into microsoft:master Aug 11, 2021
@behowell behowell mentioned this pull request Aug 16, 2021
40 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants