Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[web-components] add tsconfig for component definitions #18985

Conversation

chrisdholt
Copy link
Member

Pull request checklist

  • Addresses an existing issue: Fixes #0000
  • Include a change request file using $ yarn change

Description of changes

Ensures the definitions created are exported :)

Focus areas to test

(optional)

@fabricteam
Copy link
Collaborator

📊 Bundle size report

🤖 This report was generated against a1f1516008a6490297b30f73dd9eaa188df8cf5d

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit b13e965:

Sandbox Source
Fluent UI React Starter Configuration

@size-auditor
Copy link

size-auditor bot commented Jul 16, 2021

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: ac8bc50ba9fe3296e61e69b9aff3f6a9d1112c50 (build)

@fabricteam
Copy link
Collaborator

Perf Analysis (@fluentui/react)

No significant results to display.

All results

Scenario Render type Master Ticks PR Ticks Iterations Status
Avatar mount 798 840 5000
BaseButton mount 897 901 5000
Breadcrumb mount 2631 2628 1000
ButtonNext mount 535 524 5000
Checkbox mount 1493 1494 5000
CheckboxBase mount 1299 1283 5000
ChoiceGroup mount 4693 4666 5000
ComboBox mount 1000 1027 1000
CommandBar mount 10157 10182 1000
ContextualMenu mount 6273 6151 1000
DefaultButton mount 1121 1130 5000
DetailsRow mount 3711 3702 5000
DetailsRowFast mount 3723 3722 5000
DetailsRowNoStyles mount 3486 3501 5000
Dialog mount 2172 2110 1000
DocumentCardTitle mount 133 141 1000
Dropdown mount 3192 3211 5000
FluentProviderNext mount 7308 7376 5000
FocusTrapZone mount 1794 1776 5000
FocusZone mount 1801 1837 5000
IconButton mount 1697 1702 5000
Label mount 332 343 5000
Layer mount 1815 1774 5000
Link mount 480 452 5000
MakeStyles mount 1796 1837 50000
MenuButton mount 1422 1450 5000
MessageBar mount 2007 2068 5000
Nav mount 3280 3231 1000
OverflowSet mount 1009 1019 5000
Panel mount 2050 2064 1000
Persona mount 842 818 1000
Pivot mount 1465 1405 1000
PrimaryButton mount 1262 1259 5000
Rating mount 7648 7506 5000
SearchBox mount 1321 1306 5000
Shimmer mount 2523 2534 5000
Slider mount 1963 1906 5000
SpinButton mount 4901 4955 5000
Spinner mount 427 398 5000
SplitButton mount 3096 3107 5000
Stack mount 524 497 5000
StackWithIntrinsicChildren mount 1539 1522 5000
StackWithTextChildren mount 4494 4485 5000
SwatchColorPicker mount 10163 10092 5000
Tabs mount 1436 1401 1000
TagPicker mount 2419 2421 5000
TeachingBubble mount 11921 11866 5000
Text mount 415 423 5000
TextField mount 1362 1366 5000
ThemeProvider mount 1188 1173 5000
ThemeProvider virtual-rerender 594 590 5000
Toggle mount 791 787 5000
buttonNative mount 121 124 5000

Perf Analysis (@fluentui/react-northstar)

Perf tests with no regressions
Scenario Current PR Ticks Baseline Ticks Ratio
PortalMinimalPerf.default 187 166 1.13:1
TreeWith60ListItems.default 171 157 1.09:1
GridMinimalPerf.default 343 320 1.07:1
AnimationMinimalPerf.default 423 399 1.06:1
DialogMinimalPerf.default 804 763 1.05:1
IconMinimalPerf.default 631 601 1.05:1
ButtonSlotsPerf.default 552 529 1.04:1
FormMinimalPerf.default 396 380 1.04:1
ListCommonPerf.default 660 634 1.04:1
MenuMinimalPerf.default 842 806 1.04:1
AttachmentMinimalPerf.default 154 150 1.03:1
AttachmentSlotsPerf.default 1102 1072 1.03:1
CardMinimalPerf.default 569 552 1.03:1
ChatDuplicateMessagesPerf.default 301 293 1.03:1
ProviderMergeThemesPerf.default 1705 1657 1.03:1
TreeMinimalPerf.default 802 781 1.03:1
ChatMinimalPerf.default 689 673 1.02:1
CheckboxMinimalPerf.default 2800 2753 1.02:1
HeaderMinimalPerf.default 359 353 1.02:1
LoaderMinimalPerf.default 697 686 1.02:1
PopupMinimalPerf.default 605 593 1.02:1
ProviderMinimalPerf.default 1002 984 1.02:1
RadioGroupMinimalPerf.default 459 451 1.02:1
TextMinimalPerf.default 343 336 1.02:1
ButtonOverridesMissPerf.default 1723 1701 1.01:1
DividerMinimalPerf.default 363 359 1.01:1
ReactionMinimalPerf.default 390 387 1.01:1
RefMinimalPerf.default 232 230 1.01:1
SplitButtonMinimalPerf.default 3866 3815 1.01:1
StatusMinimalPerf.default 694 684 1.01:1
ToolbarMinimalPerf.default 921 913 1.01:1
EmbedMinimalPerf.default 4177 4181 1:1
ImageMinimalPerf.default 371 372 1:1
LabelMinimalPerf.default 383 383 1:1
ListNestedPerf.default 563 562 1:1
MenuButtonMinimalPerf.default 1665 1669 1:1
TableMinimalPerf.default 393 393 1:1
AccordionMinimalPerf.default 152 153 0.99:1
ItemLayoutMinimalPerf.default 1214 1225 0.99:1
LayoutMinimalPerf.default 349 351 0.99:1
SegmentMinimalPerf.default 335 339 0.99:1
SliderMinimalPerf.default 1578 1593 0.99:1
TextAreaMinimalPerf.default 490 495 0.99:1
CustomToolbarPrototype.default 3828 3851 0.99:1
TooltipMinimalPerf.default 980 985 0.99:1
VideoMinimalPerf.default 619 628 0.99:1
ButtonMinimalPerf.default 176 179 0.98:1
ChatWithPopoverPerf.default 380 389 0.98:1
FlexMinimalPerf.default 273 280 0.98:1
HeaderSlotsPerf.default 733 751 0.98:1
InputMinimalPerf.default 1252 1283 0.98:1
ListMinimalPerf.default 516 527 0.98:1
TableManyItemsPerf.default 1868 1897 0.98:1
DatepickerMinimalPerf.default 5897 6066 0.97:1
DropdownManyItemsPerf.default 682 702 0.97:1
DropdownMinimalPerf.default 3107 3187 0.97:1
RosterPerf.default 1092 1124 0.97:1
CarouselMinimalPerf.default 472 492 0.96:1
SkeletonMinimalPerf.default 344 358 0.96:1
BoxMinimalPerf.default 349 370 0.94:1
ListWith60ListItems.default 607 655 0.93:1
AlertMinimalPerf.default 259 282 0.92:1
AvatarMinimalPerf.default 178 197 0.9:1

@chrisdholt chrisdholt merged commit 8f056d3 into microsoft:master Jul 16, 2021
@chrisdholt chrisdholt deleted the users/chhol/add-tsconfig-for-component-definitions branch July 16, 2021 22:21
@msft-fluent-ui-bot
Copy link
Collaborator

🎉@fluentui/[email protected] has been released which incorporates this pull request.:tada:

Handy links:

PeterDraex pushed a commit to PeterDraex/fluentui that referenced this pull request Aug 6, 2021
)

* ensure component definitions are resolved and exported

* Change files
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants