Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[web-components] provide single export for registering all components #18962

Conversation

chrisdholt
Copy link
Member

Pull request checklist

Description of changes

Adds a single export for registering all components easily.

Focus areas to test

(optional)

@fabricteam
Copy link
Collaborator

📊 Bundle size report

🤖 This report was generated against 7ca92e78f37a4e5bb41696d0c9b53b8388e82000

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 8951071:

Sandbox Source
Fluent UI React Starter Configuration

@size-auditor
Copy link

size-auditor bot commented Jul 15, 2021

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: 7ca92e78f37a4e5bb41696d0c9b53b8388e82000 (build)

@fabricteam
Copy link
Collaborator

Perf Analysis (@fluentui/react)

No significant results to display.

All results

Scenario Render type Master Ticks PR Ticks Iterations Status
Avatar mount 809 835 5000
BaseButton mount 908 918 5000
Breadcrumb mount 2673 2664 1000
ButtonNext mount 552 526 5000
Checkbox mount 1486 1549 5000
CheckboxBase mount 1310 1292 5000
ChoiceGroup mount 4786 4761 5000
ComboBox mount 975 1043 1000
CommandBar mount 10267 10267 1000
ContextualMenu mount 6322 6379 1000
DefaultButton mount 1146 1127 5000
DetailsRow mount 3884 3878 5000
DetailsRowFast mount 3779 3783 5000
DetailsRowNoStyles mount 3577 3614 5000
Dialog mount 2138 2182 1000
DocumentCardTitle mount 142 139 1000
Dropdown mount 3266 3232 5000
FluentProviderNext mount 7362 7461 5000
FocusTrapZone mount 1851 1840 5000
FocusZone mount 1809 1835 5000
IconButton mount 1771 1733 5000
Label mount 322 347 5000
Layer mount 1795 1766 5000
Link mount 476 472 5000
MakeStyles mount 1895 1869 50000
MenuButton mount 1482 1465 5000
MessageBar mount 2019 2071 5000
Nav mount 3322 3262 1000
OverflowSet mount 1077 1048 5000
Panel mount 2101 2075 1000
Persona mount 829 851 1000
Pivot mount 1406 1427 1000
PrimaryButton mount 1303 1297 5000
Rating mount 7821 7719 5000
SearchBox mount 1337 1321 5000
Shimmer mount 2649 2525 5000
Slider mount 1966 1991 5000
SpinButton mount 4993 5026 5000
Spinner mount 427 432 5000
SplitButton mount 3231 3241 5000
Stack mount 501 487 5000
StackWithIntrinsicChildren mount 1538 1539 5000
StackWithTextChildren mount 4558 4514 5000
SwatchColorPicker mount 10361 10264 5000
Tabs mount 1429 1414 1000
TagPicker mount 2440 2451 5000
TeachingBubble mount 12118 12088 5000
Text mount 408 418 5000
TextField mount 1374 1386 5000
ThemeProvider mount 1200 1156 5000
ThemeProvider virtual-rerender 622 611 5000
Toggle mount 826 815 5000
buttonNative mount 115 108 5000

Perf Analysis (@fluentui/react-northstar)

Perf tests with no regressions
Scenario Current PR Ticks Baseline Ticks Ratio
VideoMinimalPerf.default 644 589 1.09:1
TreeWith60ListItems.default 181 167 1.08:1
SegmentMinimalPerf.default 359 335 1.07:1
DividerMinimalPerf.default 374 352 1.06:1
BoxMinimalPerf.default 354 337 1.05:1
ChatDuplicateMessagesPerf.default 298 284 1.05:1
DropdownManyItemsPerf.default 691 655 1.05:1
FormMinimalPerf.default 408 387 1.05:1
GridMinimalPerf.default 349 333 1.05:1
HeaderMinimalPerf.default 374 356 1.05:1
ImageMinimalPerf.default 364 346 1.05:1
SkeletonMinimalPerf.default 364 347 1.05:1
HeaderSlotsPerf.default 781 748 1.04:1
MenuMinimalPerf.default 883 852 1.04:1
AnimationMinimalPerf.default 415 401 1.03:1
CardMinimalPerf.default 550 532 1.03:1
RadioGroupMinimalPerf.default 447 433 1.03:1
RefMinimalPerf.default 240 234 1.03:1
AvatarMinimalPerf.default 191 188 1.02:1
LabelMinimalPerf.default 384 378 1.02:1
ListMinimalPerf.default 517 505 1.02:1
ReactionMinimalPerf.default 384 378 1.02:1
TooltipMinimalPerf.default 1007 990 1.02:1
ButtonOverridesMissPerf.default 1724 1704 1.01:1
EmbedMinimalPerf.default 4182 4153 1.01:1
InputMinimalPerf.default 1273 1264 1.01:1
ListWith60ListItems.default 637 633 1.01:1
LoaderMinimalPerf.default 701 692 1.01:1
PopupMinimalPerf.default 602 594 1.01:1
ToolbarMinimalPerf.default 938 926 1.01:1
CarouselMinimalPerf.default 460 459 1:1
CheckboxMinimalPerf.default 2773 2769 1:1
DatepickerMinimalPerf.default 5439 5419 1:1
DialogMinimalPerf.default 742 744 1:1
ItemLayoutMinimalPerf.default 1213 1209 1:1
ListNestedPerf.default 561 559 1:1
MenuButtonMinimalPerf.default 1645 1644 1:1
SliderMinimalPerf.default 1582 1583 1:1
StatusMinimalPerf.default 691 689 1:1
IconMinimalPerf.default 627 624 1:1
TableMinimalPerf.default 403 402 1:1
CustomToolbarPrototype.default 3857 3856 1:1
TreeMinimalPerf.default 791 794 1:1
AlertMinimalPerf.default 263 266 0.99:1
ButtonMinimalPerf.default 169 170 0.99:1
ButtonSlotsPerf.default 550 555 0.99:1
DropdownMinimalPerf.default 3120 3154 0.99:1
FlexMinimalPerf.default 286 289 0.99:1
LayoutMinimalPerf.default 373 375 0.99:1
PortalMinimalPerf.default 180 181 0.99:1
ProviderMergeThemesPerf.default 1674 1686 0.99:1
SplitButtonMinimalPerf.default 3833 3857 0.99:1
TextAreaMinimalPerf.default 497 502 0.99:1
AttachmentMinimalPerf.default 156 159 0.98:1
AttachmentSlotsPerf.default 1067 1092 0.98:1
ChatMinimalPerf.default 651 664 0.98:1
ProviderMinimalPerf.default 973 990 0.98:1
TableManyItemsPerf.default 1878 1911 0.98:1
TextMinimalPerf.default 340 347 0.98:1
AccordionMinimalPerf.default 148 152 0.97:1
ListCommonPerf.default 615 631 0.97:1
ChatWithPopoverPerf.default 359 382 0.94:1
RosterPerf.default 1160 1235 0.94:1

@chrisdholt chrisdholt merged commit 874be49 into microsoft:master Jul 15, 2021
@chrisdholt chrisdholt deleted the users/chhol/provide-single-export-for-registering-all-components branch July 15, 2021 21:28
@msft-fluent-ui-bot
Copy link
Collaborator

🎉@fluentui/[email protected] has been released which incorporates this pull request.:tada:

Handy links:

PeterDraex pushed a commit to PeterDraex/fluentui that referenced this pull request Aug 6, 2021
…microsoft#18962)

* add single export object for easily registering all Fluent UI web components

* Change files
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow all web components to be initialized from a single export
5 participants