Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update foundation version to fix token typings #18948

Conversation

chrisdholt
Copy link
Member

Pull request checklist

  • Addresses an existing issue: Fixes #0000
  • Include a change request file using $ yarn change

Description of changes

A type error in the typing for CSSDesignToken did not like to work with Swatch. We've extended the typing in v2.5.0

Focus areas to test

(optional)

@size-auditor
Copy link

size-auditor bot commented Jul 15, 2021

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: 77457de1a3be11dfe66b3634daaa35d7ab23cef9 (build)

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 740ff7e:

Sandbox Source
Fluent UI React Starter Configuration

@fabricteam
Copy link
Collaborator

📊 Bundle size report

Unchanged fixtures
Package & Exports Size (minified/GZIP)
react-divider
Divider
15.889 kB
5.747 kB
react-image
Image
10.642 kB
4.264 kB
react-make-styles
makeStaticStyles (runtime)
7.59 kB
3.321 kB
react-make-styles
makeStyles + mergeClasses (runtime)
22.135 kB
8.356 kB
react-make-styles
makeStyles + mergeClasses (build time)
2.557 kB
1.202 kB
react-menu
Menu - Default
113.947 kB
34.389 kB
react-menu
Menu - Selectable
115.959 kB
34.649 kB
react-popover
Popover
140.938 kB
41.968 kB
react-theme
Teams: all themes
31.935 kB
6.49 kB
react-theme
Teams: Light theme
19.527 kB
5.504 kB
🤖 This report was generated against 77457de1a3be11dfe66b3634daaa35d7ab23cef9

@fabricteam
Copy link
Collaborator

Perf Analysis (@fluentui/react)

No significant results to display.

All results

Scenario Render type Master Ticks PR Ticks Iterations Status
Avatar mount 806 806 5000
BaseButton mount 889 902 5000
Breadcrumb mount 2562 2534 1000
ButtonNext mount 513 509 5000
Checkbox mount 1490 1494 5000
CheckboxBase mount 1264 1281 5000
ChoiceGroup mount 4614 4582 5000
ComboBox mount 946 963 1000
CommandBar mount 9934 9987 1000
ContextualMenu mount 6138 6100 1000
DefaultButton mount 1091 1085 5000
DetailsRow mount 3640 3606 5000
DetailsRowFast mount 3628 3577 5000
DetailsRowNoStyles mount 3429 3448 5000
Dialog mount 2148 2024 1000
DocumentCardTitle mount 129 146 1000
Dropdown mount 3176 3140 5000
FluentProviderNext mount 7050 7120 5000
FocusTrapZone mount 1759 1739 5000
FocusZone mount 1745 1768 5000
IconButton mount 1695 1856 5000
Label mount 334 328 5000
Layer mount 1759 1758 5000
Link mount 451 453 5000
MakeStyles mount 1798 1781 50000
MenuButton mount 1401 1415 5000
MessageBar mount 1957 1964 5000
Nav mount 3199 3135 1000
OverflowSet mount 989 1016 5000
Panel mount 2048 1982 1000
Persona mount 779 807 1000
Pivot mount 1379 1340 1000
PrimaryButton mount 1274 1263 5000
Rating mount 7429 7400 5000
SearchBox mount 1321 1294 5000
Shimmer mount 2525 2447 5000
Slider mount 1932 1930 5000
SpinButton mount 4991 4851 5000
Spinner mount 432 409 5000
SplitButton mount 3035 3130 5000
Stack mount 475 485 5000
StackWithIntrinsicChildren mount 1456 1476 5000
StackWithTextChildren mount 4368 4384 5000
SwatchColorPicker mount 9881 9924 5000
Tabs mount 1365 1378 1000
TagPicker mount 2352 2371 5000
TeachingBubble mount 11649 11649 5000
Text mount 401 417 5000
TextField mount 1344 1371 5000
ThemeProvider mount 1171 1156 5000
ThemeProvider virtual-rerender 594 584 5000
Toggle mount 783 787 5000
buttonNative mount 120 112 5000

Perf Analysis (@fluentui/react-northstar)

Perf tests with no regressions
Scenario Current PR Ticks Baseline Ticks Ratio
TreeWith60ListItems.default 177 163 1.09:1
FlexMinimalPerf.default 282 263 1.07:1
ListCommonPerf.default 623 593 1.05:1
AnimationMinimalPerf.default 408 394 1.04:1
ChatWithPopoverPerf.default 349 337 1.04:1
ListNestedPerf.default 546 524 1.04:1
TableMinimalPerf.default 408 392 1.04:1
TextMinimalPerf.default 342 330 1.04:1
TreeMinimalPerf.default 801 771 1.04:1
AttachmentMinimalPerf.default 153 148 1.03:1
ButtonSlotsPerf.default 534 519 1.03:1
CardMinimalPerf.default 548 534 1.03:1
EmbedMinimalPerf.default 4083 3969 1.03:1
GridMinimalPerf.default 321 312 1.03:1
PortalMinimalPerf.default 177 172 1.03:1
RadioGroupMinimalPerf.default 446 434 1.03:1
CarouselMinimalPerf.default 452 443 1.02:1
ChatMinimalPerf.default 631 619 1.02:1
CheckboxMinimalPerf.default 2721 2676 1.02:1
DividerMinimalPerf.default 356 349 1.02:1
ListMinimalPerf.default 504 496 1.02:1
LoaderMinimalPerf.default 693 678 1.02:1
PopupMinimalPerf.default 597 584 1.02:1
ProviderMinimalPerf.default 951 935 1.02:1
TextAreaMinimalPerf.default 486 478 1.02:1
AlertMinimalPerf.default 271 267 1.01:1
BoxMinimalPerf.default 341 338 1.01:1
ButtonOverridesMissPerf.default 1667 1652 1.01:1
ChatDuplicateMessagesPerf.default 275 272 1.01:1
DialogMinimalPerf.default 741 735 1.01:1
InputMinimalPerf.default 1224 1206 1.01:1
MenuButtonMinimalPerf.default 1592 1580 1.01:1
ReactionMinimalPerf.default 366 363 1.01:1
SkeletonMinimalPerf.default 350 345 1.01:1
SliderMinimalPerf.default 1530 1509 1.01:1
IconMinimalPerf.default 603 595 1.01:1
TooltipMinimalPerf.default 992 986 1.01:1
DatepickerMinimalPerf.default 5261 5255 1:1
SplitButtonMinimalPerf.default 3708 3709 1:1
StatusMinimalPerf.default 665 663 1:1
TableManyItemsPerf.default 1908 1904 1:1
CustomToolbarPrototype.default 3770 3767 1:1
ToolbarMinimalPerf.default 904 906 1:1
AccordionMinimalPerf.default 146 148 0.99:1
AvatarMinimalPerf.default 187 188 0.99:1
DropdownManyItemsPerf.default 653 657 0.99:1
DropdownMinimalPerf.default 3012 3034 0.99:1
FormMinimalPerf.default 386 391 0.99:1
HeaderMinimalPerf.default 345 349 0.99:1
HeaderSlotsPerf.default 736 744 0.99:1
ImageMinimalPerf.default 360 363 0.99:1
ProviderMergeThemesPerf.default 1619 1631 0.99:1
VideoMinimalPerf.default 614 618 0.99:1
AttachmentSlotsPerf.default 1049 1066 0.98:1
ItemLayoutMinimalPerf.default 1166 1186 0.98:1
LabelMinimalPerf.default 373 379 0.98:1
MenuMinimalPerf.default 803 818 0.98:1
RefMinimalPerf.default 225 229 0.98:1
SegmentMinimalPerf.default 326 331 0.98:1
ButtonMinimalPerf.default 160 165 0.97:1
RosterPerf.default 1123 1156 0.97:1
ListWith60ListItems.default 604 627 0.96:1
LayoutMinimalPerf.default 345 363 0.95:1

@chrisdholt chrisdholt merged commit 966a306 into microsoft:master Jul 15, 2021
@chrisdholt chrisdholt deleted the users/chhol/update-foundation-version-to-fix-token-typings branch July 15, 2021 03:13
@msft-fluent-ui-bot
Copy link
Collaborator

🎉@fluentui/[email protected] has been released which incorporates this pull request.:tada:

Handy links:

PeterDraex pushed a commit to PeterDraex/fluentui that referenced this pull request Aug 6, 2021
* update fast-foundation version to fix design token typings

* Change files
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants