Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(Slider) - Resetting react-slider package in preparation for convergence #18911

Merged
merged 14 commits into from
Jul 13, 2021
Merged

(Slider) - Resetting react-slider package in preparation for convergence #18911

merged 14 commits into from
Jul 13, 2021

Conversation

czearing
Copy link
Collaborator

Pull request checklist

Description of changes

  1. Removing react-slider package and examples.
  2. Running yarn create-package
  3. Running yarn nx workspace-generator migrate-converged-pkg
  4. Running yarn create-component
  5. Updating README.md
  6. Commenting out code and temporarily removing test file.

@czearing czearing requested review from a team as code owners July 12, 2021 21:36
@size-auditor
Copy link

size-auditor bot commented Jul 12, 2021 •
edited
Loading

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: 3ab4b1fa75d1a485544d77d575720ff11901272a (build)

@codesandbox-ci
Copy link

codesandbox-ci bot commented Jul 12, 2021 •
edited
Loading

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 173f38b:

Sandbox Source
Fluent UI Button Configuration
codesandbox-react-template Configuration
codesandbox-react-northstar-template Configuration

@czearing
Merge branch 'master' of https://github.com/microsoft/fluentui into f…
8920663 
…eat/react-slider-removing-component

# Conflicts:
#	jest.config.js
#	nx.json
#	packages/react-examples/package.json
#	packages/react-slider/CHANGELOG.json
#	packages/react-slider/CHANGELOG.md
#	packages/react-slider/package.json
#	tsconfig.base.json
#	workspace.json
@fabricteam
Copy link
Collaborator

fabricteam commented Jul 13, 2021 •
edited
Loading

Perf Analysis (@fluentui/react)

No significant results to display.

All results

Scenario Render type Master Ticks PR Ticks Iterations Status
Avatar mount 818 829 5000
BaseButton mount 911 942 5000
Breadcrumb mount 2657 2640 1000
ButtonNext mount 550 538 5000
Checkbox mount 1576 1541 5000
CheckboxBase mount 1336 1358 5000
ChoiceGroup mount 4848 4812 5000
ComboBox mount 1002 1013 1000
CommandBar mount 10028 10266 1000
ContextualMenu mount 5867 6085 1000
DefaultButton mount 1081 1068 5000
DetailsRow mount 3558 3510 5000
DetailsRowFast mount 3590 3498 5000
DetailsRowNoStyles mount 3394 3332 5000
Dialog mount 2076 2042 1000
DocumentCardTitle mount 135 140 1000
Dropdown mount 3108 3079 5000
FluentProviderNext mount 6903 6985 5000
FocusTrapZone mount 1686 1755 5000
FocusZone mount 1743 1745 5000
IconButton mount 1664 1655 5000
Label mount 318 310 5000
Layer mount 1659 1663 5000
Link mount 436 451 5000
MakeStyles mount 1737 1748 50000
MenuButton mount 1413 1410 5000
MessageBar mount 1916 1980 5000
Nav mount 3061 3115 1000
OverflowSet mount 974 964 5000
Panel mount 2034 1991 1000
Persona mount 771 784 1000
Pivot mount 1323 1356 1000
PrimaryButton mount 1197 1197 5000
Rating mount 7270 7170 5000
SearchBox mount 1233 1261 5000
Shimmer mount 2411 2426 5000
Slider mount 1842 1847 5000
SpinButton mount 4718 5129 5000
Spinner mount 388 393 5000
SplitButton mount 2976 3188 5000
Stack mount 465 457 5000
StackWithIntrinsicChildren mount 1437 1427 5000
StackWithTextChildren mount 4287 4260 5000
SwatchColorPicker mount 9703 9525 5000
Tabs mount 1329 1350 1000
TagPicker mount 2308 2282 5000
TeachingBubble mount 11311 11392 5000
Text mount 383 399 5000
TextField mount 1289 1303 5000
ThemeProvider mount 1143 1121 5000
ThemeProvider virtual-rerender 586 575 5000
Toggle mount 772 774 5000
buttonNative mount 111 124 5000

Perf Analysis (@fluentui/react-northstar)

Perf tests with no regressions
Scenario Current PR Ticks Baseline Ticks Ratio
BoxMinimalPerf.default 363 334 1.09:1
FlexMinimalPerf.default 299 278 1.08:1
RadioGroupMinimalPerf.default 461 436 1.06:1
TableMinimalPerf.default 425 401 1.06:1
HeaderSlotsPerf.default 783 748 1.05:1
PortalMinimalPerf.default 184 175 1.05:1
LabelMinimalPerf.default 381 366 1.04:1
AnimationMinimalPerf.default 423 409 1.03:1
GridMinimalPerf.default 340 329 1.03:1
ReactionMinimalPerf.default 380 370 1.03:1
VideoMinimalPerf.default 636 616 1.03:1
AccordionMinimalPerf.default 161 158 1.02:1
ListNestedPerf.default 567 556 1.02:1
StatusMinimalPerf.default 692 676 1.02:1
TextMinimalPerf.default 348 340 1.02:1
TreeWith60ListItems.default 180 176 1.02:1
ButtonSlotsPerf.default 561 558 1.01:1
CardMinimalPerf.default 550 546 1.01:1
ChatWithPopoverPerf.default 371 368 1.01:1
CheckboxMinimalPerf.default 2795 2771 1.01:1
DialogMinimalPerf.default 775 767 1.01:1
DropdownManyItemsPerf.default 682 677 1.01:1
LoaderMinimalPerf.default 706 697 1.01:1
SkeletonMinimalPerf.default 357 353 1.01:1
SliderMinimalPerf.default 1594 1576 1.01:1
SplitButtonMinimalPerf.default 3849 3810 1.01:1
IconMinimalPerf.default 618 613 1.01:1
TextAreaMinimalPerf.default 507 502 1.01:1
CustomToolbarPrototype.default 3864 3818 1.01:1
ToolbarMinimalPerf.default 944 936 1.01:1
TreeMinimalPerf.default 810 805 1.01:1
DatepickerMinimalPerf.default 5432 5443 1:1
DividerMinimalPerf.default 354 353 1:1
EmbedMinimalPerf.default 4169 4170 1:1
MenuMinimalPerf.default 857 854 1:1
ProviderMinimalPerf.default 975 977 1:1
SegmentMinimalPerf.default 344 345 1:1
TooltipMinimalPerf.default 1016 1015 1:1
AvatarMinimalPerf.default 191 193 0.99:1
ButtonMinimalPerf.default 174 176 0.99:1
ButtonOverridesMissPerf.default 1703 1721 0.99:1
CarouselMinimalPerf.default 459 463 0.99:1
DropdownMinimalPerf.default 3107 3145 0.99:1
InputMinimalPerf.default 1247 1261 0.99:1
ItemLayoutMinimalPerf.default 1226 1234 0.99:1
LayoutMinimalPerf.default 370 372 0.99:1
ListCommonPerf.default 619 626 0.99:1
ListMinimalPerf.default 515 519 0.99:1
MenuButtonMinimalPerf.default 1644 1667 0.99:1
TableManyItemsPerf.default 1913 1925 0.99:1
ChatMinimalPerf.default 639 654 0.98:1
FormMinimalPerf.default 392 399 0.98:1
PopupMinimalPerf.default 594 606 0.98:1
AttachmentSlotsPerf.default 1040 1069 0.97:1
ListWith60ListItems.default 623 641 0.97:1
ProviderMergeThemesPerf.default 1702 1747 0.97:1
RefMinimalPerf.default 228 236 0.97:1
AttachmentMinimalPerf.default 149 156 0.96:1
AlertMinimalPerf.default 269 282 0.95:1
ImageMinimalPerf.default 372 391 0.95:1
RosterPerf.default 1138 1202 0.95:1
ChatDuplicateMessagesPerf.default 270 290 0.93:1
HeaderMinimalPerf.default 359 385 0.93:1

khmakoto
khmakoto approved these changes Jul 13, 2021
View reviewed changes
packages/react-slider/README.md Outdated
@@ -2,14 +2,23 @@

**React Slider components for [Fluent UI React](https://developer.microsoft.com/en-us/fluentui)**

The Slider component allows users to quickly select a value or range from a gliding bar. It is often used when setting
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe you meant

Suggested change
The Slider component allows users to quickly select a value or range from a gliding bar. It is often used when setting
The Slider component allows users to quickly select a value or range from a sliding bar. It is often used when setting

czearing added 2 commits July 13, 2021 15:10
@czearing
Updating the README
abc59d9
@czearing
Merge branch 'master' of https://github.com/microsoft/fluentui into f…
173f38b 
…eat/react-slider-removing-component

# Conflicts:
#	packages/react-examples/package.json
#	packages/react-slider/package.json
@czearing czearing merged commit 0499247 into microsoft:master Jul 13, 2021
PeterDraex pushed a commit to PeterDraex/fluentui that referenced this pull request Aug 6, 2021
@czearing @PeterDraex
(Slider) - Resetting react-slider package in preparation for converge…
27fa050 
…nce (microsoft#18911)

* re-creating react-slider package to prepare for convergence.

* Updating docs and running migration generator.

* Updating package JSON

* Commenting out code and removing test.

* Change files

* Cleaning up examples and change file.

* Reverting a change.

* Quick fix

* Updating Slider dep

* Updating jest-serializer-make-styles version in react-slider.

* Updating the README
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@khmakoto khmakoto khmakoto approved these changes

@ecraig12345 ecraig12345 ecraig12345 approved these changes

Assignees

@ling1726 ling1726

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@czearing @fabricteam @ecraig12345 @khmakoto @ling1726