Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(web-components) Added attribute to allow easy update to the neutral palette #18910

Merged
merged 2 commits into from
Jul 13, 2021
Merged

(web-components) Added attribute to allow easy update to the neutral palette #18910

merged 2 commits into from
Jul 13, 2021

Conversation

bheston
Copy link
Contributor

@bheston bheston commented Jul 12, 2021

Pull request checklist

  • Addresses an existing issue: Fixes #0000
  • Include a change request file using $ yarn change

Description of changes

Added an attribute to allow backward compatible updates to the DSP neutral palette base color

Focus areas to test

(optional)

@bheston
Copy link
Contributor Author

bheston commented Jul 12, 2021

neutral-red

Test of card on DSP with red base. Note color shift is from unrelated change.

@bheston bheston changed the title Added attribute to allow easy update to the neutral palette (web-components) Added attribute to allow easy update to the neutral palette Jul 12, 2021
@size-auditor
Copy link

size-auditor bot commented Jul 12, 2021

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: 8e5969e291bcafac21df12c9fb591bdd5654c613 (build)

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 398ef4d:

Sandbox Source
Fluent UI Button Configuration
codesandbox-react-template Configuration
codesandbox-react-northstar-template Configuration

@fabricteam
Copy link
Collaborator

Perf Analysis (@fluentui/react)

No significant results to display.

All results

Scenario Render type Master Ticks PR Ticks Iterations Status
Avatar mount 779 782 5000
BaseButton mount 853 894 5000
Breadcrumb mount 2485 2536 1000
ButtonNext mount 500 522 5000
Checkbox mount 1519 1478 5000
CheckboxBase mount 1266 1277 5000
ChoiceGroup mount 4709 4731 5000
ComboBox mount 931 950 1000
CommandBar mount 9780 9780 1000
ContextualMenu mount 6068 5989 1000
DefaultButton mount 1063 1088 5000
DetailsRow mount 3539 3518 5000
DetailsRowFast mount 3527 3582 5000
DetailsRowNoStyles mount 3405 3391 5000
Dialog mount 2088 2117 1000
DocumentCardTitle mount 132 154 1000
Dropdown mount 3115 3073 5000
FluentProviderNext mount 7076 6997 5000
FocusTrapZone mount 1717 1683 5000
FocusZone mount 1683 1732 5000
IconButton mount 1660 1651 5000
Label mount 319 322 5000
Layer mount 1687 1726 5000
Link mount 473 459 5000
MakeStyles mount 1768 1761 50000
MenuButton mount 1399 1392 5000
MessageBar mount 1976 1953 5000
Nav mount 3179 3102 1000
OverflowSet mount 1011 1028 5000
Panel mount 2059 2151 1000
Persona mount 795 807 1000
Pivot mount 1354 1357 1000
PrimaryButton mount 1242 1272 5000
Rating mount 7629 7481 5000
SearchBox mount 1372 1343 5000
Shimmer mount 2513 2569 5000
Slider mount 1926 1944 5000
SpinButton mount 4934 4947 5000
Spinner mount 427 408 5000
SplitButton mount 3138 3102 5000
Stack mount 499 486 5000
StackWithIntrinsicChildren mount 1506 1502 5000
StackWithTextChildren mount 4586 4619 5000
SwatchColorPicker mount 10301 10133 5000
Tabs mount 1381 1408 1000
TagPicker mount 2455 2406 5000
TeachingBubble mount 11907 11862 5000
Text mount 427 404 5000
TextField mount 1396 1389 5000
ThemeProvider mount 1215 1186 5000
ThemeProvider virtual-rerender 615 603 5000
Toggle mount 819 788 5000
buttonNative mount 110 115 5000

Perf Analysis (@fluentui/react-northstar)

Perf tests with no regressions
Scenario Current PR Ticks Baseline Ticks Ratio
ButtonMinimalPerf.default 177 159 1.11:1
ListWith60ListItems.default 614 575 1.07:1
IconMinimalPerf.default 598 557 1.07:1
AvatarMinimalPerf.default 199 189 1.05:1
ChatMinimalPerf.default 636 608 1.05:1
PortalMinimalPerf.default 170 162 1.05:1
AlertMinimalPerf.default 262 253 1.04:1
BoxMinimalPerf.default 335 323 1.04:1
GridMinimalPerf.default 322 310 1.04:1
LabelMinimalPerf.default 382 369 1.04:1
AttachmentMinimalPerf.default 148 143 1.03:1
FlexMinimalPerf.default 277 270 1.03:1
ItemLayoutMinimalPerf.default 1193 1155 1.03:1
SegmentMinimalPerf.default 330 320 1.03:1
AttachmentSlotsPerf.default 1042 1021 1.02:1
ButtonOverridesMissPerf.default 1639 1613 1.02:1
DividerMinimalPerf.default 339 331 1.02:1
HeaderMinimalPerf.default 341 335 1.02:1
ImageMinimalPerf.default 371 365 1.02:1
LoaderMinimalPerf.default 669 655 1.02:1
RadioGroupMinimalPerf.default 425 417 1.02:1
CheckboxMinimalPerf.default 2621 2606 1.01:1
EmbedMinimalPerf.default 3958 3914 1.01:1
FormMinimalPerf.default 382 377 1.01:1
HeaderSlotsPerf.default 720 710 1.01:1
LayoutMinimalPerf.default 350 345 1.01:1
PopupMinimalPerf.default 569 564 1.01:1
StatusMinimalPerf.default 645 639 1.01:1
TableMinimalPerf.default 383 378 1.01:1
ButtonSlotsPerf.default 521 522 1:1
ChatDuplicateMessagesPerf.default 278 277 1:1
ChatWithPopoverPerf.default 335 335 1:1
InputMinimalPerf.default 1231 1226 1:1
ProviderMergeThemesPerf.default 1581 1586 1:1
ProviderMinimalPerf.default 922 924 1:1
RefMinimalPerf.default 224 223 1:1
CustomToolbarPrototype.default 3621 3625 1:1
ToolbarMinimalPerf.default 893 889 1:1
TooltipMinimalPerf.default 951 948 1:1
TreeMinimalPerf.default 758 756 1:1
AnimationMinimalPerf.default 401 405 0.99:1
DialogMinimalPerf.default 722 727 0.99:1
DropdownManyItemsPerf.default 649 655 0.99:1
DropdownMinimalPerf.default 2965 2980 0.99:1
MenuMinimalPerf.default 826 833 0.99:1
MenuButtonMinimalPerf.default 1561 1572 0.99:1
ReactionMinimalPerf.default 354 356 0.99:1
SliderMinimalPerf.default 1483 1491 0.99:1
SplitButtonMinimalPerf.default 3601 3632 0.99:1
TextMinimalPerf.default 324 327 0.99:1
AccordionMinimalPerf.default 143 146 0.98:1
ListMinimalPerf.default 479 491 0.98:1
TableManyItemsPerf.default 1780 1808 0.98:1
TreeWith60ListItems.default 166 169 0.98:1
CarouselMinimalPerf.default 418 430 0.97:1
DatepickerMinimalPerf.default 5070 5224 0.97:1
ListCommonPerf.default 585 606 0.97:1
SkeletonMinimalPerf.default 329 338 0.97:1
TextAreaMinimalPerf.default 468 483 0.97:1
CardMinimalPerf.default 516 537 0.96:1
ListNestedPerf.default 505 530 0.95:1
RosterPerf.default 1069 1124 0.95:1
VideoMinimalPerf.default 587 627 0.94:1

@chrisdholt chrisdholt merged commit a63f33c into microsoft:master Jul 13, 2021
@msft-fluent-ui-bot
Copy link
Collaborator

🎉@fluentui/[email protected] has been released which incorporates this pull request.:tada:

Handy links:

@bheston bheston deleted the dsp-neutral-palette branch July 15, 2021 17:30
PeterDraex pushed a commit to PeterDraex/fluentui that referenced this pull request Aug 6, 2021
@bheston @PeterDraex
(web-components) Added attribute to allow easy update to the neutral …
91ee963 
…palette (microsoft#18910)

* Added attribute to allow easy update to the neutral palette

* Change files
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chrisdholt chrisdholt chrisdholt approved these changes

@EisenbergEffect EisenbergEffect EisenbergEffect approved these changes

@nicholasrice nicholasrice Awaiting requested review from nicholasrice

Assignees

@ling1726 ling1726

Labels
web-components
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@bheston @fabricteam @msft-fluent-ui-bot @EisenbergEffect @chrisdholt @ling1726