Bug 111881: UnifiedPicker: Backspace does not work for recipients in pop out window #18428
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: b729819d6aca1af2acfee1294cb8f44b72a02fff (build) |
elisabethcvs
approved these changes
Jun 2, 2021
jaredi
approved these changes
Jun 2, 2021
Perf Analysis (
|
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| Avatar | mount | 871 | 891 | 5000 | |
| BaseButton | mount | 1052 | 1054 | 5000 | |
| Breadcrumb | mount | 2706 | 2810 | 1000 | |
| ButtonNext | mount | 533 | 526 | 5000 | |
| Checkbox | mount | 1747 | 1653 | 5000 | |
| CheckboxBase | mount | 1415 | 1493 | 5000 | |
| ChoiceGroup | mount | 5278 | 5260 | 5000 | |
| ComboBox | mount | 1015 | 1037 | 1000 | |
| CommandBar | mount | 10864 | 10612 | 1000 | |
| ContextualMenu | mount | 6453 | 6547 | 1000 | |
| DefaultButton | mount | 1301 | 1269 | 5000 | |
| DetailsRow | mount | 4100 | 4092 | 5000 | |
| DetailsRowFast | mount | 4092 | 4122 | 5000 | |
| DetailsRowNoStyles | mount | 3877 | 3800 | 5000 | |
| Dialog | mount | 2311 | 2302 | 1000 | |
| DocumentCardTitle | mount | 169 | 172 | 1000 | |
| Dropdown | mount | 3541 | 3630 | 5000 | |
| FocusTrapZone | mount | 1918 | 1933 | 5000 | |
| FocusZone | mount | 1873 | 1909 | 5000 | |
| IconButton | mount | 1932 | 1909 | 5000 | |
| Label | mount | 358 | 361 | 5000 | |
| Layer | mount | 2000 | 1945 | 5000 | |
| Link | mount | 512 | 546 | 5000 | |
| MakeStyles | mount | 1899 | 1884 | 50000 | |
| MenuButton | mount | 1631 | 1653 | 5000 | |
| MessageBar | mount | 2194 | 2148 | 5000 | |
| Nav | mount | 3540 | 3515 | 1000 | |
| OverflowSet | mount | 1105 | 1077 | 5000 | |
| Panel | mount | 2224 | 2161 | 1000 | |
| Persona | mount | 906 | 877 | 1000 | |
| Pivot | mount | 1558 | 1562 | 1000 | |
| PrimaryButton | mount | 1459 | 1450 | 5000 | |
| Rating | mount | 8790 | 8778 | 5000 | |
| SearchBox | mount | 1508 | 1543 | 5000 | |
| Shimmer | mount | 2862 | 2964 | 5000 | |
| Slider | mount | 2165 | 2102 | 5000 | |
| SpinButton | mount | 5339 | 5380 | 5000 | |
| Spinner | mount | 421 | 435 | 5000 | |
| SplitButton | mount | 3499 | 3554 | 5000 | |
| Stack | mount | 560 | 564 | 5000 | |
| StackWithIntrinsicChildren | mount | 1663 | 1709 | 5000 | |
| StackWithTextChildren | mount | 5001 | 5073 | 5000 | |
| SwatchColorPicker | mount | 11076 | 10851 | 5000 | |
| Tabs | mount | 1513 | 1517 | 1000 | |
| TagPicker | mount | 2625 | 2654 | 5000 | |
| TeachingBubble | mount | 12662 | 12661 | 5000 | |
| Text | mount | 457 | 453 | 5000 | |
| TextField | mount | 1529 | 1523 | 5000 | |
| ThemeProvider | mount | 1272 | 1283 | 5000 | |
| ThemeProvider | virtual-rerender | 648 | 644 | 5000 | |
| ThemeProviderNext | mount | 7099 | 7261 | 5000 | |
| Toggle | mount | 907 | 881 | 5000 | |
| buttonNative | mount | 122 | 117 | 5000 |
Perf Analysis (@fluentui/react-northstar)
Perf tests with no regressions
| Scenario | Current PR Ticks | Baseline Ticks | Ratio |
|---|---|---|---|
| GridMinimalPerf.default | 418 | 371 | 1.13:1 |
| AttachmentMinimalPerf.default | 191 | 173 | 1.1:1 |
| ImageMinimalPerf.default | 446 | 410 | 1.09:1 |
| HeaderMinimalPerf.default | 450 | 421 | 1.07:1 |
| CarouselMinimalPerf.default | 538 | 507 | 1.06:1 |
| SegmentMinimalPerf.default | 390 | 369 | 1.06:1 |
| TextMinimalPerf.default | 404 | 382 | 1.06:1 |
| AvatarMinimalPerf.default | 231 | 220 | 1.05:1 |
| ButtonSlotsPerf.default | 629 | 598 | 1.05:1 |
| ChatMinimalPerf.default | 701 | 670 | 1.05:1 |
| RadioGroupMinimalPerf.default | 519 | 494 | 1.05:1 |
| ListNestedPerf.default | 618 | 596 | 1.04:1 |
| PopupMinimalPerf.default | 618 | 595 | 1.04:1 |
| ReactionMinimalPerf.default | 454 | 437 | 1.04:1 |
| BoxMinimalPerf.default | 410 | 398 | 1.03:1 |
| ChatDuplicateMessagesPerf.default | 329 | 319 | 1.03:1 |
| InputMinimalPerf.default | 1332 | 1299 | 1.03:1 |
| ItemLayoutMinimalPerf.default | 1434 | 1388 | 1.03:1 |
| ListCommonPerf.default | 725 | 704 | 1.03:1 |
| ListMinimalPerf.default | 568 | 551 | 1.03:1 |
| RosterPerf.default | 1302 | 1263 | 1.03:1 |
| PortalMinimalPerf.default | 185 | 180 | 1.03:1 |
| SplitButtonMinimalPerf.default | 4118 | 4012 | 1.03:1 |
| TooltipMinimalPerf.default | 1115 | 1083 | 1.03:1 |
| DatepickerMinimalPerf.default | 5876 | 5734 | 1.02:1 |
| DialogMinimalPerf.default | 829 | 815 | 1.02:1 |
| DividerMinimalPerf.default | 397 | 388 | 1.02:1 |
| HeaderSlotsPerf.default | 857 | 840 | 1.02:1 |
| RefMinimalPerf.default | 250 | 244 | 1.02:1 |
| TableManyItemsPerf.default | 2169 | 2130 | 1.02:1 |
| AttachmentSlotsPerf.default | 1295 | 1278 | 1.01:1 |
| ButtonMinimalPerf.default | 189 | 188 | 1.01:1 |
| CheckboxMinimalPerf.default | 2996 | 2960 | 1.01:1 |
| FormMinimalPerf.default | 483 | 480 | 1.01:1 |
| MenuMinimalPerf.default | 931 | 920 | 1.01:1 |
| MenuButtonMinimalPerf.default | 1756 | 1741 | 1.01:1 |
| ProviderMinimalPerf.default | 1054 | 1040 | 1.01:1 |
| CustomToolbarPrototype.default | 3972 | 3947 | 1.01:1 |
| ToolbarMinimalPerf.default | 1069 | 1062 | 1.01:1 |
| TreeWith60ListItems.default | 199 | 197 | 1.01:1 |
| VideoMinimalPerf.default | 688 | 684 | 1.01:1 |
| AnimationMinimalPerf.default | 443 | 442 | 1:1 |
| CardMinimalPerf.default | 647 | 650 | 1:1 |
| EmbedMinimalPerf.default | 4463 | 4446 | 1:1 |
| LayoutMinimalPerf.default | 414 | 414 | 1:1 |
| LoaderMinimalPerf.default | 736 | 735 | 1:1 |
| ProviderMergeThemesPerf.default | 1733 | 1738 | 1:1 |
| StatusMinimalPerf.default | 771 | 774 | 1:1 |
| TableMinimalPerf.default | 457 | 458 | 1:1 |
| TreeMinimalPerf.default | 891 | 889 | 1:1 |
| AccordionMinimalPerf.default | 165 | 166 | 0.99:1 |
| AlertMinimalPerf.default | 307 | 311 | 0.99:1 |
| ButtonOverridesMissPerf.default | 1814 | 1831 | 0.99:1 |
| DropdownMinimalPerf.default | 3197 | 3229 | 0.99:1 |
| ListWith60ListItems.default | 729 | 734 | 0.99:1 |
| TextAreaMinimalPerf.default | 575 | 581 | 0.99:1 |
| ChatWithPopoverPerf.default | 386 | 393 | 0.98:1 |
| LabelMinimalPerf.default | 430 | 437 | 0.98:1 |
| SliderMinimalPerf.default | 1618 | 1654 | 0.98:1 |
| IconMinimalPerf.default | 668 | 689 | 0.97:1 |
| SkeletonMinimalPerf.default | 396 | 414 | 0.96:1 |
| DropdownManyItemsPerf.default | 768 | 816 | 0.94:1 |
| FlexMinimalPerf.default | 305 | 323 | 0.94:1 |
|
🎉 Handy links: |
|
🎉 Handy links: |
2 tasks
msft-fluent-ui-bot
pushed a commit
that referenced
this pull request
Sep 10, 2021
…ndows (#19738) #### Pull request checklist - [x] Addresses an existing issue: Fixes #0000 - [x] Include a change request file using `$ yarn change` #### Description of changes In a popout window, users cannot use backspace to remove recipients. This is similar to [this ](#18428) issue that was fixed a couple of months ago. This is another component that needs this fix #### Focus areas to test (optional)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request checklist
$ yarn changeDescription of changes
Problem: when in pop out window mode, user cannot use backspace key to delete recipients
Issue: when determining whether to process the delete, unifiedpicker checks whether the input has focus. It compares against
document.activeElement. When in pop out window, the parent window drives the child window so 'document' refers to the parent document. We need to test against the child focused element.
Fix: check for focus using the event element's reference document.
Focus areas to test
Backspace key in unifiedpicker when hosted in various document environments.