Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add number-field web component #17494

Merged
merged 3 commits into from
Mar 18, 2021
Merged

feat: add number-field web component #17494

merged 3 commits into from
Mar 18, 2021

Conversation

khamudom
Copy link
Contributor

Pull request checklist

  • Addresses an existing issue: Fixes #0000
  • Include a change request file using $ yarn change

Description of changes

Added index, styles, stories, and HTML files for the number-field component.

Focus areas to test

(optional)

@khamudom khamudom force-pushed the users/khamu/add-number-field branch from 7326075 to 112684b Compare March 18, 2021 21:06
@codesandbox-ci
Copy link

codesandbox-ci bot commented Mar 18, 2021 •
edited
Loading

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 1cdf73c:

Sandbox Source
Fluent UI Button Configuration
codesandbox-react-template Configuration
codesandbox-react-northstar-template Configuration

@fabricteam
Copy link
Collaborator

fabricteam commented Mar 18, 2021 •
edited
Loading

Perf Analysis

No significant results to display.

All results

Scenario Render type Master Ticks PR Ticks Iterations Status
Avatar mount 1239 1231 5000
BaseButton mount 1002 1012 5000
Breadcrumb mount 47044 47538 5000
ButtonNext mount 1378 1402 5000
Checkbox mount 1695 1724 5000
CheckboxBase mount 1498 1459 5000
ChoiceGroup mount 5285 5192 5000
ComboBox mount 1073 1026 1000
CommandBar mount 11085 10971 1000
ContextualMenu mount 6802 6805 1000
DefaultButton mount 1210 1225 5000
DetailsRow mount 3902 3929 5000
DetailsRowFast mount 4024 3878 5000
DetailsRowNoStyles mount 3765 3735 5000
Dialog mount 1557 1574 1000
DocumentCardTitle mount 1904 1947 1000
Dropdown mount 3620 3669 5000
FocusTrapZone mount 1905 1927 5000
FocusZone mount 1918 1866 5000
IconButton mount 1968 1949 5000
Label mount 349 359 5000
Layer mount 1927 1985 5000
Link mount 510 507 5000
MakeStyles mount 2028 1982 50000
MenuButton mount 1606 1628 5000
MessageBar mount 2192 2213 5000
Nav mount 3504 3583 1000
OverflowSet mount 1127 1092 5000
Panel mount 1508 1540 1000
Persona mount 878 919 1000
Pivot mount 1543 1500 1000
PrimaryButton mount 1378 1453 5000
Rating mount 8432 8392 5000
SearchBox mount 1464 1450 5000
Shimmer mount 2815 2759 5000
Slider mount 2177 2167 5000
SpinButton mount 5391 5376 5000
Spinner mount 443 453 5000
SplitButton mount 3390 3407 5000
Stack mount 552 542 5000
StackWithIntrinsicChildren mount 1616 1618 5000
StackWithTextChildren mount 5008 5048 5000
SwatchColorPicker mount 11047 10921 5000
Tabs mount 1518 1541 1000
TagPicker mount 3065 3050 5000
TeachingBubble mount 12173 12178 5000
Text mount 463 452 5000
TextField mount 1506 1510 5000
ThemeProvider mount 1255 1295 5000
ThemeProvider virtual-rerender 628 621 5000
ThemeProviderNext mount 16469 16312 5000
Toggle mount 870 896 5000
buttonNative mount 129 127 5000

Perf Analysis (Fluent)

Perf comparison
Status Scenario Fluent TPI Fabric TPI Ratio Iterations Ticks
🦄 Avatar.Fluent 0.2 0.53 0.38:1 2000 396
🦄 Button.Fluent 0.13 0.22 0.59:1 5000 674
🔧 Checkbox.Fluent 0.71 0.39 1.82:1 1000 712
🎯 Dialog.Fluent 0.18 0.24 0.75:1 5000 912
🔧 Dropdown.Fluent 3.3 0.44 7.5:1 1000 3302
🔧 Icon.Fluent 0.15 0.07 2.14:1 5000 769
🦄 Image.Fluent 0.09 0.14 0.64:1 5000 472
🔧 Slider.Fluent 1.69 0.51 3.31:1 1000 1691
🔧 Text.Fluent 0.09 0.04 2.25:1 5000 443
🦄 Tooltip.Fluent 0.16 0.96 0.17:1 5000 780

🔧 Needs work     🎯 On target     🦄 Amazing

Perf tests with no regressions
Scenario Current PR Ticks Baseline Ticks Ratio
TreeWith60ListItems.default 223 196 1.14:1
AttachmentMinimalPerf.default 205 187 1.1:1
TableMinimalPerf.default 512 483 1.06:1
FlexMinimalPerf.default 365 346 1.05:1
ListMinimalPerf.default 618 589 1.05:1
PortalMinimalPerf.default 193 183 1.05:1
AlertMinimalPerf.default 373 359 1.04:1
AvatarMinimalPerf.default 239 229 1.04:1
LoaderMinimalPerf.default 818 785 1.04:1
MenuButtonMinimalPerf.default 1883 1813 1.04:1
RefMinimalPerf.default 273 262 1.04:1
TooltipMinimalPerf.default 1091 1052 1.04:1
ButtonUseCssPerf.default 940 911 1.03:1
ChatWithPopoverPerf.default 450 437 1.03:1
DividerMinimalPerf.default 467 453 1.03:1
GridMinimalPerf.default 423 409 1.03:1
HeaderSlotsPerf.default 946 920 1.03:1
ImageMinimalPerf.default 473 461 1.03:1
ListWith60ListItems.default 745 726 1.03:1
PopupMinimalPerf.default 806 785 1.03:1
SegmentMinimalPerf.default 436 423 1.03:1
TextAreaMinimalPerf.default 616 600 1.03:1
Text.Fluent 443 429 1.03:1
AnimationMinimalPerf.default 472 464 1.02:1
AttachmentSlotsPerf.default 1374 1342 1.02:1
ButtonSlotsPerf.default 663 650 1.02:1
CarouselMinimalPerf.default 559 548 1.02:1
DialogMinimalPerf.default 917 900 1.02:1
MenuMinimalPerf.default 1052 1031 1.02:1
TextMinimalPerf.default 432 425 1.02:1
ToolbarMinimalPerf.default 1140 1122 1.02:1
Button.Fluent 674 661 1.02:1
Image.Fluent 472 464 1.02:1
ButtonUseCssNestingPerf.default 1226 1215 1.01:1
ChatDuplicateMessagesPerf.default 336 333 1.01:1
ChatMinimalPerf.default 728 719 1.01:1
DatepickerMinimalPerf.default 52825 52436 1.01:1
DropdownManyItemsPerf.default 848 837 1.01:1
InputMinimalPerf.default 1412 1403 1.01:1
ItemLayoutMinimalPerf.default 1416 1399 1.01:1
LayoutMinimalPerf.default 498 491 1.01:1
ProviderMergeThemesPerf.default 1730 1717 1.01:1
SliderMinimalPerf.default 1717 1695 1.01:1
TableManyItemsPerf.default 2415 2387 1.01:1
CustomToolbarPrototype.default 4006 3975 1.01:1
TreeMinimalPerf.default 918 906 1.01:1
VideoMinimalPerf.default 743 737 1.01:1
Avatar.Fluent 396 393 1.01:1
Checkbox.Fluent 712 704 1.01:1
Dialog.Fluent 912 904 1.01:1
Tooltip.Fluent 780 773 1.01:1
AccordionMinimalPerf.default 182 182 1:1
BoxMinimalPerf.default 441 439 1:1
ButtonOverridesMissPerf.default 1886 1889 1:1
CardMinimalPerf.default 681 681 1:1
CheckboxMinimalPerf.default 3140 3152 1:1
FormMinimalPerf.default 521 522 1:1
LabelMinimalPerf.default 509 509 1:1
ListCommonPerf.default 770 769 1:1
RosterPerf.default 1259 1262 1:1
ProviderMinimalPerf.default 1039 1036 1:1
SkeletonMinimalPerf.default 443 445 1:1
SplitButtonMinimalPerf.default 4272 4289 1:1
StatusMinimalPerf.default 858 856 1:1
ButtonMinimalPerf.default 212 214 0.99:1
DropdownMinimalPerf.default 3323 3351 0.99:1
EmbedMinimalPerf.default 4688 4716 0.99:1
HeaderMinimalPerf.default 448 452 0.99:1
RadioGroupMinimalPerf.default 526 534 0.99:1
ReactionMinimalPerf.default 485 491 0.99:1
IconMinimalPerf.default 775 779 0.99:1
Dropdown.Fluent 3302 3326 0.99:1
Icon.Fluent 769 777 0.99:1
Slider.Fluent 1691 1713 0.99:1
ListNestedPerf.default 661 682 0.97:1

@size-auditor
Copy link

size-auditor bot commented Mar 18, 2021

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: 5c9a32661d995e224cf71db4743898b3d5c7a9f9 (build)

@chrisdholt chrisdholt merged commit 24a23e2 into microsoft:master Mar 18, 2021
@msft-fluent-ui-bot
Copy link
Collaborator

🎉@fluentui/[email protected] has been released which incorporates this pull request.:tada:

Handy links:

joshualamusga1 pushed a commit to joshualamusga1/fluentui that referenced this pull request Mar 25, 2021
@khamudom @joshualamusga1
feat: add number-field web component (microsoft#17494)
9fa4479 
* created and add number-field files

* Change files

* ran yarn build
miroslavstastny pushed a commit to miroslavstastny/fluentui that referenced this pull request May 5, 2021
@khamudom @miroslavstastny
feat: add number-field web component (microsoft#17494)
69d8cb9 
* created and add number-field files

* Change files

* ran yarn build
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chrisdholt chrisdholt chrisdholt approved these changes

@nicholasrice nicholasrice nicholasrice approved these changes

@EisenbergEffect EisenbergEffect EisenbergEffect approved these changes

Assignees

@khmakoto khmakoto

Labels
web-components
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@khamudom @fabricteam @msft-fluent-ui-bot @EisenbergEffect @nicholasrice @chrisdholt @khmakoto