New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix publishing of webpack bundles and docs #17246

Merged

msft-fluent-ui-bot merged 12 commits into microsoft:master from ecraig12345:publish-bundle

Mar 2, 2021

Member

ecraig12345 commented Mar 2, 2021

Pull request checklist

Addresses an existing issue: Fixes Could not load version 8 component API docs #17208, fixes NPM Releases missing files? #17213

Description of changes

The webpack 5 change #16447 broke bundles in production builds because the webpack CLI arg for turning on production mode has changed from --production to --mode=production. This was causing a build error, but it didn't cause the release build to fail because scripts/runPublished.js wasn't appropriately handling the exit code.

This PR fixes both issues, and switches the publish build/bundle to run using lage rather than lerna for consistency.

ecraig12345 added 6 commits

March 2, 2021 11:14


          fix runTo exit code

284617b


          fix webpack production mode setting

9827f0a


          change run:published to use lage

27a870b


          TESTING ONLY: change PR deploy to use run:published

d605863


          temporary

d1718c5


          fix formatting

ecraig12345 requested review from dzearing and xugao as code owners

March 2, 2021 19:24

msft-fluent-ui-bot assigned khmakoto

msft-fluent-ui-bot added Area: Build System Area: Documentation Priority 1: High labels

ecraig12345 removed Area: Documentation Priority 1: High labels

ecraig12345 changed the title ~~Publish bundle~~ Fix publishing of webpack bundles and docs

msft-fluent-ui-bot added Area: Documentation Priority 1: High labels

ecraig12345 added Status: Do Not Merge 🚫 and removed Priority 1: High labels

ecraig12345 commented

View reviewed changes

azure-pipelines.yml Outdated Show resolved Hide resolved

ecraig12345 requested a review from JustSlone

March 2, 2021 19:26

dzearing reviewed

View reviewed changes

scripts/tasks/webpack.ts Show resolved Hide resolved

dzearing approved these changes

View reviewed changes

Member

dzearing left a comment

Awesome work, thank you!

codesandbox-ci bot commented Mar 2, 2021 •

edited

Loading

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 4940882:

Sandbox	Source
Fluent UI Button	Configuration
codesandbox-react-template	Configuration
codesandbox-react-northstar-template	Configuration

ecraig12345 force-pushed the publish-bundle branch from f97b9b6 to eb9069c Compare

March 2, 2021 19:42


          fix --production arg application

96965be

ecraig12345 force-pushed the publish-bundle branch from eb9069c to 96965be Compare

March 2, 2021 19:42

ecraig12345 added 2 commits

March 2, 2021 11:51


          add debug log

0331e0c


          fix runPublished

1362a8e

ecraig12345 force-pushed the publish-bundle branch from c5a976d to 1362a8e Compare

March 2, 2021 20:02

Collaborator

msft-fluent-ui-bot commented Mar 3, 2021

🎉@fluentui/[email protected] has been released which incorporates this pull request.:tada:

Handy links:

Collaborator

msft-fluent-ui-bot commented Mar 3, 2021

🎉@fluentui/[email protected] has been released which incorporates this pull request.:tada:

Handy links:

Collaborator

msft-fluent-ui-bot commented Mar 3, 2021

🎉@fluentui/[email protected] has been released which incorporates this pull request.:tada:

Handy links:

Collaborator

msft-fluent-ui-bot commented Mar 3, 2021

🎉@fluentui/[email protected] has been released which incorporates this pull request.:tada:

Handy links:

Collaborator

msft-fluent-ui-bot commented Mar 3, 2021

🎉@fluentui/[email protected] has been released which incorporates this pull request.:tada:

Handy links:

Collaborator

msft-fluent-ui-bot commented Mar 3, 2021

🎉@fluentui/[email protected] has been released which incorporates this pull request.:tada:

Handy links:

Collaborator

msft-fluent-ui-bot commented Mar 3, 2021

🎉@fluentui/[email protected] has been released which incorporates this pull request.:tada:

Handy links:

Collaborator

msft-fluent-ui-bot commented Mar 3, 2021

🎉@fluentui/[email protected] has been released which incorporates this pull request.:tada:

Handy links:

Collaborator

msft-fluent-ui-bot commented Mar 3, 2021

🎉@fluentui/[email protected] has been released which incorporates this pull request.:tada:

Handy links:

Collaborator

msft-fluent-ui-bot commented Mar 3, 2021

🎉@fluentui/[email protected] has been released which incorporates this pull request.:tada:

Handy links:

Collaborator

msft-fluent-ui-bot commented Mar 3, 2021

🎉@fluentui/[email protected] has been released which incorporates this pull request.:tada:

Handy links:

Collaborator

msft-fluent-ui-bot commented Mar 3, 2021

🎉@fluentui/[email protected] has been released which incorporates this pull request.:tada:

Handy links:

Collaborator

msft-fluent-ui-bot commented Mar 3, 2021

🎉@fluentui/[email protected] has been released which incorporates this pull request.:tada:

Handy links:

Collaborator

msft-fluent-ui-bot commented Mar 3, 2021

🎉@fluentui/[email protected] has been released which incorporates this pull request.:tada:

Handy links:

Collaborator

msft-fluent-ui-bot commented Mar 3, 2021

🎉@fluentui/[email protected] has been released which incorporates this pull request.:tada:

Handy links:

Collaborator

msft-fluent-ui-bot commented Mar 3, 2021

🎉@fluentui/[email protected] has been released which incorporates this pull request.:tada:

Handy links:

Collaborator

msft-fluent-ui-bot commented Mar 3, 2021

🎉@fluentui/[email protected] has been released which incorporates this pull request.:tada:

Handy links:

Collaborator

msft-fluent-ui-bot commented Mar 3, 2021

🎉@fluentui/[email protected] has been released which incorporates this pull request.:tada:

Handy links:

Collaborator

msft-fluent-ui-bot commented Mar 3, 2021

🎉@fluentui/[email protected] has been released which incorporates this pull request.:tada:

Handy links:

Collaborator

msft-fluent-ui-bot commented Mar 3, 2021

🎉@fluentui/[email protected] has been released which incorporates this pull request.:tada:

Handy links:

Collaborator

msft-fluent-ui-bot commented Mar 3, 2021

🎉@fluentui/[email protected] has been released which incorporates this pull request.:tada:

Handy links:

Collaborator

msft-fluent-ui-bot commented Mar 3, 2021

🎉@fluentui/[email protected] has been released which incorporates this pull request.:tada:

Handy links:

Collaborator

msft-fluent-ui-bot commented Mar 3, 2021

🎉@fluentui/[email protected] has been released which incorporates this pull request.:tada:

Handy links:

Collaborator

msft-fluent-ui-bot commented Mar 3, 2021

🎉@fluentui/[email protected] has been released which incorporates this pull request.:tada:

Handy links:

Collaborator

msft-fluent-ui-bot commented Mar 3, 2021

🎉@fluentui/[email protected] has been released which incorporates this pull request.:tada:

Handy links:

Collaborator

msft-fluent-ui-bot commented Mar 3, 2021

🎉@fluentui/[email protected] has been released which incorporates this pull request.:tada:

Handy links:

Collaborator

msft-fluent-ui-bot commented Mar 3, 2021

🎉@fluentui/[email protected] has been released which incorporates this pull request.:tada:

Handy links:

Collaborator

msft-fluent-ui-bot commented Mar 3, 2021

🎉@fluentui/[email protected] has been released which incorporates this pull request.:tada:

Handy links:

Collaborator

msft-fluent-ui-bot commented Mar 3, 2021

🎉@fluentui/[email protected] has been released which incorporates this pull request.:tada:

Handy links:

joshualamusga1 pushed a commit to joshualamusga1/fluentui that referenced this pull request


          Fix publishing of webpack bundles and docs (microsoft#17246)

e85bceb

#### Pull request checklist

- [x] Addresses an existing issue: Fixes microsoft#17208, fixes microsoft#17213

#### Description of changes

The webpack 5 change microsoft#16447 broke bundles in production builds because the webpack CLI arg for turning on production mode has changed from `--production` to `--mode=production`. This was causing a build error, but it didn't cause the release build to fail because `scripts/runPublished.js` wasn't appropriately handling the exit code.

This PR fixes both issues, and switches the publish build/bundle to run using lage rather than lerna for consistency.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Area: Build System Area: Documentation AutoMerge