Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove duplicate color export from web components package #16941

Merged
merged 2 commits into from
Feb 11, 2021
Merged

remove duplicate color export from web components package #16941

merged 2 commits into from
Feb 11, 2021

Conversation

chrisdholt
Copy link
Member

Pull request checklist

  • Addresses an existing issue: Fixes #0000
  • Include a change request file using $ yarn change

Description of changes

(give an overview)

Focus areas to test

(optional)

@chrisdholt chrisdholt assigned chrisdholt and unassigned joschect Feb 11, 2021
@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit a90dbd4:

Sandbox Source
Fluent UI Button Configuration
codesandbox-react-template Configuration
codesandbox-react-northstar-template Configuration

@size-auditor
Copy link

size-auditor bot commented Feb 11, 2021

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: cadc0c0873697c2ad1139d8fcd5ffc58ed049606 (build)

@fabricteam
Copy link
Collaborator

Perf Analysis

No significant results to display.

All results

Scenario Render type Master Ticks PR Ticks Iterations Status
Avatar mount 849 821 5000
BaseButton mount 870 916 5000
Breadcrumb mount 43655 43610 5000
ButtonNext mount 661 657 5000
Checkbox mount 1481 1491 5000
CheckboxBase mount 1263 1231 5000
ChoiceGroup mount 4690 4757 5000
ComboBox mount 972 963 1000
CommandBar mount 10269 10070 1000
ContextualMenu mount 6068 6183 1000
DefaultButton mount 1121 1077 5000
DetailsRow mount 3569 3578 5000
DetailsRowFast mount 3556 3518 5000
DetailsRowNoStyles mount 3327 3402 5000
Dialog mount 1471 1383 1000
DocumentCardTitle mount 1801 1804 1000
Dropdown mount 3219 3264 5000
FocusTrapZone mount 1710 1768 5000
FocusZone mount 1742 1780 5000
IconButton mount 1704 1715 5000
Label mount 324 333 5000
Layer mount 1727 1731 5000
Link mount 442 478 5000
MakeStyles mount 1918 1923 50000
MenuButton mount 1453 1458 5000
MessageBar mount 2007 2027 5000
Nav mount 3186 3186 1000
OverflowSet mount 997 999 5000
Panel mount 1424 1377 1000
Persona mount 868 862 1000
Pivot mount 1360 1353 1000
PrimaryButton mount 1244 1191 5000
Rating mount 7317 7358 5000
SearchBox mount 1296 1279 5000
Shimmer mount 2442 2510 5000
Slider mount 1830 1833 5000
SpinButton mount 4928 4914 5000
Spinner mount 408 413 5000
SplitButton mount 3118 3096 5000
Stack mount 488 495 5000
StackWithIntrinsicChildren mount 1468 1487 5000
StackWithTextChildren mount 4326 4379 5000
SwatchColorPicker mount 10028 10057 5000
Tabs mount 1361 1350 1000
TagPicker mount 2706 2728 5000
TeachingBubble mount 11585 11460 5000
Text mount 401 387 5000
TextField mount 1368 1353 5000
ThemeProvider mount 1420 1407 5000
ThemeProvider virtual-rerender 580 590 5000
ThemeProviderNext mount 2180 2178 5000
Toggle mount 781 772 5000
buttonNative mount 115 117 5000

Perf Analysis (Fluent)

Perf comparison
Status Scenario Fluent TPI Fabric TPI Ratio Iterations Ticks
🦄 Avatar.Fluent 0.17 0.53 0.32:1 2000 344
🦄 Button.Fluent 0.12 0.2 0.6:1 5000 585
🔧 Checkbox.Fluent 0.64 0.35 1.83:1 1000 636
🎯 Dialog.Fluent 0.16 0.21 0.76:1 5000 794
🔧 Dropdown.Fluent 3.06 0.43 7.12:1 1000 3062
🔧 Icon.Fluent 0.13 0.06 2.17:1 5000 660
🦄 Image.Fluent 0.08 0.12 0.67:1 5000 390
🔧 Slider.Fluent 1.57 0.43 3.65:1 1000 1566
🔧 Text.Fluent 0.07 0.03 2.33:1 5000 363
🦄 Tooltip.Fluent 0.12 0.88 0.14:1 5000 588

🔧 Needs work     🎯 On target     🦄 Amazing

Perf tests with no regressions
Scenario Current PR Ticks Baseline Ticks Ratio
AttachmentMinimalPerf.default 188 164 1.15:1
TextMinimalPerf.default 394 348 1.13:1
AvatarMinimalPerf.default 216 197 1.1:1
RefMinimalPerf.default 259 236 1.1:1
GridMinimalPerf.default 381 350 1.09:1
PortalMinimalPerf.default 178 163 1.09:1
VideoMinimalPerf.default 665 618 1.08:1
DividerMinimalPerf.default 400 373 1.07:1
ListWith60ListItems.default 660 615 1.07:1
FlexMinimalPerf.default 309 292 1.06:1
CardMinimalPerf.default 587 557 1.05:1
ListMinimalPerf.default 554 526 1.05:1
AccordionMinimalPerf.default 173 166 1.04:1
CheckboxMinimalPerf.default 2869 2760 1.04:1
MenuButtonMinimalPerf.default 1614 1553 1.04:1
RadioGroupMinimalPerf.default 465 448 1.04:1
TreeWith60ListItems.default 181 174 1.04:1
Image.Fluent 390 374 1.04:1
ButtonUseCssNestingPerf.default 1102 1070 1.03:1
DialogMinimalPerf.default 827 803 1.03:1
ImageMinimalPerf.default 406 395 1.03:1
LayoutMinimalPerf.default 436 425 1.03:1
AttachmentSlotsPerf.default 1265 1235 1.02:1
ButtonMinimalPerf.default 187 184 1.02:1
ButtonUseCssPerf.default 828 814 1.02:1
DropdownManyItemsPerf.default 745 727 1.02:1
HeaderSlotsPerf.default 795 778 1.02:1
ProviderMergeThemesPerf.default 1646 1606 1.02:1
SegmentMinimalPerf.default 360 352 1.02:1
IconMinimalPerf.default 711 697 1.02:1
Button.Fluent 585 575 1.02:1
Tooltip.Fluent 588 574 1.02:1
AnimationMinimalPerf.default 418 413 1.01:1
BoxMinimalPerf.default 377 373 1.01:1
ButtonSlotsPerf.default 594 591 1.01:1
CarouselMinimalPerf.default 492 488 1.01:1
ChatWithPopoverPerf.default 448 445 1.01:1
DatepickerMinimalPerf.default 46784 46399 1.01:1
DropdownMinimalPerf.default 3090 3051 1.01:1
HeaderMinimalPerf.default 376 374 1.01:1
SkeletonMinimalPerf.default 386 383 1.01:1
TableManyItemsPerf.default 2079 2053 1.01:1
TreeMinimalPerf.default 807 802 1.01:1
Slider.Fluent 1566 1544 1.01:1
ButtonOverridesMissPerf.default 1691 1687 1:1
ItemLayoutMinimalPerf.default 1231 1231 1:1
LabelMinimalPerf.default 436 435 1:1
ReactionMinimalPerf.default 416 415 1:1
SliderMinimalPerf.default 1567 1564 1:1
CustomToolbarPrototype.default 3783 3800 1:1
ToolbarMinimalPerf.default 975 979 1:1
Icon.Fluent 660 659 1:1
ListNestedPerf.default 593 597 0.99:1
LoaderMinimalPerf.default 730 738 0.99:1
StatusMinimalPerf.default 748 757 0.99:1
TableMinimalPerf.default 423 427 0.99:1
TooltipMinimalPerf.default 834 840 0.99:1
Avatar.Fluent 344 348 0.99:1
Checkbox.Fluent 636 642 0.99:1
Dialog.Fluent 794 803 0.99:1
ChatDuplicateMessagesPerf.default 362 368 0.98:1
ChatMinimalPerf.default 616 630 0.98:1
EmbedMinimalPerf.default 4177 4273 0.98:1
FormMinimalPerf.default 410 419 0.98:1
MenuMinimalPerf.default 891 905 0.98:1
PopupMinimalPerf.default 709 724 0.98:1
ProviderMinimalPerf.default 935 953 0.98:1
SplitButtonMinimalPerf.default 3712 3771 0.98:1
Dropdown.Fluent 3062 3117 0.98:1
Text.Fluent 363 369 0.98:1
AlertMinimalPerf.default 301 309 0.97:1
ListCommonPerf.default 653 670 0.97:1
TextAreaMinimalPerf.default 489 502 0.97:1
InputMinimalPerf.default 1252 1307 0.96:1
RosterPerf.default 1121 1177 0.95:1

@chrisdholt chrisdholt merged commit abe6013 into microsoft:master Feb 11, 2021
@chrisdholt chrisdholt deleted the users/chhol/remove-duplicate-color-export branch February 11, 2021 01:57
@msft-fluent-ui-bot
Copy link
Collaborator

🎉@fluentui/[email protected] has been released which incorporates this pull request.:tada:

Handy links:

joshualamusga1 pushed a commit to joshualamusga1/fluentui that referenced this pull request Feb 25, 2021
@chrisdholt @joshualamusga1
remove duplicate color export from web components package (microsoft#…
b595ced 
…16941)

* remove duplicate color export from web components package

* Change files
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@scomea scomea scomea approved these changes

Assignees

@chrisdholt chrisdholt

Labels
web-components
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@chrisdholt @fabricteam @msft-fluent-ui-bot @scomea @joschect