Cherry-pick majority of react-charting fixes from v7 #16667
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* callout content ordering and line opactiy * Change files Co-authored-by: v-sivsar <[email protected]>
* Charting updates and fixes: - When `hideLegend` is true, no space is reserved for the legend - turn on `strictBindCallApply` compiler option and fix resulting errors - For VerticalStackedBarChart, support turning off hover action on legends - VerticalStackedBarChart: add minimum bar height option - VerticalStackedBarChart: add `onBarClick` callback option - VerticalStackedBarChart: simplify how data is passed to callbacks - VerticalStackedBarChart: don't output empty stack `<g>` - VerticalStackedBarChart: disallow `yMinValue` since setting it breaks the scale of the chart * fix lint error * fix bug with hovering line; make field name more descriptive * consolidate common code between focus and hover handlers * update legend examples to include onMouseOutAction * fix linter errors Co-authored-by: Michael Best <[email protected]>
* fix for exception thrown when the data of the first category is empty * Change files Co-authored-by: v-sivsar <[email protected]>
…s tooltip (microsoft#15993) * vertical bar cahrt * Change files * udpated change files * changes to area chart and line chart * added previous PR changes to 7.0 Co-authored-by: Jameela Kowsar Shaik (Zen3 Infosolutions America Inc) <[email protected]>
* changing fill to stroke, because it is a line * Change files * updated snapshots Co-authored-by: v-sivsar <[email protected]>
* HC mode for legends * Change files * email updated in change files * package change reverted * comments removed Co-authored-by: Jameela Kowsar Shaik (Zen3 Infosolutions America Inc) <[email protected]>
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit e8325d2:
|
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: 1670a00d72167ab21cbf868772f15bb46aac0bb4 (build) |
Perf AnalysisNo significant results to display. All results
Perf Analysis (Fluent)Perf comparison
Perf tests with no regressions
|
ecraig12345
approved these changes
Jan 27, 2021
|
🎉 Handy links: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-picked PRs from v7: