Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: run prettier on changed files within PR #16476

Merged
merged 1 commit into from
Jan 15, 2021
Merged

ci: run prettier on changed files within PR #16476

merged 1 commit into from
Jan 15, 2021

Conversation

Hotell
Copy link
Contributor

@Hotell Hotell commented Jan 14, 2021

Pull request checklist

Description of changes

(give an overview)

Focus areas to test

(optional)

Notes:

I didn't add this to scripts:prelint because we need to obtain target branch on CI

@fabricteam
Copy link
Collaborator

Perf Analysis

No significant results to display.

All results

Scenario Render type Master Ticks PR Ticks Iterations Status
Avatar mount 848 842 5000
BaseButtonCompat mount 913 915 5000
Breadcrumb mount 40412 41079 5000
Checkbox mount 1540 1546 5000
CheckboxBase mount 1346 1329 5000
ChoiceGroup mount 5257 4984 5000
ComboBox mount 970 1016 1000
CommandBar mount 9822 9744 1000
ContextualMenu mount 5969 5940 1000
DefaultButtonCompat mount 1147 1112 5000
DetailsRow mount 3638 3600 5000
DetailsRowFast mount 3624 3635 5000
DetailsRowNoStyles mount 3447 3396 5000
Dialog mount 1439 1508 1000
DocumentCardTitle mount 1774 1756 1000
Dropdown mount 3298 3300 5000
FocusTrapZone mount 1769 1774 5000
FocusZone mount 1777 1839 5000
IconButtonCompat mount 1808 1793 5000
Label mount 341 344 5000
Layer mount 1736 1767 5000
Link mount 471 474 5000
MakeStyles mount 1957 1966 50000
MenuButtonCompat mount 1512 1524 5000
MessageBar mount 1959 2020 5000
Nav mount 3211 3264 1000
OverflowSet mount 999 1010 5000
Panel mount 1397 1473 1000
Persona mount 845 867 1000
Pivot mount 1389 1404 1000
PrimaryButtonCompat mount 1282 1274 5000
Rating mount 7714 7710 5000
SearchBox mount 1361 1375 5000
Shimmer mount 2559 2639 5000
Slider mount 1930 1920 5000
SpinButton mount 4983 4940 5000
Spinner mount 420 430 5000
SplitButtonCompat mount 3150 3250 5000
Stack mount 510 498 5000
StackWithIntrinsicChildren mount 1543 1493 5000
StackWithTextChildren mount 4634 4707 5000
SwatchColorPicker mount 10213 10114 5000
Tabs mount 1404 1396 1000
TagPicker mount 2818 2800 5000
TeachingBubble mount 11477 11254 5000
Text mount 446 434 5000
TextField mount 1389 1379 5000
ThemeProvider mount 2058 2095 5000
ThemeProvider virtual-rerender 625 630 5000
Toggle mount 795 813 5000
button mount 708 699 5000
buttonNative mount 104 108 5000

Perf Analysis (Fluent)

Perf comparison
Status Scenario Fluent TPI Fabric TPI Ratio Iterations Ticks
🦄 Avatar.Fluent 0.18 0.51 0.35:1 2000 352
🦄 Button.Fluent 0.12 0.2 0.6:1 5000 616
🔧 Checkbox.Fluent 0.63 0.35 1.8:1 1000 625
🎯 Dialog.Fluent 0.17 0.22 0.77:1 5000 833
🔧 Dropdown.Fluent 2.87 0.41 7:1 1000 2874
🔧 Icon.Fluent 0.14 0.06 2.33:1 5000 697
🦄 Image.Fluent 0.09 0.13 0.69:1 5000 431
🔧 Slider.Fluent 1.49 0.45 3.31:1 1000 1489
🔧 Text.Fluent 0.08 0.03 2.67:1 5000 394
🦄 Tooltip.Fluent 0.11 0.86 0.13:1 5000 571

🔧 Needs work     🎯 On target     🦄 Amazing

Perf tests with no regressions
Scenario Current PR Ticks Baseline Ticks Ratio
AvatarMinimalPerf.default 225 196 1.15:1
ButtonMinimalPerf.default 213 189 1.13:1
ButtonSlotsPerf.default 624 583 1.07:1
RefMinimalPerf.default 238 225 1.06:1
IconMinimalPerf.default 721 682 1.06:1
AttachmentMinimalPerf.default 173 165 1.05:1
BoxMinimalPerf.default 408 387 1.05:1
CardMinimalPerf.default 614 583 1.05:1
FlexMinimalPerf.default 322 308 1.05:1
FormMinimalPerf.default 482 460 1.05:1
SkeletonMinimalPerf.default 412 392 1.05:1
StatusMinimalPerf.default 795 759 1.05:1
ToolbarMinimalPerf.default 1014 967 1.05:1
VideoMinimalPerf.default 701 665 1.05:1
Text.Fluent 394 376 1.05:1
CarouselMinimalPerf.default 467 449 1.04:1
ChatWithPopoverPerf.default 454 436 1.04:1
PortalMinimalPerf.default 163 157 1.04:1
ListWith60ListItems.default 656 637 1.03:1
TableMinimalPerf.default 445 433 1.03:1
CustomToolbarPrototype.default 3617 3508 1.03:1
Dialog.Fluent 833 811 1.03:1
ChatDuplicateMessagesPerf.default 374 367 1.02:1
DividerMinimalPerf.default 414 406 1.02:1
DropdownManyItemsPerf.default 765 750 1.02:1
ImageMinimalPerf.default 428 420 1.02:1
LabelMinimalPerf.default 455 446 1.02:1
MenuButtonMinimalPerf.default 1647 1622 1.02:1
PopupMinimalPerf.default 698 687 1.02:1
TooltipMinimalPerf.default 833 817 1.02:1
TreeMinimalPerf.default 829 811 1.02:1
Image.Fluent 431 422 1.02:1
Tooltip.Fluent 571 561 1.02:1
AttachmentSlotsPerf.default 1234 1224 1.01:1
ButtonUseCssPerf.default 828 821 1.01:1
ButtonUseCssNestingPerf.default 1084 1069 1.01:1
ChatMinimalPerf.default 671 662 1.01:1
CheckboxMinimalPerf.default 2831 2816 1.01:1
DatepickerMinimalPerf.default 47602 46994 1.01:1
ProviderMergeThemesPerf.default 1505 1496 1.01:1
RadioGroupMinimalPerf.default 481 474 1.01:1
ReactionMinimalPerf.default 433 428 1.01:1
SegmentMinimalPerf.default 399 394 1.01:1
TextAreaMinimalPerf.default 545 542 1.01:1
Button.Fluent 616 611 1.01:1
AccordionMinimalPerf.default 166 166 1:1
AnimationMinimalPerf.default 424 424 1:1
ButtonOverridesMissPerf.default 1657 1663 1:1
DialogMinimalPerf.default 822 818 1:1
DropdownMinimalPerf.default 2846 2858 1:1
EmbedMinimalPerf.default 4102 4116 1:1
HeaderSlotsPerf.default 845 846 1:1
InputMinimalPerf.default 1263 1261 1:1
ItemLayoutMinimalPerf.default 1286 1288 1:1
LayoutMinimalPerf.default 437 438 1:1
ListMinimalPerf.default 526 526 1:1
ListNestedPerf.default 590 590 1:1
LoaderMinimalPerf.default 731 728 1:1
SplitButtonMinimalPerf.default 3812 3818 1:1
TableManyItemsPerf.default 2204 2206 1:1
Avatar.Fluent 352 352 1:1
Dropdown.Fluent 2874 2875 1:1
GridMinimalPerf.default 377 382 0.99:1
HeaderMinimalPerf.default 408 411 0.99:1
ProviderMinimalPerf.default 882 891 0.99:1
SliderMinimalPerf.default 1529 1539 0.99:1
TextMinimalPerf.default 395 400 0.99:1
Checkbox.Fluent 625 634 0.99:1
AlertMinimalPerf.default 309 314 0.98:1
MenuMinimalPerf.default 890 904 0.98:1
TreeWith60ListItems.default 178 183 0.97:1
Slider.Fluent 1489 1542 0.97:1
ListCommonPerf.default 687 712 0.96:1
RosterPerf.default 1182 1236 0.96:1
Icon.Fluent 697 743 0.94:1

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 7bc1372:

Sandbox Source
Fluent UI Button Configuration
codesandbox-react-template Configuration
codesandbox-react-northstar-template Configuration

@size-auditor
Copy link

size-auditor bot commented Jan 14, 2021

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: 293ccd438449fe6cf99b176b5e3a141cbe62ed60 (build)

@Hotell Hotell marked this pull request as ready for review January 15, 2021 15:03
@Hotell Hotell requested a review from ecraig12345 as a code owner January 15, 2021 15:03
@Hotell Hotell merged commit 678b08a into microsoft:master Jan 15, 2021
@Hotell Hotell deleted the hotell/build-system/run-prettier-on-ci branch January 15, 2021 18:28
@Hotell Hotell mentioned this pull request Jan 15, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ecraig12345 ecraig12345 ecraig12345 approved these changes

Assignees

@layershifter layershifter

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Hotell @fabricteam @ecraig12345 @layershifter