Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix (web components): update svg fill to use currentcolor as default, change some currentColor casing #16379

Conversation

SethDonohue
Copy link
Contributor

Pull request checklist

  • Addresses an existing issue: Fixes #0000
  • Include a change request file using $ yarn change

Description of changes

Updates svgs of some components to use currentcolor as default when svg should use text color
Updates some camelCasing of currentColor to currentcolor for alignment with css property

Seth Donohue added 2 commits January 5, 2021 14:39
@codesandbox-ci
Copy link

codesandbox-ci bot commented Jan 5, 2021

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit d50a93c:

Sandbox Source
Fluent UI Button Configuration
codesandbox-react-template Configuration
codesandbox-react-northstar-template Configuration

@fabricteam
Copy link
Collaborator

Perf Analysis

No significant results to display.

All results

Scenario Render type Master Ticks PR Ticks Iterations Status
Avatar mount 851 851 5000
BaseButtonCompat mount 911 910 5000
Breadcrumb mount 41288 41473 5000
Checkbox mount 1503 1532 5000
CheckboxBase mount 1279 1299 5000
ChoiceGroup mount 4777 4788 5000
ComboBox mount 934 949 1000
CommandBar mount 9697 9827 1000
ContextualMenu mount 5871 5861 1000
DefaultButtonCompat mount 1121 1130 5000
DetailsRow mount 3607 3619 5000
DetailsRowFast mount 3630 3649 5000
DetailsRowNoStyles mount 3416 3426 5000
Dialog mount 1438 1432 1000
DocumentCardTitle mount 1712 1736 1000
Dropdown mount 3291 3322 5000
FocusTrapZone mount 1750 1761 5000
FocusZone mount 1761 1803 5000
IconButtonCompat mount 1769 1831 5000
Label mount 330 326 5000
Layer mount 1809 1769 5000
Link mount 464 460 5000
MakeStyles mount 1947 1908 50000
MenuButtonCompat mount 1464 1496 5000
MessageBar mount 2009 2132 5000
Nav mount 3305 3351 1000
OverflowSet mount 1002 1047 5000
Panel mount 1396 1417 1000
Persona mount 818 838 1000
Pivot mount 1446 1424 1000
PrimaryButtonCompat mount 1318 1270 5000
Rating mount 7870 8048 5000
SearchBox mount 1363 1417 5000
Shimmer mount 2726 2730 5000
Slider mount 1997 2092 5000
SpinButton mount 5164 5561 5000
Spinner mount 467 433 5000
SplitButtonCompat mount 3328 3377 5000
Stack mount 535 554 5000
StackWithIntrinsicChildren mount 1588 1591 5000
StackWithTextChildren mount 4873 4864 5000
SwatchColorPicker mount 10719 10652 5000
Tabs mount 1475 1507 1000
TagPicker mount 2984 2992 5000
TeachingBubble mount 12087 12017 5000
Text mount 444 438 5000
TextField mount 1525 1518 5000
ThemeProvider mount 2327 2339 5000
ThemeProvider virtual-rerender 699 688 5000
Toggle mount 910 883 5000
button mount 767 745 5000
buttonNative mount 118 127 5000

Perf Analysis (Fluent)

Perf comparison
Status Scenario Fluent TPI Fabric TPI Ratio Iterations Ticks
🎯 Avatar.Fluent 0.44 0.5 0.88:1 2000 889
🦄 Button.Fluent 0.13 0.2 0.65:1 5000 640
🔧 Checkbox.Fluent 0.64 0.37 1.73:1 1000 641
🎯 Dialog.Fluent 0.16 0.21 0.76:1 5000 817
🔧 Dropdown.Fluent 2.89 0.41 7.05:1 1000 2890
🔧 Icon.Fluent 0.15 0.06 2.5:1 5000 763
🦄 Image.Fluent 0.08 0.13 0.62:1 5000 403
🔧 Slider.Fluent 1.53 0.44 3.48:1 1000 1532
🔧 Text.Fluent 0.08 0.03 2.67:1 5000 400
🦄 Tooltip.Fluent 0.11 0.86 0.13:1 5000 560

🔧 Needs work     🎯 On target     🦄 Amazing

Perf tests with no regressions
Scenario Current PR Ticks Baseline Ticks Ratio
AttachmentMinimalPerf.default 190 173 1.1:1
FlexMinimalPerf.default 348 316 1.1:1
VideoMinimalPerf.default 713 649 1.1:1
SegmentMinimalPerf.default 423 390 1.08:1
AttachmentSlotsPerf.default 1254 1176 1.07:1
ButtonMinimalPerf.default 202 188 1.07:1
LoaderMinimalPerf.default 775 725 1.07:1
Button.Fluent 640 599 1.07:1
LabelMinimalPerf.default 489 467 1.05:1
ListNestedPerf.default 641 608 1.05:1
PopupMinimalPerf.default 735 701 1.05:1
RefMinimalPerf.default 247 236 1.05:1
IconMinimalPerf.default 737 705 1.05:1
ButtonUseCssNestingPerf.default 1121 1080 1.04:1
CardMinimalPerf.default 643 618 1.04:1
CarouselMinimalPerf.default 493 472 1.04:1
ChatMinimalPerf.default 671 646 1.04:1
DropdownManyItemsPerf.default 783 753 1.04:1
GridMinimalPerf.default 393 377 1.04:1
SkeletonMinimalPerf.default 416 401 1.04:1
TextAreaMinimalPerf.default 556 537 1.04:1
AvatarMinimalPerf.default 506 490 1.03:1
HeaderSlotsPerf.default 855 829 1.03:1
ImageMinimalPerf.default 441 427 1.03:1
PortalMinimalPerf.default 160 156 1.03:1
TableMinimalPerf.default 457 442 1.03:1
TextMinimalPerf.default 397 386 1.03:1
ToolbarMinimalPerf.default 997 972 1.03:1
Checkbox.Fluent 641 622 1.03:1
Text.Fluent 400 387 1.03:1
ButtonUseCssPerf.default 869 850 1.02:1
ChatDuplicateMessagesPerf.default 427 419 1.02:1
DividerMinimalPerf.default 430 422 1.02:1
HeaderMinimalPerf.default 420 410 1.02:1
ItemLayoutMinimalPerf.default 1333 1304 1.02:1
LayoutMinimalPerf.default 451 442 1.02:1
SliderMinimalPerf.default 1566 1528 1.02:1
SplitButtonMinimalPerf.default 3965 3880 1.02:1
StatusMinimalPerf.default 795 778 1.02:1
TableManyItemsPerf.default 2266 2212 1.02:1
TreeWith60ListItems.default 206 202 1.02:1
Avatar.Fluent 889 873 1.02:1
Dialog.Fluent 817 798 1.02:1
Dropdown.Fluent 2890 2845 1.02:1
AlertMinimalPerf.default 348 343 1.01:1
ButtonSlotsPerf.default 642 633 1.01:1
CheckboxMinimalPerf.default 2933 2896 1.01:1
DatepickerMinimalPerf.default 47873 47509 1.01:1
MenuMinimalPerf.default 934 925 1.01:1
ReactionMinimalPerf.default 454 450 1.01:1
CustomToolbarPrototype.default 3626 3592 1.01:1
TreeMinimalPerf.default 816 811 1.01:1
Icon.Fluent 763 752 1.01:1
Tooltip.Fluent 560 552 1.01:1
AnimationMinimalPerf.default 464 464 1:1
BoxMinimalPerf.default 414 415 1:1
DropdownMinimalPerf.default 2962 2971 1:1
FormMinimalPerf.default 486 484 1:1
InputMinimalPerf.default 1320 1319 1:1
ListCommonPerf.default 709 712 1:1
ListWith60ListItems.default 957 959 1:1
TooltipMinimalPerf.default 826 827 1:1
ButtonOverridesMissPerf.default 1732 1758 0.99:1
DialogMinimalPerf.default 843 849 0.99:1
EmbedMinimalPerf.default 4231 4268 0.99:1
ProviderMinimalPerf.default 912 924 0.99:1
RadioGroupMinimalPerf.default 483 490 0.99:1
Slider.Fluent 1532 1548 0.99:1
ChatWithPopoverPerf.default 478 486 0.98:1
ListMinimalPerf.default 534 546 0.98:1
MenuButtonMinimalPerf.default 1659 1686 0.98:1
ProviderMergeThemesPerf.default 1524 1554 0.98:1
AccordionMinimalPerf.default 180 185 0.97:1
Image.Fluent 403 416 0.97:1

@size-auditor
Copy link

size-auditor bot commented Jan 5, 2021

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: d0d59e633912d2fe72a48e1472afe220a74a51d0 (build)

@chrisdholt chrisdholt merged commit 4e7e485 into microsoft:master Jan 11, 2021
@msft-fluent-ui-bot
Copy link
Collaborator

🎉@fluentui/[email protected] has been released which incorporates this pull request.:tada:

Handy links:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants