fix: update style on aria-current item and adjust margin on last item

[khamudom]

Pull request checklist

• Addresses an existing issue: Fixes #0000
• Include a change request file using $ yarn change

Description of changes

Updated the style on the aria-current item to look like the no href item.
The margin on the no href item was also removed.

Focus areas to test

(optional)

[chrisdholt]

@khamudom you need a yarn change file here :)

Thanks!

[codesandbox-ci]

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 291dd1d:

Sandbox	Source
Fluent UI Button	Configuration
codesandbox-react-template	Configuration
codesandbox-react-northstar-template	Configuration

[fabricteam]

Perf Analysis

No significant results to display.

All results

Scenario	Render type	Master Ticks	PR Ticks	Iterations	Status
Avatar	mount	818	840	5000
BaseButtonCompat	mount	898	875	5000
Breadcrumb	mount	42964	43360	5000
Checkbox	mount	1506	1497	5000
CheckboxBase	mount	1265	1245	5000
ChoiceGroup	mount	4817	4756	5000
ComboBox	mount	973	972	1000
CommandBar	mount	10223	10209	1000
ContextualMenu	mount	6174	6216	1000
DefaultButtonCompat	mount	1153	1141	5000
DetailsRow	mount	3691	3732	5000
DetailsRowFast	mount	3728	3591	5000
DetailsRowNoStyles	mount	3573	3494	5000
Dialog	mount	1482	1495	1000
DocumentCardTitle	mount	1911	1802	1000
Dropdown	mount	3355	3409	5000
FocusTrapZone	mount	1889	1854	5000
FocusZone	mount	1860	1882	5000
IconButtonCompat	mount	1739	1751	5000
Label	mount	336	333	5000
Layer	mount	1744	1785	5000
Link	mount	462	482	5000
MenuButtonCompat	mount	1452	1502	5000
MessageBar	mount	2025	2001	5000
Nav	mount	3282	3312	1000
OverflowSet	mount	1041	1091	5000
Panel	mount	1433	1407	1000
Persona	mount	874	870	1000
Pivot	mount	1422	1463	1000
PrimaryButtonCompat	mount	1289	1265	5000
Rating	mount	7554	7580	5000
SearchBox	mount	1294	1297	5000
Shimmer	mount	2646	2581	5000
Slider	mount	1911	1950	5000
SpinButton	mount	5072	5003	5000
Spinner	mount	431	434	5000
SplitButtonCompat	mount	3126	3146	5000
Stack	mount	472	499	5000
StackWithIntrinsicChildren	mount	1502	1531	5000
StackWithTextChildren	mount	4535	4441	5000
SwatchColorPicker	mount	10260	10413	5000
Tabs	mount	1433	1400	1000
TagPicker	mount	2813	2830	5000
TeachingBubble	mount	11742	11688	5000
Text	mount	417	418	5000
TextField	mount	1369	1407	5000
ThemeProvider	mount	2163	2195	5000
ThemeProvider	virtual-rerender	661	667	5000
Toggle	mount	792	816	5000
button	mount	642	666	5000
buttonNative	mount	106	108	5000

Perf Analysis (Fluent)

Perf comparison

Status	Scenario	Fluent TPI	Fabric TPI	Ratio	Iterations	Ticks
🎯	Avatar.Fluent	0.43	0.51	0.84:1	2000	860
🦄	Button.Fluent	0.12	0.2	0.6:1	5000	577
🔧	Checkbox.Fluent	0.64	0.36	1.78:1	1000	643
🎯	Dialog.Fluent	0.16	0.22	0.73:1	5000	812
🔧	Dropdown.Fluent	3.03	0.41	7.39:1	1000	3033
🔧	Icon.Fluent	0.14	0.06	2.33:1	5000	720
🦄	Image.Fluent	0.08	0.12	0.67:1	5000	416
🔧	Slider.Fluent	1.63	0.44	3.7:1	1000	1629
🔧	Text.Fluent	0.08	0.03	2.67:1	5000	384
🦄	Tooltip.Fluent	0.11	0.9	0.12:1	5000	574

🔧 Needs work     🎯 On target     🦄 Amazing

Perf tests with no regressions

Scenario	Current PR Ticks	Baseline Ticks	Ratio
ButtonMinimalPerf.default	206	188	1.1:1
GridMinimalPerf.default	381	358	1.06:1
RefMinimalPerf.default	259	244	1.06:1
IconMinimalPerf.default	723	679	1.06:1
Image.Fluent	416	391	1.06:1
DropdownManyItemsPerf.default	780	742	1.05:1
Text.Fluent	384	366	1.05:1
AlertMinimalPerf.default	322	310	1.04:1
ButtonOverridesMissPerf.default	1760	1690	1.04:1
ButtonUseCssPerf.default	862	831	1.04:1
DividerMinimalPerf.default	392	377	1.04:1
FlexMinimalPerf.default	333	320	1.04:1
StatusMinimalPerf.default	775	742	1.04:1
AccordionMinimalPerf.default	161	157	1.03:1
BoxMinimalPerf.default	379	367	1.03:1
ButtonSlotsPerf.default	615	597	1.03:1
ImageMinimalPerf.default	413	400	1.03:1
PopupMinimalPerf.default	731	713	1.03:1
TextMinimalPerf.default	377	365	1.03:1
Dialog.Fluent	812	791	1.03:1
HeaderSlotsPerf.default	806	794	1.02:1
ListCommonPerf.default	694	678	1.02:1
ListNestedPerf.default	579	570	1.02:1
ReactionMinimalPerf.default	425	418	1.02:1
AnimationMinimalPerf.default	418	412	1.01:1
AttachmentMinimalPerf.default	174	172	1.01:1
ChatDuplicateMessagesPerf.default	436	431	1.01:1
DatepickerMinimalPerf.default	47676	47247	1.01:1
EmbedMinimalPerf.default	4196	4165	1.01:1
InputMinimalPerf.default	1311	1304	1.01:1
ItemLayoutMinimalPerf.default	1314	1297	1.01:1
PortalMinimalPerf.default	187	186	1.01:1
RadioGroupMinimalPerf.default	461	458	1.01:1
SkeletonMinimalPerf.default	449	445	1.01:1
SliderMinimalPerf.default	1598	1579	1.01:1
SplitButtonMinimalPerf.default	3800	3765	1.01:1
TooltipMinimalPerf.default	850	839	1.01:1
Slider.Fluent	1629	1613	1.01:1
Tooltip.Fluent	574	566	1.01:1
AttachmentSlotsPerf.default	1148	1143	1:1
AvatarMinimalPerf.default	488	487	1:1
ChatWithPopoverPerf.default	473	471	1:1
DialogMinimalPerf.default	800	801	1:1
HeaderMinimalPerf.default	386	387	1:1
ProviderMinimalPerf.default	1049	1045	1:1
TableManyItemsPerf.default	2164	2171	1:1
TableMinimalPerf.default	432	433	1:1
CustomToolbarPrototype.default	3984	3995	1:1
VideoMinimalPerf.default	674	677	1:1
Button.Fluent	577	575	1:1
Checkbox.Fluent	643	645	1:1
Icon.Fluent	720	720	1:1
ButtonUseCssNestingPerf.default	1081	1097	0.99:1
CheckboxMinimalPerf.default	2859	2899	0.99:1
LoaderMinimalPerf.default	727	732	0.99:1
MenuMinimalPerf.default	883	894	0.99:1
Dropdown.Fluent	3033	3050	0.99:1
CardMinimalPerf.default	573	582	0.98:1
ChatMinimalPerf.default	641	654	0.98:1
FormMinimalPerf.default	429	439	0.98:1
LabelMinimalPerf.default	441	449	0.98:1
LayoutMinimalPerf.default	422	432	0.98:1
ListMinimalPerf.default	501	513	0.98:1
ProviderMergeThemesPerf.default	2147	2200	0.98:1
SegmentMinimalPerf.default	378	384	0.98:1
TreeWith60ListItems.default	210	214	0.98:1
DropdownMinimalPerf.default	3005	3092	0.97:1
MenuButtonMinimalPerf.default	1594	1640	0.97:1
ToolbarMinimalPerf.default	969	997	0.97:1
TreeMinimalPerf.default	775	796	0.97:1
TextAreaMinimalPerf.default	477	496	0.96:1
ListWith60ListItems.default	921	966	0.95:1
Avatar.Fluent	860	909	0.95:1
CarouselMinimalPerf.default	452	488	0.93:1

[size-auditor]

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: 1ea9d474cf3b39f546f7ea3996edf29e4a862b9a (build)

[msft-fluent-ui-bot]

🎉@fluentui/[email protected] has been released which incorporates this pull request.:tada:

Handy links:

• Release Notes
• Official NPM Release