feat(makeStyles): add an ability to increase specificity #16232
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -1,7 +1,17 @@ | |||
| import { compile, middleware, serialize, stringify } from 'stylis'; | |||
| import { hyphenateProperty } from './utils/hyphenateProperty'; | |||
|
|
|||
| export function compileCSS(className: string, selector: string, property: string, value: number | string): string { | |||
| function repeatSelector(selector: string, times: number) { | |||
| return new Array(times + 2).join(selector); | |||
miroslavstastny
approved these changes
Dec 15, 2020
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 6496b18:
|
xugao
approved these changes
Dec 15, 2020
Perf AnalysisNo significant results to display. All results
Perf Analysis (Fluent)Perf comparison
Perf tests with no regressions
|
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: 81651e8f3c1ea57df77214a50eb47fe5a816a236 (build) |
layershifter
changed the title
layershifter
force-pushed
the
feat/make-styles-specifity-enhancer
branch
from
7c06620 to
611b165
Compare
|
🎉 Handy links: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
😕Problem
With atomic classes in Northstar components it's impossible to use
makeStylesfor overrides as Fela produces also atomic classes for us. The idea of implementation is taken from robinweser/fela#827.unstable_cssPriorityis added tomakeStyles, however it should be not present in framework (React) specific implementation.For example, it will output:
This allows overrides to win over Fela classes due higher specificity.