Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update FAST packages to latest minor versions #16012

Merged
merged 1 commit into from
Nov 20, 2020
Merged

Update FAST packages to latest minor versions #16012

merged 1 commit into from
Nov 20, 2020

Conversation

chrisdholt
Copy link
Member

Pull request checklist

  • Addresses an existing issue: Fixes #0000
  • Include a change request file using $ yarn change

Description of changes

Updates FAST packages to latest minor versions.

@chrisdholt chrisdholt self-assigned this Nov 19, 2020
@codesandbox-ci
Copy link

codesandbox-ci bot commented Nov 19, 2020 •
edited
Loading

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit d98f632:

Sandbox Source
Fluent UI Button Configuration
codesandbox-react-template Configuration
codesandbox-react-northstar-template Configuration

@msft-github-bot
Copy link
Contributor

msft-github-bot commented Nov 19, 2020 •
edited
Loading

Perf Analysis

No significant results to display.

All results

Scenario Render type Master Ticks PR Ticks Iterations Status
Avatar mount 813 879 5000
BaseButtonCompat mount 913 964 5000
Breadcrumb mount 43534 43421 5000
Checkbox mount 1545 1505 5000
CheckboxBase mount 1304 1372 5000
ChoiceGroup mount 4693 4755 5000
ComboBox mount 993 959 1000
CommandBar mount 10217 10367 1000
ContextualMenu mount 6273 6156 1000
DefaultButtonCompat mount 1174 1136 5000
DetailsRow mount 3698 3723 5000
DetailsRowFast mount 3729 3694 5000
DetailsRowNoStyles mount 3333 3600 5000
Dialog mount 1507 1476 1000
DocumentCardTitle mount 1826 1801 1000
Dropdown mount 3339 3375 5000
FocusTrapZone mount 1886 1803 5000
FocusZone mount 1839 1978 5000
IconButtonCompat mount 1787 1741 5000
Label mount 336 334 5000
Layer mount 1803 1779 5000
Link mount 492 460 5000
MenuButtonCompat mount 1476 1492 5000
MessageBar mount 2045 2058 5000
Nav mount 3362 3247 1000
OverflowSet mount 1055 1054 5000
Panel mount 1428 1402 1000
Persona mount 865 848 1000
Pivot mount 1383 1373 1000
PrimaryButtonCompat mount 1285 1284 5000
Rating mount 7498 7554 5000
SearchBox mount 1312 1300 5000
Shimmer mount 2541 2543 5000
Slider mount 1938 1991 5000
SpinButton mount 5087 5112 5000
Spinner mount 428 414 5000
SplitButtonCompat mount 3200 3276 5000
Stack mount 499 497 5000
StackWithIntrinsicChildren mount 1504 1567 5000
StackWithTextChildren mount 4529 4494 5000
SwatchColorPicker mount 10563 10340 5000
Tabs mount 1470 1422 1000
TagPicker mount 2857 2768 5000
TeachingBubble mount 11667 11601 5000
Text mount 430 396 5000
TextField mount 1344 1382 5000
ThemeProvider mount 2006 2019 5000
ThemeProvider virtual-rerender 679 643 5000
Toggle mount 793 844 5000
button mount 704 699 5000
buttonNative mount 117 113 5000

Perf Analysis (Fluent)

Perf comparison
Status Scenario Fluent TPI Fabric TPI Ratio Iterations Ticks
🎯 Avatar.Fluent 0.43 0.51 0.84:1 2000 868
🦄 Button.Fluent 0.12 0.23 0.52:1 5000 590
🔧 Checkbox.Fluent 0.66 0.36 1.83:1 1000 657
🎯 Dialog.Fluent 0.17 0.22 0.77:1 5000 831
🔧 Dropdown.Fluent 3.01 0.41 7.34:1 1000 3012
🔧 Icon.Fluent 0.15 0.06 2.5:1 5000 737
🦄 Image.Fluent 0.08 0.13 0.62:1 5000 398
🔧 Slider.Fluent 1.63 0.45 3.62:1 1000 1625
🔧 Text.Fluent 0.08 0.04 2:1 5000 389
🦄 Tooltip.Fluent 0.12 0.89 0.13:1 5000 597

🔧 Needs work     🎯 On target     🦄 Amazing

Perf tests with no regressions
Scenario Current PR Ticks Baseline Ticks Ratio
AccordionMinimalPerf.default 182 163 1.12:1
FormMinimalPerf.default 456 420 1.09:1
ReactionMinimalPerf.default 457 421 1.09:1
ButtonMinimalPerf.default 190 178 1.07:1
ListCommonPerf.default 677 641 1.06:1
VideoMinimalPerf.default 683 644 1.06:1
GridMinimalPerf.default 368 350 1.05:1
ItemLayoutMinimalPerf.default 1343 1279 1.05:1
MenuMinimalPerf.default 942 898 1.05:1
CarouselMinimalPerf.default 494 476 1.04:1
ChatWithPopoverPerf.default 509 488 1.04:1
DividerMinimalPerf.default 412 397 1.04:1
ListNestedPerf.default 596 574 1.04:1
LoaderMinimalPerf.default 785 752 1.04:1
RadioGroupMinimalPerf.default 484 465 1.04:1
ToolbarMinimalPerf.default 1008 973 1.04:1
Icon.Fluent 737 708 1.04:1
ButtonUseCssNestingPerf.default 1167 1135 1.03:1
DropdownManyItemsPerf.default 789 767 1.03:1
EmbedMinimalPerf.default 4254 4134 1.03:1
FlexMinimalPerf.default 325 316 1.03:1
LayoutMinimalPerf.default 427 416 1.03:1
RefMinimalPerf.default 253 246 1.03:1
TableMinimalPerf.default 430 417 1.03:1
Dialog.Fluent 831 808 1.03:1
Tooltip.Fluent 597 581 1.03:1
AnimationMinimalPerf.default 434 427 1.02:1
DialogMinimalPerf.default 845 829 1.02:1
DropdownMinimalPerf.default 3036 2963 1.02:1
ListMinimalPerf.default 511 501 1.02:1
StatusMinimalPerf.default 775 761 1.02:1
Checkbox.Fluent 657 642 1.02:1
Slider.Fluent 1625 1600 1.02:1
Text.Fluent 389 380 1.02:1
CheckboxMinimalPerf.default 2947 2912 1.01:1
LabelMinimalPerf.default 427 423 1.01:1
SkeletonMinimalPerf.default 440 437 1.01:1
SplitButtonMinimalPerf.default 3843 3788 1.01:1
TextAreaMinimalPerf.default 503 497 1.01:1
TooltipMinimalPerf.default 859 853 1.01:1
Button.Fluent 590 582 1.01:1
CardMinimalPerf.default 562 562 1:1
ChatMinimalPerf.default 656 656 1:1
DatepickerMinimalPerf.default 48637 48769 1:1
ProviderMergeThemesPerf.default 2122 2120 1:1
ProviderMinimalPerf.default 1045 1043 1:1
CustomToolbarPrototype.default 4031 4044 1:1
TreeMinimalPerf.default 926 923 1:1
TreeWith60ListItems.default 210 209 1:1
Dropdown.Fluent 3012 3012 1:1
Image.Fluent 398 398 1:1
AlertMinimalPerf.default 304 307 0.99:1
ButtonOverridesMissPerf.default 1730 1740 0.99:1
InputMinimalPerf.default 1325 1333 0.99:1
PortalMinimalPerf.default 166 167 0.99:1
IconMinimalPerf.default 674 683 0.99:1
TableManyItemsPerf.default 2208 2222 0.99:1
TextMinimalPerf.default 373 376 0.99:1
AttachmentSlotsPerf.default 1155 1181 0.98:1
AvatarMinimalPerf.default 511 522 0.98:1
ButtonUseCssPerf.default 830 850 0.98:1
HeaderMinimalPerf.default 405 414 0.98:1
ImageMinimalPerf.default 389 395 0.98:1
ListWith60ListItems.default 948 969 0.98:1
MenuButtonMinimalPerf.default 1593 1628 0.98:1
SliderMinimalPerf.default 1574 1612 0.98:1
BoxMinimalPerf.default 385 396 0.97:1
PopupMinimalPerf.default 721 755 0.95:1
Avatar.Fluent 868 911 0.95:1
ChatDuplicateMessagesPerf.default 421 449 0.94:1
AttachmentMinimalPerf.default 156 168 0.93:1
HeaderSlotsPerf.default 795 853 0.93:1
ButtonSlotsPerf.default 598 651 0.92:1
SegmentMinimalPerf.default 374 416 0.9:1

@size-auditor
Copy link

size-auditor bot commented Nov 20, 2020 •
edited
Loading

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: cfd0cc90fb22c5d24d9646b7eb325c7a41bd6c68 (build)

@chrisdholt chrisdholt force-pushed the users/chhol/update-fast-package-dependencies branch 2 times, most recently from e90c0b8 to 75482c1 Compare November 20, 2020 20:34
@chrisdholt chrisdholt force-pushed the users/chhol/update-fast-package-dependencies branch from 75482c1 to d98f632 Compare November 20, 2020 20:55
@chrisdholt chrisdholt merged commit 2b7e562 into microsoft:master Nov 20, 2020
@msft-github-bot
Copy link
Contributor

🎉@fluentui/[email protected] has been released which incorporates this pull request.:tada:

Handy links:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@khamudom khamudom khamudom approved these changes

@janechu janechu janechu approved these changes

Assignees

@chrisdholt chrisdholt

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@chrisdholt @msft-github-bot @janechu @khamudom