Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

flipper cursor should be pointer on hover #15824

Merged
merged 2 commits into from
Nov 4, 2020
Merged

flipper cursor should be pointer on hover #15824

merged 2 commits into from
Nov 4, 2020

Conversation

chrisdholt
Copy link
Member

Pull request checklist

  • Addresses an existing issue: Fixes #0000
  • Include a change request file using $ yarn change

Description of changes

(give an overview)

Focus areas to test

(optional)

@chrisdholt chrisdholt self-assigned this Nov 3, 2020
@codesandbox-ci
Copy link

codesandbox-ci bot commented Nov 3, 2020 •
edited
Loading

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit d0372a1:

Sandbox Source
Fluent UI Button Configuration
codesandbox-react-template Configuration
codesandbox-react-northstar-template Configuration

@msft-github-bot
Copy link
Contributor

msft-github-bot commented Nov 3, 2020 •
edited
Loading

Perf Analysis

No significant results to display.

All results

Scenario Render type Master Ticks PR Ticks Iterations Status
Avatar mount 882 844 5000
BaseButtonCompat mount 934 952 5000
Breadcrumb mount 44218 43192 5000
Checkbox mount 1627 1664 5000
CheckboxBase mount 1373 1390 5000
ChoiceGroup mount 5205 5092 5000
ComboBox mount 1028 1050 1000
CommandBar mount 10607 10702 1000
ContextualMenu mount 6208 6369 1000
DefaultButtonCompat mount 1167 1180 5000
DetailsRow mount 3699 3664 5000
DetailsRowFast mount 3881 3722 5000
DetailsRowNoStyles mount 3527 3668 5000
Dialog mount 1536 1510 1000
DocumentCardTitle mount 1776 1831 1000
Dropdown mount 3538 3479 5000
FocusTrapZone mount 1816 1811 5000
FocusZone mount 1765 1798 5000
IconButtonCompat mount 1831 1847 5000
Label mount 340 345 5000
Layer mount 1811 1830 5000
Link mount 466 480 5000
MenuButtonCompat mount 1558 1537 5000
MessageBar mount 1993 1971 5000
Nav mount 3330 3328 1000
OverflowSet mount 1053 1058 5000
Panel mount 1453 1450 1000
Persona mount 867 863 1000
Pivot mount 1421 1440 1000
PrimaryButtonCompat mount 1315 1324 5000
Rating mount 7895 7834 5000
SearchBox mount 1362 1371 5000
Shimmer mount 2735 2705 5000
Slider mount 2008 2006 5000
SpinButton mount 5401 5153 5000
Spinner mount 454 435 5000
SplitButtonCompat mount 3378 3423 5000
Stack mount 548 544 5000
StackWithIntrinsicChildren mount 1616 1587 5000
StackWithTextChildren mount 4988 4955 5000
SwatchColorPicker mount 10715 10805 5000
Tabs mount 1462 1496 1000
TagPicker mount 2891 2983 5000
TeachingBubble mount 11668 11926 5000
Text mount 449 448 5000
TextField mount 1440 1419 5000
ThemeProvider mount 2115 2026 5000
ThemeProvider virtual-rerender 694 711 5000
Toggle mount 858 874 5000
button mount 581 596 5000
buttonNative mount 110 110 5000

Perf Analysis (Fluent)

Perf comparison
Status Scenario Fluent TPI Fabric TPI Ratio Iterations Ticks
🎯 Avatar.Fluent 0.48 0.52 0.92:1 2000 951
🦄 Button.Fluent 0.13 0.26 0.5:1 5000 636
🔧 Checkbox.Fluent 0.67 0.36 1.86:1 1000 667
🎯 Dialog.Fluent 0.17 0.23 0.74:1 5000 853
🔧 Dropdown.Fluent 2.98 0.43 6.93:1 1000 2978
🔧 Icon.Fluent 0.16 0.06 2.67:1 5000 796
🦄 Image.Fluent 0.09 0.13 0.69:1 5000 462
🔧 Slider.Fluent 1.63 0.48 3.4:1 1000 1629
🔧 Text.Fluent 0.08 0.04 2:1 5000 409
🦄 Tooltip.Fluent 0.12 0.92 0.13:1 5000 580

🔧 Needs work     🎯 On target     🦄 Amazing

Perf tests with no regressions
Scenario Current PR Ticks Baseline Ticks Ratio
ButtonMinimalPerf.default 210 190 1.11:1
FlexMinimalPerf.default 352 317 1.11:1
PortalMinimalPerf.default 180 164 1.1:1
ImageMinimalPerf.default 467 433 1.08:1
TableMinimalPerf.default 473 439 1.08:1
TreeWith60ListItems.default 236 219 1.08:1
FormMinimalPerf.default 488 458 1.07:1
TextMinimalPerf.default 422 394 1.07:1
AttachmentMinimalPerf.default 187 176 1.06:1
TextAreaMinimalPerf.default 604 568 1.06:1
ChatWithPopoverPerf.default 524 501 1.05:1
DividerMinimalPerf.default 462 442 1.05:1
ListCommonPerf.default 757 721 1.05:1
ListNestedPerf.default 661 629 1.05:1
RefMinimalPerf.default 251 240 1.05:1
ToolbarMinimalPerf.default 1061 1015 1.05:1
AnimationMinimalPerf.default 443 427 1.04:1
AvatarMinimalPerf.default 534 513 1.04:1
BoxMinimalPerf.default 426 410 1.04:1
DropdownManyItemsPerf.default 827 796 1.04:1
GridMinimalPerf.default 417 400 1.04:1
SkeletonMinimalPerf.default 499 481 1.04:1
IconMinimalPerf.default 765 738 1.04:1
TableManyItemsPerf.default 2463 2360 1.04:1
Image.Fluent 462 444 1.04:1
LabelMinimalPerf.default 485 471 1.03:1
RadioGroupMinimalPerf.default 499 486 1.03:1
SliderMinimalPerf.default 1664 1619 1.03:1
Checkbox.Fluent 667 649 1.03:1
Dialog.Fluent 853 827 1.03:1
Text.Fluent 409 399 1.03:1
ButtonUseCssPerf.default 937 917 1.02:1
ButtonUseCssNestingPerf.default 1195 1175 1.02:1
EmbedMinimalPerf.default 2102 2061 1.02:1
HeaderMinimalPerf.default 428 420 1.02:1
ItemLayoutMinimalPerf.default 1460 1428 1.02:1
ProviderMinimalPerf.default 1054 1035 1.02:1
TooltipMinimalPerf.default 860 847 1.02:1
Avatar.Fluent 951 933 1.02:1
Tooltip.Fluent 580 566 1.02:1
ChatDuplicateMessagesPerf.default 467 463 1.01:1
DialogMinimalPerf.default 896 888 1.01:1
InputMinimalPerf.default 1379 1365 1.01:1
ListWith60ListItems.default 986 976 1.01:1
MenuButtonMinimalPerf.default 1770 1746 1.01:1
SegmentMinimalPerf.default 431 426 1.01:1
SplitButtonMinimalPerf.default 4069 4031 1.01:1
CustomToolbarPrototype.default 3950 3894 1.01:1
VideoMinimalPerf.default 730 723 1.01:1
Dropdown.Fluent 2978 2952 1.01:1
Icon.Fluent 796 787 1.01:1
CardMinimalPerf.default 650 652 1:1
ChatMinimalPerf.default 727 726 1:1
DropdownMinimalPerf.default 3010 3003 1:1
ListMinimalPerf.default 548 547 1:1
MenuMinimalPerf.default 994 990 1:1
ProviderMergeThemesPerf.default 2063 2068 1:1
StatusMinimalPerf.default 831 831 1:1
TreeMinimalPerf.default 944 948 1:1
Button.Fluent 636 633 1:1
Slider.Fluent 1629 1630 1:1
AttachmentSlotsPerf.default 1215 1222 0.99:1
ButtonOverridesMissPerf.default 1778 1797 0.99:1
ButtonSlotsPerf.default 669 679 0.99:1
LayoutMinimalPerf.default 458 462 0.99:1
PopupMinimalPerf.default 734 738 0.99:1
CheckboxMinimalPerf.default 3040 3107 0.98:1
HeaderSlotsPerf.default 887 902 0.98:1
AlertMinimalPerf.default 321 333 0.96:1
CarouselMinimalPerf.default 507 533 0.95:1
LoaderMinimalPerf.default 764 811 0.94:1
ReactionMinimalPerf.default 442 474 0.93:1
AccordionMinimalPerf.default 162 178 0.91:1

@size-auditor
Copy link

size-auditor bot commented Nov 3, 2020 •
edited
Loading

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: d493a6be6b5c0ee1c7224be9e2b9247400b627f9 (build)

@chrisdholt chrisdholt force-pushed the users/chhol/flipper-on-hover-should-be-pointer branch from 8f75ec7 to d0372a1 Compare November 4, 2020 19:22
@chrisdholt chrisdholt merged commit 70498e1 into microsoft:master Nov 4, 2020
@msft-github-bot
Copy link
Contributor

🎉@fluentui/[email protected] has been released which incorporates this pull request.:tada:

Handy links:

SethDonohue pushed a commit to SethDonohue/fluentui that referenced this pull request Nov 23, 2020
@chrisdholt
flipper cursor should be pointer on hover (microsoft#15824)
6708633 
* flipper cursor should be pointer on hover

* Change files
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bheston bheston bheston approved these changes

Assignees

@chrisdholt chrisdholt

Labels
web-components
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@chrisdholt @msft-github-bot @bheston @behowell