Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Charting: Adding tests for StackedBarChart and MultiStackedBarChart #15708

Merged
merged 2 commits into from
Oct 27, 2020
Merged

Charting: Adding tests for StackedBarChart and MultiStackedBarChart #15708

merged 2 commits into from
Oct 27, 2020

Conversation

khmakoto
Copy link
Member

Pull request checklist

Description of changes

Cherry-pick of #15578.

Original PR description:

Added snapshot and basic prop unit test cases to the Stacked bar chart and Multi stacked bar chart.

Focus areas to test

Stacked bar chart
Multi stacked bar chart.

@khmakoto khmakoto mentioned this pull request Oct 27, 2020
Closed
40 tasks
@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 7958ea8:

Sandbox Source
Fluent UI Button Configuration
codesandbox-react-template Configuration
codesandbox-react-northstar-template Configuration

@msft-github-bot
Copy link
Contributor

Perf Analysis

No significant results to display.

All results

Scenario Render type Master Ticks PR Ticks Iterations Status
Avatar mount 843 817 5000
BaseButtonCompat mount 878 902 5000
Breadcrumb mount 43304 43843 5000
Checkbox mount 1471 1468 5000
CheckboxBase mount 1209 1277 5000
ChoiceGroup mount 4643 4658 5000
ComboBox mount 942 961 1000
CommandBar mount 10074 9982 1000
ContextualMenu mount 6024 6186 1000
DefaultButtonCompat mount 1139 1156 5000
DetailsRow mount 3605 3591 5000
DetailsRowFast mount 3495 3534 5000
DetailsRowNoStyles mount 3366 3365 5000
Dialog mount 1461 1532 1000
DocumentCardTitle mount 1803 1859 1000
Dropdown mount 3348 3303 5000
FocusTrapZone mount 1784 1782 5000
FocusZone mount 1803 1808 5000
IconButtonCompat mount 1694 1684 5000
Label mount 318 333 5000
Layer mount 1756 1741 5000
Link mount 459 462 5000
MenuButtonCompat mount 1464 1435 5000
MessageBar mount 2004 2051 5000
Nav mount 3215 3164 1000
OverflowSet mount 1024 1032 5000
Panel mount 1418 1410 1000
Persona mount 837 866 1000
Pivot mount 1366 1402 1000
PrimaryButtonCompat mount 1255 1270 5000
Rating mount 7268 7424 5000
SearchBox mount 1278 1262 5000
Shimmer mount 2473 2503 5000
Slider mount 1898 1881 5000
SpinButton mount 4922 4918 5000
Spinner mount 410 406 5000
SplitButtonCompat mount 3121 3119 5000
Stack mount 491 488 5000
StackWithIntrinsicChildren mount 1489 1481 5000
StackWithTextChildren mount 4463 4526 5000
SwatchColorPicker mount 9938 10020 5000
TagPicker mount 2761 2690 5000
TeachingBubble mount 11455 11587 5000
Text mount 415 420 5000
TextField mount 1350 1348 5000
ThemeProvider mount 1948 1927 5000
ThemeProvider virtual-rerender 642 647 5000
Toggle mount 787 762 5000
button mount 542 548 5000
buttonNative mount 125 109 5000

Perf Analysis (Fluent)

Perf comparison
Status Scenario Fluent TPI Fabric TPI Ratio Iterations Ticks
🎯 Avatar.Fluent 0.44 0.5 0.88:1 2000 888
🦄 Button.Fluent 0.11 0.22 0.5:1 5000 553
🔧 Checkbox.Fluent 0.62 0.31 2:1 1000 615
🎯 Dialog.Fluent 0.16 0.22 0.73:1 5000 802
🔧 Dropdown.Fluent 2.94 0.4 7.35:1 1000 2941
🔧 Icon.Fluent 0.14 0.06 2.33:1 5000 703
🦄 Image.Fluent 0.08 0.12 0.67:1 5000 392
🔧 Slider.Fluent 1.54 0.43 3.58:1 1000 1541
🔧 Text.Fluent 0.07 0.03 2.33:1 5000 370
🦄 Tooltip.Fluent 0.11 0.88 0.13:1 5000 573

🔧 Needs work     🎯 On target     🦄 Amazing

Perf tests with no regressions
Scenario Current PR Ticks Baseline Ticks Ratio
ButtonMinimalPerf.default 190 170 1.12:1
ChatWithPopoverPerf.default 494 448 1.1:1
PortalMinimalPerf.default 179 164 1.09:1
SegmentMinimalPerf.default 391 363 1.08:1
AttachmentMinimalPerf.default 172 161 1.07:1
BoxMinimalPerf.default 379 354 1.07:1
VideoMinimalPerf.default 642 608 1.06:1
FormMinimalPerf.default 431 410 1.05:1
HeaderSlotsPerf.default 822 782 1.05:1
CardMinimalPerf.default 573 551 1.04:1
LoaderMinimalPerf.default 744 716 1.04:1
RefMinimalPerf.default 264 254 1.04:1
SkeletonMinimalPerf.default 447 431 1.04:1
ToolbarMinimalPerf.default 981 941 1.04:1
Text.Fluent 370 356 1.04:1
Tooltip.Fluent 573 551 1.04:1
GridMinimalPerf.default 360 351 1.03:1
LayoutMinimalPerf.default 417 404 1.03:1
TooltipMinimalPerf.default 836 808 1.03:1
AttachmentSlotsPerf.default 1125 1101 1.02:1
CheckboxMinimalPerf.default 2887 2838 1.02:1
DropdownManyItemsPerf.default 740 725 1.02:1
ImageMinimalPerf.default 405 397 1.02:1
Dialog.Fluent 802 787 1.02:1
AlertMinimalPerf.default 302 298 1.01:1
ButtonUseCssNestingPerf.default 1072 1059 1.01:1
HeaderMinimalPerf.default 394 389 1.01:1
ListMinimalPerf.default 508 501 1.01:1
ReactionMinimalPerf.default 431 426 1.01:1
SplitButtonMinimalPerf.default 3730 3701 1.01:1
TableManyItemsPerf.default 2165 2152 1.01:1
Avatar.Fluent 888 883 1.01:1
Button.Fluent 553 548 1.01:1
CarouselMinimalPerf.default 450 452 1:1
DialogMinimalPerf.default 799 799 1:1
DropdownMinimalPerf.default 2933 2923 1:1
ItemLayoutMinimalPerf.default 1281 1278 1:1
ListCommonPerf.default 669 672 1:1
MenuButtonMinimalPerf.default 1570 1575 1:1
PopupMinimalPerf.default 707 707 1:1
ProviderMinimalPerf.default 1022 1018 1:1
SliderMinimalPerf.default 1571 1578 1:1
CustomToolbarPrototype.default 3900 3898 1:1
TreeMinimalPerf.default 902 905 1:1
TreeWith60ListItems.default 214 214 1:1
Dropdown.Fluent 2941 2954 1:1
Icon.Fluent 703 704 1:1
Image.Fluent 392 391 1:1
AvatarMinimalPerf.default 467 474 0.99:1
ButtonOverridesMissPerf.default 1692 1710 0.99:1
ButtonUseCssPerf.default 809 816 0.99:1
DividerMinimalPerf.default 390 394 0.99:1
EmbedMinimalPerf.default 1940 1951 0.99:1
ListWith60ListItems.default 950 962 0.99:1
MenuMinimalPerf.default 872 885 0.99:1
ProviderMergeThemesPerf.default 2061 2074 0.99:1
TextAreaMinimalPerf.default 487 493 0.99:1
Slider.Fluent 1541 1563 0.99:1
InputMinimalPerf.default 1298 1320 0.98:1
ListNestedPerf.default 587 599 0.98:1
RadioGroupMinimalPerf.default 451 462 0.98:1
StatusMinimalPerf.default 712 725 0.98:1
TextMinimalPerf.default 357 366 0.98:1
Checkbox.Fluent 615 629 0.98:1
FlexMinimalPerf.default 306 317 0.97:1
TableMinimalPerf.default 404 417 0.97:1
AnimationMinimalPerf.default 399 416 0.96:1
ButtonSlotsPerf.default 576 599 0.96:1
ChatDuplicateMessagesPerf.default 425 442 0.96:1
ChatMinimalPerf.default 617 645 0.96:1
IconMinimalPerf.default 653 686 0.95:1
LabelMinimalPerf.default 430 458 0.94:1
AccordionMinimalPerf.default 151 167 0.9:1

@size-auditor
Copy link

size-auditor bot commented Oct 27, 2020

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: f67490d9a7c81323c4358c3f5a40b36b758b7439 (build)

@ecraig12345 ecraig12345 merged commit 766f500 into microsoft:master Oct 27, 2020
@khmakoto khmakoto deleted the stackedBarChartsTests branch October 27, 2020 04:04
SethDonohue pushed a commit to SethDonohue/fluentui that referenced this pull request Nov 2, 2020
@khmakoto
Charting: Adding tests for StackedBarChart and MultiStackedBarChart (m…
89fcf8d 
…icrosoft#15708)

Cherry-pick of microsoft#15578.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ecraig12345 ecraig12345 ecraig12345 approved these changes

@Raghurk Raghurk Awaiting requested review from Raghurk

Assignees

@tomi-msft tomi-msft

Labels
Package: charting
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@khmakoto @msft-github-bot @ecraig12345 @tomi-msft