Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Charting: Adding tests for AreaChart #15702

Merged
merged 2 commits into from
Oct 26, 2020

Conversation

khmakoto
Copy link
Member

Pull request checklist

Description of changes

Cherry-pick of #15520.

Original PR description:

Added Snapshot and basic unit test cases to area chart.

Focus areas to test

Area chart.

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 797f840:

Sandbox Source
Fluent UI Button Configuration
codesandbox-react-template Configuration
codesandbox-react-northstar-template Configuration

@khmakoto khmakoto changed the title Area chart tests Charting: Adding tests for AreaChart Oct 26, 2020
@msft-github-bot
Copy link
Contributor

Perf Analysis

No significant results to display.

All results

Scenario Render type Master Ticks PR Ticks Iterations Status
Avatar mount 863 850 5000
BaseButtonCompat mount 932 910 5000
Breadcrumb mount 153675 152141 5000
Checkbox mount 1548 1556 5000
CheckboxBase mount 1317 1288 5000
ChoiceGroup mount 4823 4835 5000
ComboBox mount 973 970 1000
CommandBar mount 21062 21095 1000
ContextualMenu mount 5954 5927 1000
DefaultButtonCompat mount 1147 1133 5000
DetailsRow mount 3655 3657 5000
DetailsRowFast mount 3581 3619 5000
DetailsRowNoStyles mount 3451 3470 5000
Dialog mount 1485 1491 1000
DocumentCardTitle mount 1744 1744 1000
Dropdown mount 3411 3436 5000
FocusTrapZone mount 1787 1780 5000
FocusZone mount 1802 1753 5000
IconButtonCompat mount 1790 1792 5000
Label mount 330 343 5000
Layer mount 1826 1826 5000
Link mount 466 464 5000
MenuButtonCompat mount 1520 1516 5000
MessageBar mount 1982 2026 5000
Nav mount 3231 3212 1000
OverflowSet mount 1055 1048 5000
Panel mount 1465 1457 1000
Persona mount 862 895 1000
Pivot mount 1484 1445 1000
PrimaryButtonCompat mount 1337 1353 5000
Rating mount 7933 7783 5000
SearchBox mount 1385 1397 5000
Shimmer mount 2778 2662 5000
Slider mount 1979 1960 5000
SpinButton mount 5132 5181 5000
Spinner mount 405 404 5000
SplitButtonCompat mount 3215 3210 5000
Stack mount 517 509 5000
StackWithIntrinsicChildren mount 1555 1514 5000
StackWithTextChildren mount 4870 4769 5000
SwatchColorPicker mount 10198 10207 5000
TagPicker mount 2752 2763 5000
TeachingBubble mount 11349 11297 5000
Text mount 433 455 5000
TextField mount 1396 1387 5000
ThemeProvider mount 1915 1926 5000
ThemeProvider virtual-rerender 623 630 5000
Toggle mount 758 808 5000
button mount 535 553 5000
buttonNative mount 110 105 5000

Perf Analysis (Fluent)

Perf comparison
Status Scenario Fluent TPI Fabric TPI Ratio Iterations Ticks
🎯 Avatar.Fluent 0.47 0.51 0.92:1 2000 942
🦄 Button.Fluent 0.13 0.24 0.54:1 5000 632
🔧 Checkbox.Fluent 0.65 0.36 1.81:1 1000 652
🎯 Dialog.Fluent 0.16 0.22 0.73:1 5000 815
🔧 Dropdown.Fluent 2.89 0.43 6.72:1 1000 2891
🔧 Icon.Fluent 0.15 0.06 2.5:1 5000 770
🦄 Image.Fluent 0.09 0.13 0.69:1 5000 434
🔧 Slider.Fluent 1.52 0.45 3.38:1 1000 1519
🔧 Text.Fluent 0.08 0.03 2.67:1 5000 400
🦄 Tooltip.Fluent 0.11 0.89 0.12:1 5000 556

🔧 Needs work     🎯 On target     🦄 Amazing

Perf tests with no regressions
Scenario Current PR Ticks Baseline Ticks Ratio
BoxMinimalPerf.default 424 384 1.1:1
HeaderSlotsPerf.default 859 805 1.07:1
LabelMinimalPerf.default 465 438 1.06:1
AttachmentMinimalPerf.default 176 168 1.05:1
CarouselMinimalPerf.default 492 468 1.05:1
DropdownManyItemsPerf.default 807 771 1.05:1
PortalMinimalPerf.default 166 158 1.05:1
RefMinimalPerf.default 244 233 1.05:1
IconMinimalPerf.default 737 701 1.05:1
ButtonMinimalPerf.default 199 192 1.04:1
CardMinimalPerf.default 617 595 1.04:1
ChatMinimalPerf.default 669 642 1.04:1
DialogMinimalPerf.default 836 807 1.04:1
GridMinimalPerf.default 383 367 1.04:1
ListMinimalPerf.default 543 520 1.04:1
TableMinimalPerf.default 455 439 1.04:1
TooltipMinimalPerf.default 859 825 1.04:1
TreeWith60ListItems.default 217 208 1.04:1
AttachmentSlotsPerf.default 1178 1144 1.03:1
AvatarMinimalPerf.default 508 495 1.03:1
ButtonOverridesMissPerf.default 1714 1669 1.03:1
ChatDuplicateMessagesPerf.default 438 425 1.03:1
DividerMinimalPerf.default 399 386 1.03:1
ItemLayoutMinimalPerf.default 1372 1335 1.03:1
LayoutMinimalPerf.default 448 433 1.03:1
RadioGroupMinimalPerf.default 484 469 1.03:1
SplitButtonMinimalPerf.default 3937 3830 1.03:1
TextMinimalPerf.default 395 382 1.03:1
Image.Fluent 434 423 1.03:1
Text.Fluent 400 389 1.03:1
AccordionMinimalPerf.default 173 170 1.02:1
ButtonUseCssPerf.default 863 850 1.02:1
FormMinimalPerf.default 475 467 1.02:1
ImageMinimalPerf.default 435 425 1.02:1
ListWith60ListItems.default 979 959 1.02:1
LoaderMinimalPerf.default 762 744 1.02:1
MenuMinimalPerf.default 913 898 1.02:1
MenuButtonMinimalPerf.default 1651 1612 1.02:1
ProviderMinimalPerf.default 1019 999 1.02:1
ReactionMinimalPerf.default 455 447 1.02:1
SliderMinimalPerf.default 1564 1532 1.02:1
TreeMinimalPerf.default 939 923 1.02:1
Avatar.Fluent 942 921 1.02:1
Button.Fluent 632 617 1.02:1
Dropdown.Fluent 2891 2841 1.02:1
AnimationMinimalPerf.default 429 424 1.01:1
ButtonUseCssNestingPerf.default 1101 1088 1.01:1
CheckboxMinimalPerf.default 2878 2859 1.01:1
InputMinimalPerf.default 1305 1291 1.01:1
PopupMinimalPerf.default 710 704 1.01:1
ProviderMergeThemesPerf.default 2007 1982 1.01:1
TableManyItemsPerf.default 2343 2324 1.01:1
CustomToolbarPrototype.default 3793 3773 1.01:1
Icon.Fluent 770 761 1.01:1
ChatWithPopoverPerf.default 474 475 1:1
DropdownMinimalPerf.default 2859 2868 1:1
FlexMinimalPerf.default 321 322 1:1
TextAreaMinimalPerf.default 546 546 1:1
Checkbox.Fluent 652 651 1:1
ButtonSlotsPerf.default 616 621 0.99:1
EmbedMinimalPerf.default 1993 2010 0.99:1
ListNestedPerf.default 617 624 0.99:1
SegmentMinimalPerf.default 381 386 0.99:1
Dialog.Fluent 815 820 0.99:1
Tooltip.Fluent 556 564 0.99:1
ToolbarMinimalPerf.default 996 1013 0.98:1
VideoMinimalPerf.default 677 690 0.98:1
HeaderMinimalPerf.default 395 408 0.97:1
ListCommonPerf.default 686 709 0.97:1
StatusMinimalPerf.default 760 784 0.97:1
Slider.Fluent 1519 1567 0.97:1
SkeletonMinimalPerf.default 450 470 0.96:1
AlertMinimalPerf.default 307 331 0.93:1

@size-auditor
Copy link

size-auditor bot commented Oct 26, 2020

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: 0b370e43432789ee9b170f60a8276b594493ca7a (build)

@ecraig12345 ecraig12345 merged commit 0fe2bfa into microsoft:master Oct 26, 2020
@khmakoto khmakoto deleted the areaChartTests branch October 26, 2020 23:47
SethDonohue pushed a commit to SethDonohue/fluentui that referenced this pull request Nov 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants