Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Charting: Adding tests for LineChart #15700

Merged
merged 3 commits into from
Oct 26, 2020
Merged

Charting: Adding tests for LineChart #15700

merged 3 commits into from
Oct 26, 2020

Conversation

khmakoto
Copy link
Member

Pull request checklist

Description of changes

Cherry-pick of #15507.

Original PR description:

Test cases for charting: Line chart

Focus areas to test

(optional)

@khmakoto khmakoto mentioned this pull request Oct 26, 2020
Closed
40 tasks
@codesandbox-ci
Copy link

codesandbox-ci bot commented Oct 26, 2020 •
edited
Loading

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 962cafe:

Sandbox Source
Fluent UI Button Configuration
codesandbox-react-template Configuration
codesandbox-react-northstar-template Configuration

@msft-github-bot
Copy link
Contributor

Perf Analysis

No significant results to display.

All results

Scenario Render type Master Ticks PR Ticks Iterations Status
Avatar mount 841 835 5000
BaseButtonCompat mount 871 861 5000
Breadcrumb mount 158685 156896 5000
Checkbox mount 1482 1510 5000
CheckboxBase mount 1247 1245 5000
ChoiceGroup mount 4680 4689 5000
ComboBox mount 952 980 1000
CommandBar mount 21929 21663 1000
ContextualMenu mount 5998 5941 1000
DefaultButtonCompat mount 1108 1102 5000
DetailsRow mount 3688 3585 5000
DetailsRowFast mount 3558 3528 5000
DetailsRowNoStyles mount 3374 3353 5000
Dialog mount 1522 1485 1000
DocumentCardTitle mount 1781 1806 1000
Dropdown mount 3327 3342 5000
FocusTrapZone mount 1823 1828 5000
FocusZone mount 1800 1807 5000
IconButtonCompat mount 1745 1730 5000
Label mount 328 330 5000
Layer mount 1764 1818 5000
Link mount 476 453 5000
MenuButtonCompat mount 1466 1442 5000
MessageBar mount 2003 2058 5000
Nav mount 3190 3157 1000
OverflowSet mount 1016 1020 5000
Panel mount 1390 1420 1000
Persona mount 828 873 1000
Pivot mount 1365 1357 1000
PrimaryButtonCompat mount 1221 1236 5000
Rating mount 7312 7220 5000
SearchBox mount 1300 1286 5000
Shimmer mount 2549 2496 5000
Slider mount 1875 1878 5000
SpinButton mount 4917 4940 5000
Spinner mount 421 430 5000
SplitButtonCompat mount 3105 3178 5000
Stack mount 492 508 5000
StackWithIntrinsicChildren mount 1478 1491 5000
StackWithTextChildren mount 4513 4524 5000
SwatchColorPicker mount 10000 9852 5000
TagPicker mount 2706 2669 5000
TeachingBubble mount 11292 11111 5000
Text mount 415 437 5000
TextField mount 1361 1376 5000
ThemeProvider mount 2010 1965 5000
ThemeProvider virtual-rerender 627 631 5000
Toggle mount 803 778 5000
button mount 524 579 5000
buttonNative mount 115 112 5000

Perf Analysis (Fluent)

⚠️ 1 potential perf regressions detected

Potential regressions comparing to master

Scenario Current PR Ticks Baseline Ticks Ratio Regression Analysis
AttachmentMinimalPerf.default 170 157 1.08:1 analysis
Perf comparison
Status Scenario Fluent TPI Fabric TPI Ratio Iterations Ticks
🎯 Avatar.Fluent 0.45 0.5 0.9:1 2000 901
🦄 Button.Fluent 0.12 0.23 0.52:1 5000 583
🔧 Checkbox.Fluent 0.65 0.32 2.03:1 1000 653
🎯 Dialog.Fluent 0.16 0.23 0.7:1 5000 816
🔧 Dropdown.Fluent 3.01 0.39 7.72:1 1000 3006
🔧 Icon.Fluent 0.15 0.06 2.5:1 5000 742
🦄 Image.Fluent 0.08 0.13 0.62:1 5000 414
🔧 Slider.Fluent 1.62 0.43 3.77:1 1000 1616
🔧 Text.Fluent 0.08 0.04 2:1 5000 377
🦄 Tooltip.Fluent 0.11 0.9 0.12:1 5000 573

🔧 Needs work     🎯 On target     🦄 Amazing

Perf tests with no regressions
Scenario Current PR Ticks Baseline Ticks Ratio
PortalMinimalPerf.default 171 151 1.13:1
ButtonMinimalPerf.default 187 169 1.11:1
AnimationMinimalPerf.default 436 400 1.09:1
FlexMinimalPerf.default 316 296 1.07:1
ReactionMinimalPerf.default 416 394 1.06:1
RefMinimalPerf.default 249 234 1.06:1
CarouselMinimalPerf.default 457 435 1.05:1
SkeletonMinimalPerf.default 430 411 1.05:1
Checkbox.Fluent 653 624 1.05:1
HeaderSlotsPerf.default 783 753 1.04:1
Dialog.Fluent 816 783 1.04:1
CardMinimalPerf.default 569 552 1.03:1
DropdownManyItemsPerf.default 755 733 1.03:1
GridMinimalPerf.default 365 356 1.03:1
HeaderMinimalPerf.default 389 377 1.03:1
ListNestedPerf.default 600 581 1.03:1
TooltipMinimalPerf.default 820 798 1.03:1
Text.Fluent 377 365 1.03:1
ButtonSlotsPerf.default 614 603 1.02:1
DividerMinimalPerf.default 392 384 1.02:1
ItemLayoutMinimalPerf.default 1266 1236 1.02:1
LayoutMinimalPerf.default 418 408 1.02:1
ListWith60ListItems.default 954 933 1.02:1
PopupMinimalPerf.default 719 706 1.02:1
TableMinimalPerf.default 418 411 1.02:1
Avatar.Fluent 901 881 1.02:1
Dropdown.Fluent 3006 2941 1.02:1
Image.Fluent 414 405 1.02:1
AttachmentSlotsPerf.default 1142 1130 1.01:1
ButtonOverridesMissPerf.default 1688 1674 1.01:1
ButtonUseCssNestingPerf.default 1097 1088 1.01:1
DropdownMinimalPerf.default 2924 2897 1.01:1
EmbedMinimalPerf.default 1903 1881 1.01:1
FormMinimalPerf.default 422 419 1.01:1
ListMinimalPerf.default 515 510 1.01:1
ProviderMergeThemesPerf.default 2064 2051 1.01:1
TableManyItemsPerf.default 2174 2143 1.01:1
TreeMinimalPerf.default 872 865 1.01:1
Button.Fluent 583 576 1.01:1
Slider.Fluent 1616 1606 1.01:1
Tooltip.Fluent 573 570 1.01:1
ButtonUseCssPerf.default 816 813 1:1
ChatMinimalPerf.default 628 627 1:1
DialogMinimalPerf.default 790 792 1:1
ImageMinimalPerf.default 385 385 1:1
InputMinimalPerf.default 1300 1302 1:1
MenuMinimalPerf.default 877 873 1:1
MenuButtonMinimalPerf.default 1578 1585 1:1
ProviderMinimalPerf.default 1006 1002 1:1
SplitButtonMinimalPerf.default 3746 3733 1:1
StatusMinimalPerf.default 715 714 1:1
AvatarMinimalPerf.default 460 466 0.99:1
ChatDuplicateMessagesPerf.default 434 438 0.99:1
CheckboxMinimalPerf.default 2811 2832 0.99:1
ListCommonPerf.default 645 654 0.99:1
CustomToolbarPrototype.default 3845 3869 0.99:1
ToolbarMinimalPerf.default 931 944 0.99:1
VideoMinimalPerf.default 619 626 0.99:1
Icon.Fluent 742 747 0.99:1
BoxMinimalPerf.default 366 372 0.98:1
ChatWithPopoverPerf.default 476 487 0.98:1
RadioGroupMinimalPerf.default 429 438 0.98:1
TextMinimalPerf.default 370 376 0.98:1
AlertMinimalPerf.default 298 308 0.97:1
LabelMinimalPerf.default 419 432 0.97:1
SegmentMinimalPerf.default 367 377 0.97:1
SliderMinimalPerf.default 1559 1613 0.97:1
IconMinimalPerf.default 669 689 0.97:1
TextAreaMinimalPerf.default 491 509 0.96:1
AccordionMinimalPerf.default 151 160 0.94:1
LoaderMinimalPerf.default 711 777 0.92:1
TreeWith60ListItems.default 201 220 0.91:1

@size-auditor
Copy link

size-auditor bot commented Oct 26, 2020

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: 26ce5d6cddc160738ba5cbecd136de044d6b0240 (build)

@ecraig12345 ecraig12345 merged commit 0b370e4 into microsoft:master Oct 26, 2020
@khmakoto khmakoto deleted the lineChartTests branch October 26, 2020 21:37
SethDonohue pushed a commit to SethDonohue/fluentui that referenced this pull request Nov 2, 2020
@khmakoto
Charting: Adding tests for LineChart (microsoft#15700)
a166429 
Cherry-pick of microsoft#15507.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ecraig12345 ecraig12345 ecraig12345 approved these changes

@Raghurk Raghurk Awaiting requested review from Raghurk

Assignees

@tomi-msft tomi-msft

Labels
Package: charting
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@khmakoto @msft-github-bot @ecraig12345 @tomi-msft