Charting: Adding customized callout support to AreaChart and LineChart #15684
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
40 tasks
ecraig12345
approved these changes
Oct 23, 2020
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 389e6cf:
|
Perf AnalysisNo significant results to display. All results
Perf Analysis (Fluent)Perf comparison
Perf tests with no regressions
|
2 tasks
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: ea7178e75c96d7cd9175c28260ec13cd3f8515b9 (build) |
|
🎉 Handy links: |
SethDonohue
pushed a commit
to SethDonohue/fluentui
that referenced
this pull request
Nov 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request checklist
$ yarn changeDescription of changes
Cherry-pick of #15361.
Original PR description:
Custom callout support added to Area chart and line chart.
To add this, Exposed callout props and added a new callback method prop to the chart props. As a callback, below details will be available.
Implementing custom callout feature, Need to implement own callout component and need to pass props like below ( See Examples file for better understanding.
Focus areas to test
Area chart
Line chart
Screenshots
Area Chart
Default behavior
Custom callout
Line chart
Default behavior
Custom callout
Test link: http://fabricweb.z5.web.core.windows.net/pr-deploy-site/refs/pull/15361/merge/charting/dist/index.html#/examples/areachart