Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update fluid note filetype icon #15649

Merged
merged 3 commits into from
Oct 23, 2020
Merged

Update fluid note filetype icon #15649

merged 3 commits into from
Oct 23, 2020

Conversation

bigbadcapers
Copy link
Contributor

Pull request checklist

  • Updating reference to latest CDN
  • Mapping .note file extension to the one filetype icon.
  • Include a change request file using $ yarn change

@bigbadcapers bigbadcapers requested a review from Jahnp as a code owner October 22, 2020 20:22
@msft-github-bot msft-github-bot added the needs cherry-pick Temporary label for PRs which may need to be cherry-picked to master label Oct 22, 2020
@codesandbox-ci
Copy link

codesandbox-ci bot commented Oct 22, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 0e6269f:

Sandbox Source
Fluent UI Button Configuration
codesandbox-react-template Configuration

@msft-github-bot
Copy link
Contributor

msft-github-bot commented Oct 22, 2020

Perf Analysis

No significant results to display.

All results

Scenario Render type 7.0 Ticks PR Ticks Iterations Status
BaseButton mount 907 926 5000
Breadcrumb mount 39310 39184 5000
Checkbox mount 1603 1625 5000
CheckboxBase mount 1348 1308 5000
ChoiceGroup mount 5047 4982 5000
ComboBox mount 912 919 1000
CommandBar mount 7421 7381 1000
ContextualMenu mount 12419 12706 1000
DefaultButton mount 1153 1144 5000
DetailsRow mount 3589 3616 5000
DetailsRowFast mount 3571 3560 5000
DetailsRowNoStyles mount 3425 3424 5000
Dialog mount 1511 1515 1000
DocumentCardTitle mount 1729 1742 1000
Dropdown mount 2684 2583 5000
FocusTrapZone mount 1719 1731 5000
FocusZone mount 1754 1760 5000
IconButton mount 1796 1786 5000
Label mount 330 321 5000
Layer mount 1955 1922 5000
Link mount 435 432 5000
MenuButton mount 1485 1507 5000
MessageBar mount 2019 2042 5000
Nav mount 3281 3211 1000
OverflowSet mount 1422 1389 5000
Panel mount 1453 1444 1000
Persona mount 829 837 1000
Pivot mount 1421 1415 1000
PrimaryButton mount 1327 1320 5000
Rating mount 7750 7740 5000
SearchBox mount 1292 1321 5000
Shimmer mount 2581 2653 5000
Slider mount 1455 1531 5000
SpinButton mount 4965 5033 5000
Spinner mount 390 398 5000
SplitButton mount 3226 3260 5000
Stack mount 508 497 5000
StackWithIntrinsicChildren mount 1534 1561 5000
StackWithTextChildren mount 4762 4828 5000
SwatchColorPicker mount 10181 10323 5000
TagPicker mount 2774 2743 5000
TeachingBubble mount 47914 48552 5000
Text mount 416 449 5000
TextField mount 1423 1456 5000
Toggle mount 835 834 5000
button mount 101 102 5000

@size-auditor
Copy link

size-auditor bot commented Oct 22, 2020

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: 8fbc05642b7796dc5abae6bce4f298a35db0ad51 (build)

@msft-github-bot
Copy link
Contributor

🎉@uifabric/[email protected] has been released which incorporates this pull request.:tada:

Handy links:

@khmakoto khmakoto mentioned this pull request Oct 24, 2020
5 tasks
@bigbadcapers bigbadcapers deleted the caperez/fluid_note_filetype_icon branch January 19, 2021 21:01
@ecraig12345 ecraig12345 removed the needs cherry-pick Temporary label for PRs which may need to be cherry-picked to master label Jan 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants