Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Charting: Basic unit test cases for Heat map chart and Pie chart #15640

Merged

Conversation

jameelakowsar
Copy link
Contributor

Pull request checklist

Description of changes

Basic unit test cases and snapshot test cases for Heat map chart and Pie chart.

Focus areas to test

Heat map chart
Pie chart

@msft-github-bot msft-github-bot added the needs cherry-pick Temporary label for PRs which may need to be cherry-picked to master label Oct 22, 2020
@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit c61443e:

Sandbox Source
Fluent UI Button Configuration
codesandbox-react-template Configuration
codesandbox-react-next-template Configuration

@msft-github-bot
Copy link
Contributor

Perf Analysis

No significant results to display.

All results

Scenario Render type 7.0 Ticks PR Ticks Iterations Status
Avatar mount 804 806 5000
BaseButton mount 895 880 5000
Breadcrumb mount 41133 41794 5000
ButtonNext mount 641 659 5000
Checkbox mount 1530 1511 5000
CheckboxBase mount 1278 1262 5000
ChoiceGroup mount 4926 4850 5000
ComboBox mount 911 907 1000
CommandBar mount 7599 7571 1000
ContextualMenu mount 13639 13615 1000
DefaultButton mount 1132 1103 5000
DetailsRow mount 3512 3596 5000
DetailsRowFast mount 3552 3636 5000
DetailsRowNoStyles mount 3403 3387 5000
Dialog mount 1487 1453 1000
DocumentCardTitle mount 1819 1804 1000
Dropdown mount 2570 2508 5000
FocusTrapZone mount 1723 1723 5000
FocusZone mount 1805 1897 5000
IconButton mount 1756 1740 5000
Label mount 350 341 5000
Layer mount 1919 1931 5000
Link mount 454 428 5000
MenuButton mount 1464 1414 5000
MessageBar mount 2043 2068 5000
Nav mount 3224 3152 1000
OverflowSet mount 1394 1389 5000
Panel mount 1402 1425 1000
Persona mount 803 828 1000
Pivot mount 1404 1378 1000
PrimaryButton mount 1299 1309 5000
Rating mount 7509 7411 5000
SearchBox mount 1227 1249 5000
Shimmer mount 2515 2530 5000
Slider mount 1474 1462 5000
SpinButton mount 5001 4851 5000
Spinner mount 418 412 5000
SplitButton mount 3204 3141 5000
Stack mount 487 512 5000
StackWithIntrinsicChildren mount 1503 1535 5000
StackWithTextChildren mount 4530 4543 5000
SwatchColorPicker mount 10173 10202 5000
TagPicker mount 2701 2746 5000
TeachingBubble mount 49988 49677 5000
Text mount 417 436 5000
TextField mount 1363 1412 5000
ThemeProvider mount 1650 1660 5000
ThemeProvider virtual-rerender 602 624 5000
Toggle mount 797 802 5000
button mount 110 115 5000

@size-auditor
Copy link

size-auditor bot commented Oct 22, 2020

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: 0239b7d97b4515ac0a6078da27e99f5f00e8b05d (build)

@Raghurk Raghurk merged commit 8fbc056 into microsoft:7.0 Oct 22, 2020
@msft-github-bot
Copy link
Contributor

🎉@uifabric/[email protected] has been released which incorporates this pull request.:tada:

Handy links:

ecraig12345 pushed a commit that referenced this pull request Oct 27, 2020
SethDonohue pushed a commit to SethDonohue/fluentui that referenced this pull request Nov 2, 2020
@kubkon kubkon self-assigned this Jan 27, 2021
@kubkon
Copy link
Contributor

kubkon commented Jan 27, 2021

@ecraig12345: cherry-picked in #15711.

@ecraig12345 ecraig12345 removed the needs cherry-pick Temporary label for PRs which may need to be cherry-picked to master label Feb 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants