GroupedList: Fixing issue where paging new data into existing groups did not trigger re-render #15628
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…did not trigger re-render.
40 tasks
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 2df401d:
|
Perf AnalysisNo significant results to display. All results
Perf Analysis (Fluent)Perf comparison
Perf tests with no regressions
|
Asset size changes
Baseline commit: 3545f576557f05a2d907eaf07a7ae56dd16ae925 (build) |
dzearing
approved these changes
Oct 21, 2020
|
Hello @khmakoto! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
|
🎉 Handy links: |
SethDonohue
pushed a commit
to SethDonohue/fluentui
that referenced
this pull request
Nov 2, 2020
…did not trigger re-render (microsoft#15628) <!-- !!!!!!! IMPORTANT !!!!!!! Due to work we're currently doing to prepare master branch for our version 8 beta release, please hold-off submitting the PR until around October 12 if it's not urgent. If it is urgent, please submit the PR targeting the 7.0 branch. This change does not apply to react-northstar contributors. See microsoft#15222 for more details. Sorry for the inconvenience and short notice. --> #### Pull request checklist - [ ] Addresses an existing issue: Fixes #0000 - [x] Include a change request file using `$ yarn change` #### Description of changes _Cherry-pick of microsoft#15335._ _Original PR description:_ Reworked the logic in the new `getDerivedStateFromProps` function in `GroupedList` so it properly re-renders the `List` if any of the dependent props change. This fixes an issue where updating only the `items` would not actually trigger a re-render because they were not explicitly passed as props to the child `List` components. #### Focus areas to test Added a new unit test to validate updating the `items` in-place with the same groupings, using some placeholders to simulate paging.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request checklist
$ yarn changeDescription of changes
Cherry-pick of #15335.
Original PR description:
Reworked the logic in the new
getDerivedStateFromPropsfunction inGroupedListso it properly re-renders theListif any of the dependent props change. This fixes an issue where updating only theitemswould not actually trigger a re-render because they were not explicitly passed as props to the childListcomponents.Focus areas to test
Added a new unit test to validate updating the
itemsin-place with the same groupings, using some placeholders to simulate paging.