ensure elevated-corner-radius is applied to dialog

[chrisdholt]

Pull request checklist

• Addresses an existing issue: Fixes #0000
• Include a change request file using $ yarn change

Description of changes

Fixes a bug where the elevated corner radius was not being applied due to a missing calculation to pixels.

Focus areas to test

(optional)

[codesandbox-ci]

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 99a87ab:

Sandbox	Source
Fluent UI Button	Configuration
codesandbox-react-template	Configuration
codesandbox-react-next-template	Configuration
codesandbox-react-northstar-template	Configuration

[msft-github-bot]

Perf Analysis

No significant results to display.

All results

Scenario	Render type	7.0 Ticks	PR Ticks	Iterations	Status
Avatar	mount	903	919	5000
BaseButton	mount	1024	1014	5000
Breadcrumb	mount	42948	43066	5000
ButtonNext	mount	762	732	5000
Checkbox	mount	1719	1684	5000
CheckboxBase	mount	1483	1434	5000
ChoiceGroup	mount	5316	5452	5000
ComboBox	mount	993	989	1000
CommandBar	mount	8018	8040	1000
ContextualMenu	mount	14623	14625	1000
DefaultButton	mount	1271	1236	5000
DetailsRow	mount	3841	3953	5000
DetailsRowFast	mount	3878	3925	5000
DetailsRowNoStyles	mount	3665	3767	5000
Dialog	mount	1573	1613	1000
DocumentCardTitle	mount	1812	1861	1000
Dropdown	mount	2762	2793	5000
FocusTrapZone	mount	1795	1824	5000
FocusZone	mount	1858	1867	5000
IconButton	mount	1912	1947	5000
Label	mount	356	373	5000
Layer	mount	2119	2079	5000
Link	mount	491	493	5000
MenuButton	mount	1577	1617	5000
MessageBar	mount	2186	2171	5000
Nav	mount	3523	3428	1000
OverflowSet	mount	1537	1523	5000
Panel	mount	1540	1571	1000
Persona	mount	903	934	1000
Pivot	mount	1538	1486	1000
PrimaryButton	mount	1372	1395	5000
Rating	mount	8197	8216	5000
SearchBox	mount	1370	1384	5000
Shimmer	mount	2863	2835	5000
Slider	mount	1606	1648	5000
SpinButton	mount	5379	5414	5000
Spinner	mount	442	453	5000
SplitButton	mount	3383	3410	5000
Stack	mount	546	547	5000
StackWithIntrinsicChildren	mount	1615	1657	5000
StackWithTextChildren	mount	5165	5142	5000
SwatchColorPicker	mount	11038	11133	5000
TagPicker	mount	3005	3041	5000
TeachingBubble	mount	52246	52357	5000
Text	mount	471	489	5000
TextField	mount	1563	1547	5000
ThemeProvider	mount	1779	1761	5000
ThemeProvider	virtual-rerender	647	645	5000
Toggle	mount	892	883	5000
button	mount	126	111	5000

Perf Analysis (Fluent)

Perf comparison

Status	Scenario	Fluent TPI	Fabric TPI	Ratio	Iterations	Ticks
🎯	Avatar.Fluent	0.5	0.5	1:1	2000	995
🦄	Button.Fluent	0.13	0.23	0.57:1	5000	662
🔧	Checkbox.Fluent	0.72	0.4	1.8:1	1000	719
🎯	Dialog.Fluent	0.18	0.24	0.75:1	5000	879
🔧	Dropdown.Fluent	3.07	0.54	5.69:1	1000	3069
🔧	Icon.Fluent	0.17	0.07	2.43:1	5000	839
🦄	Image.Fluent	0.09	0.13	0.69:1	5000	445
🔧	Slider.Fluent	1.66	0.39	4.26:1	1000	1663
🔧	Text.Fluent	0.09	0.04	2.25:1	5000	429
🦄	Tooltip.Fluent	0.12	18.04	0.01:1	5000	616

🔧 Needs work     🎯 On target     🦄 Amazing

Perf tests with no regressions

Scenario	Current PR Ticks	Baseline Ticks	Ratio
AccordionMinimalPerf.default	197	0	Infinity:1
AlertMinimalPerf.default	361	0	Infinity:1
AttachmentMinimalPerf.default	225	0	Infinity:1
AttachmentSlotsPerf.default	1246	0	Infinity:1
AvatarMinimalPerf.default	559	0	Infinity:1
BoxMinimalPerf.default	432	0	Infinity:1
ButtonMinimalPerf.default	223	0	Infinity:1
ButtonOverridesMissPerf.default	1832	0	Infinity:1
ButtonSlotsPerf.default	660	0	Infinity:1
ButtonUseCssPerf.default	924	0	Infinity:1
ButtonUseCssNestingPerf.default	1221	0	Infinity:1
CardMinimalPerf.default	654	0	Infinity:1
CarouselMinimalPerf.default	518	0	Infinity:1
ChatMinimalPerf.default	703	0	Infinity:1
DialogMinimalPerf.default	891	0	Infinity:1
DividerMinimalPerf.default	430	0	Infinity:1
DropdownManyItemsPerf.default	856	0	Infinity:1
EmbedMinimalPerf.default	2207	0	Infinity:1
FlexMinimalPerf.default	356	0	Infinity:1
FormMinimalPerf.default	495	0	Infinity:1
GridMinimalPerf.default	426	0	Infinity:1
HeaderMinimalPerf.default	432	0	Infinity:1
HeaderSlotsPerf.default	911	0	Infinity:1
InputMinimalPerf.default	1409	0	Infinity:1
ItemLayoutMinimalPerf.default	1497	0	Infinity:1
LabelMinimalPerf.default	520	0	Infinity:1
LayoutMinimalPerf.default	515	0	Infinity:1
ListCommonPerf.default	736	0	Infinity:1
ListMinimalPerf.default	562	0	Infinity:1
ListNestedPerf.default	677	0	Infinity:1
ListWith60ListItems.default	1017	0	Infinity:1
LoaderMinimalPerf.default	806	0	Infinity:1
MenuMinimalPerf.default	981	0	Infinity:1
MenuButtonMinimalPerf.default	1818	0	Infinity:1
PortalMinimalPerf.default	177	0	Infinity:1
ProviderMergeThemesPerf.default	2158	0	Infinity:1
ProviderMinimalPerf.default	1096	0	Infinity:1
RadioGroupMinimalPerf.default	519	0	Infinity:1
ReactionMinimalPerf.default	476	0	Infinity:1
RefMinimalPerf.default	279	0	Infinity:1
SegmentMinimalPerf.default	439	0	Infinity:1
SkeletonMinimalPerf.default	525	0	Infinity:1
SliderMinimalPerf.default	1652	0	Infinity:1
SplitButtonMinimalPerf.default	4167	0	Infinity:1
StatusMinimalPerf.default	831	0	Infinity:1
IconMinimalPerf.default	762	0	Infinity:1
TableManyItemsPerf.default	2482	0	Infinity:1
TableMinimalPerf.default	475	0	Infinity:1
TextMinimalPerf.default	430	0	Infinity:1
TextAreaMinimalPerf.default	592	0	Infinity:1
CustomToolbarPrototype.default	4136	0	Infinity:1
ToolbarMinimalPerf.default	1084	0	Infinity:1
TooltipMinimalPerf.default	900	0	Infinity:1
TreeMinimalPerf.default	1018	0	Infinity:1
TreeWith60ListItems.default	211	0	Infinity:1
VideoMinimalPerf.default	721	0	Infinity:1
Avatar.Fluent	995	0	Infinity:1
Button.Fluent	662	0	Infinity:1
Checkbox.Fluent	719	0	Infinity:1
Dialog.Fluent	879	0	Infinity:1
Dropdown.Fluent	3069	0	Infinity:1
Icon.Fluent	839	0	Infinity:1
Image.Fluent	445	0	Infinity:1
Slider.Fluent	1663	0	Infinity:1
Text.Fluent	429	0	Infinity:1
Tooltip.Fluent	616	0	Infinity:1
CheckboxMinimalPerf.default	3092	1	3092:1
DropdownMinimalPerf.default	3052	1	3052:1
PopupMinimalPerf.default	799	1	799:1
ChatWithPopoverPerf.default	520	1	520:1
ChatDuplicateMessagesPerf.default	478	1	478:1
ImageMinimalPerf.default	464	1	464:1
AnimationMinimalPerf.default	454	1	454:1

[size-auditor]

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: 37759e2abeee45e825f47181fd05ddefabb31502 (build)

[nicholasrice]

@chrisdholt do you need the "fix: ..." in the title?

[chrisdholt]

@chrisdholt do you need the "fix: ..." in the title?

@nicholasrice no, yarn change is how the changelogs are generated. Doesn't matter here at all.

[xugao]

We are hoping to resume publishing from master today and delete web-components completely from 7.0 branch.
Therefore I am closing this PR and Chris will republish new one again master. Also from this moment on, please make new PRs against `master. If you need to publish anything super urgent today, please ping me :)