Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Charting: Vertical bar chart unit test cases updated #15523

Merged

Conversation

jameelakowsar
Copy link
Contributor

@jameelakowsar jameelakowsar commented Oct 15, 2020

Pull request checklist

Description of changes

Updated snapshot and basic unit test cases of the vertical bar chart.

Focus areas to test

Vertical bar chart

Jameela Kowsar Shaik (Zen3 Infosolutions America Inc) added 3 commits October 15, 2020 13:51
@msft-github-bot msft-github-bot added the needs cherry-pick Temporary label for PRs which may need to be cherry-picked to master label Oct 15, 2020
@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 2dc8f42:

Sandbox Source
Fluent UI Button Configuration
codesandbox-react-template Configuration
codesandbox-react-next-template Configuration
codesandbox-react-northstar-template Configuration

@msft-github-bot
Copy link
Contributor

Perf Analysis

No significant results to display.

All results

Scenario Render type 7.0 Ticks PR Ticks Iterations Status
Avatar mount 897 904 5000
BaseButton mount 998 1006 5000
Breadcrumb mount 43840 44697 5000
ButtonNext mount 724 705 5000
Checkbox mount 1740 1753 5000
CheckboxBase mount 1484 1462 5000
ChoiceGroup mount 5369 5464 5000
ComboBox mount 977 992 1000
CommandBar mount 8427 8338 1000
ContextualMenu mount 18281 18377 1000
DefaultButton mount 1254 1262 5000
DetailsRow mount 4063 4028 5000
DetailsRowFast mount 3940 3994 5000
DetailsRowNoStyles mount 3792 3812 5000
Dialog mount 1626 1600 1000
DocumentCardTitle mount 1889 1884 1000
Dropdown mount 2829 2836 5000
FocusTrapZone mount 1817 1840 5000
FocusZone mount 1879 1976 5000
IconButton mount 1951 1964 5000
Label mount 375 383 5000
Layer mount 2112 2150 5000
Link mount 482 509 5000
MenuButton mount 1634 1610 5000
MessageBar mount 2233 2232 5000
Nav mount 3619 3552 1000
OverflowSet mount 1564 1522 5000
Panel mount 1611 1549 1000
Persona mount 916 940 1000
Pivot mount 1565 1561 1000
PrimaryButton mount 1426 1400 5000
Rating mount 8527 8598 5000
SearchBox mount 1450 1431 5000
Shimmer mount 2909 2844 5000
Slider mount 1649 1687 5000
SpinButton mount 5511 5452 5000
Spinner mount 450 453 5000
SplitButton mount 3455 3496 5000
Stack mount 562 542 5000
StackWithIntrinsicChildren mount 1620 1624 5000
StackWithTextChildren mount 5103 5067 5000
SwatchColorPicker mount 11023 11096 5000
TagPicker mount 2866 2979 5000
TeachingBubble mount 53134 53440 5000
Text mount 465 482 5000
TextField mount 1553 1574 5000
ThemeProvider mount 1774 1740 5000
ThemeProvider virtual-rerender 650 653 5000
Toggle mount 877 910 5000
button mount 122 117 5000

Perf Analysis (Fluent)

Perf comparison
Status Scenario Fluent TPI Fabric TPI Ratio Iterations Ticks
🎯 Avatar.Fluent 0.5 0.51 0.98:1 2000 997
🦄 Button.Fluent 0.13 0.22 0.59:1 5000 657
🔧 Checkbox.Fluent 0.69 0.39 1.77:1 1000 694
🎯 Dialog.Fluent 0.18 0.24 0.75:1 5000 897
🔧 Dropdown.Fluent 3.07 0.53 5.79:1 1000 3070
🔧 Icon.Fluent 0.17 0.07 2.43:1 5000 847
🎯 Image.Fluent 0.1 0.13 0.77:1 5000 482
🔧 Slider.Fluent 1.65 0.4 4.12:1 1000 1646
🔧 Text.Fluent 0.08 0.03 2.67:1 5000 420
🦄 Tooltip.Fluent 0.13 20.4 0.01:1 5000 629

🔧 Needs work     🎯 On target     🦄 Amazing

Perf tests with no regressions
Scenario Current PR Ticks Baseline Ticks Ratio
AlertMinimalPerf.default 372 0 Infinity:1
AttachmentMinimalPerf.default 189 0 Infinity:1
AttachmentSlotsPerf.default 1297 0 Infinity:1
AvatarMinimalPerf.default 567 0 Infinity:1
BoxMinimalPerf.default 458 0 Infinity:1
ButtonMinimalPerf.default 203 0 Infinity:1
ButtonOverridesMissPerf.default 1892 0 Infinity:1
ButtonSlotsPerf.default 664 0 Infinity:1
ButtonUseCssPerf.default 933 0 Infinity:1
ButtonUseCssNestingPerf.default 1215 0 Infinity:1
CardMinimalPerf.default 672 0 Infinity:1
CarouselMinimalPerf.default 526 0 Infinity:1
ChatMinimalPerf.default 715 0 Infinity:1
ChatWithPopoverPerf.default 531 0 Infinity:1
CheckboxMinimalPerf.default 3101 0 Infinity:1
DialogMinimalPerf.default 882 0 Infinity:1
DividerMinimalPerf.default 440 0 Infinity:1
DropdownMinimalPerf.default 3109 0 Infinity:1
EmbedMinimalPerf.default 2140 0 Infinity:1
FlexMinimalPerf.default 363 0 Infinity:1
FormMinimalPerf.default 504 0 Infinity:1
GridMinimalPerf.default 413 0 Infinity:1
HeaderSlotsPerf.default 932 0 Infinity:1
ImageMinimalPerf.default 456 0 Infinity:1
InputMinimalPerf.default 1394 0 Infinity:1
ItemLayoutMinimalPerf.default 1470 0 Infinity:1
LayoutMinimalPerf.default 477 0 Infinity:1
ListWith60ListItems.default 1027 0 Infinity:1
LoaderMinimalPerf.default 796 0 Infinity:1
MenuMinimalPerf.default 986 0 Infinity:1
MenuButtonMinimalPerf.default 1774 0 Infinity:1
PopupMinimalPerf.default 787 0 Infinity:1
PortalMinimalPerf.default 171 0 Infinity:1
ProviderMergeThemesPerf.default 2175 0 Infinity:1
ProviderMinimalPerf.default 1079 0 Infinity:1
ReactionMinimalPerf.default 485 0 Infinity:1
RefMinimalPerf.default 267 0 Infinity:1
SegmentMinimalPerf.default 426 0 Infinity:1
SkeletonMinimalPerf.default 516 0 Infinity:1
SliderMinimalPerf.default 1681 0 Infinity:1
SplitButtonMinimalPerf.default 4160 0 Infinity:1
StatusMinimalPerf.default 856 0 Infinity:1
IconMinimalPerf.default 766 0 Infinity:1
TableManyItemsPerf.default 2547 0 Infinity:1
TextMinimalPerf.default 426 0 Infinity:1
TextAreaMinimalPerf.default 565 0 Infinity:1
CustomToolbarPrototype.default 4153 0 Infinity:1
ToolbarMinimalPerf.default 1096 0 Infinity:1
TooltipMinimalPerf.default 926 0 Infinity:1
TreeMinimalPerf.default 990 0 Infinity:1
TreeWith60ListItems.default 238 0 Infinity:1
VideoMinimalPerf.default 729 0 Infinity:1
Avatar.Fluent 997 0 Infinity:1
Button.Fluent 657 0 Infinity:1
Checkbox.Fluent 694 0 Infinity:1
Dialog.Fluent 897 0 Infinity:1
Dropdown.Fluent 3070 0 Infinity:1
Icon.Fluent 847 0 Infinity:1
Image.Fluent 482 0 Infinity:1
Slider.Fluent 1646 0 Infinity:1
Text.Fluent 420 0 Infinity:1
Tooltip.Fluent 629 0 Infinity:1
DropdownManyItemsPerf.default 864 1 864:1
ListCommonPerf.default 751 1 751:1
ListNestedPerf.default 665 1 665:1
ListMinimalPerf.default 604 1 604:1
RadioGroupMinimalPerf.default 536 1 536:1
LabelMinimalPerf.default 496 1 496:1
ChatDuplicateMessagesPerf.default 489 1 489:1
TableMinimalPerf.default 486 1 486:1
AnimationMinimalPerf.default 475 1 475:1
HeaderMinimalPerf.default 450 1 450:1
AccordionMinimalPerf.default 204 1 204:1

@size-auditor
Copy link

size-auditor bot commented Oct 15, 2020

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: 8828fdca589a3b4f9119798fb806163e29961a41 (build)

@jameelakowsar jameelakowsar marked this pull request as ready for review October 16, 2020 04:00
@Raghurk Raghurk merged commit 8d0a848 into microsoft:7.0 Oct 16, 2020
@msft-github-bot
Copy link
Contributor

🎉@uifabric/[email protected] has been released which incorporates this pull request.:tada:

Handy links:

ecraig12345 pushed a commit that referenced this pull request Oct 26, 2020
SethDonohue pushed a commit to SethDonohue/fluentui that referenced this pull request Nov 2, 2020
@ecraig12345 ecraig12345 removed the needs cherry-pick Temporary label for PRs which may need to be cherry-picked to master label Dec 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants